From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD302C5479D for ; Wed, 11 Jan 2023 23:10:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1C2A38559B; Thu, 12 Jan 2023 00:10:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 546A5855AF; Thu, 12 Jan 2023 00:10:29 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 7160685560 for ; Thu, 12 Jan 2023 00:10:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E782CFEC; Wed, 11 Jan 2023 15:11:07 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4AFDB3F71A; Wed, 11 Jan 2023 15:10:25 -0800 (PST) Date: Wed, 11 Jan 2023 23:08:32 +0000 From: Andre Przywara To: Samuel Holland Cc: Jaehoon Chung , u-boot@lists.denx.de Subject: Re: [PATCH 1/3] power: pmic: axp: Provide a variant ID in the driver data Message-ID: <20230111230832.0508ee17@slackpad.lan> In-Reply-To: <20221128064757.2933-2-samuel@sholland.org> References: <20221128064757.2933-1-samuel@sholland.org> <20221128064757.2933-2-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, 28 Nov 2022 00:47:54 -0600 Samuel Holland wrote: > Subordinate regulator drivers can use this enumerated ID instead of > matching the compatible string again. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > drivers/power/pmic/axp.c | 18 +++++++++--------- > include/axp_pmic.h | 12 ++++++++++++ > 2 files changed, 21 insertions(+), 9 deletions(-) > > diff --git a/drivers/power/pmic/axp.c b/drivers/power/pmic/axp.c > index 0f2b24a8b5f..e0005994e21 100644 > --- a/drivers/power/pmic/axp.c > +++ b/drivers/power/pmic/axp.c > @@ -64,15 +64,15 @@ static int axp_pmic_bind(struct udevice *dev) > } > > static const struct udevice_id axp_pmic_ids[] = { > - { .compatible = "x-powers,axp152" }, > - { .compatible = "x-powers,axp202" }, > - { .compatible = "x-powers,axp209" }, > - { .compatible = "x-powers,axp221" }, > - { .compatible = "x-powers,axp223" }, > - { .compatible = "x-powers,axp803" }, > - { .compatible = "x-powers,axp806" }, > - { .compatible = "x-powers,axp809" }, > - { .compatible = "x-powers,axp813" }, > + { .compatible = "x-powers,axp152", .data = AXP152_ID }, > + { .compatible = "x-powers,axp202", .data = AXP202_ID }, > + { .compatible = "x-powers,axp209", .data = AXP209_ID }, > + { .compatible = "x-powers,axp221", .data = AXP221_ID }, > + { .compatible = "x-powers,axp223", .data = AXP223_ID }, > + { .compatible = "x-powers,axp803", .data = AXP803_ID }, > + { .compatible = "x-powers,axp806", .data = AXP806_ID }, > + { .compatible = "x-powers,axp809", .data = AXP809_ID }, > + { .compatible = "x-powers,axp813", .data = AXP813_ID }, > { } > }; > > diff --git a/include/axp_pmic.h b/include/axp_pmic.h > index 01ebba63479..4ac64865831 100644 > --- a/include/axp_pmic.h > +++ b/include/axp_pmic.h > @@ -26,6 +26,18 @@ > #define AXP_PMIC_SEC_DEVICE_ADDR 0x745 > #define AXP_PMIC_SEC_RUNTIME_ADDR 0x3a > > +enum { > + AXP152_ID, > + AXP202_ID, > + AXP209_ID, > + AXP221_ID, > + AXP223_ID, > + AXP803_ID, > + AXP806_ID, > + AXP809_ID, > + AXP813_ID, > +}; > + > int axp_set_dcdc1(unsigned int mvolt); > int axp_set_dcdc2(unsigned int mvolt); > int axp_set_dcdc3(unsigned int mvolt);