Re: Please pull u-boot-dm

Tom Rini
2022-01-27T17:31:24Z

[-- Attachment #1: Type: text/plain, Size: 5876 bytes --]

On Wed, Jan 26, 2022 at 08:35:43PM -0700, Simon Glass wrote:

> Hi Tom,
>
> https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10771
>
>
> The following changes since commit 6146cd62aedc4849fec66f10ab0aa57f1dc64b8e:
>
> Merge branch '2022-01-24-assorted-updates' (2022-01-25 08:01:43 -0500)
>
> are available in the Git repository at:
>
> git://git.denx.de/u-boot-dm.git tags/dm-pull-26jan22
>
> for you to fetch changes up to 2d2384bbaff0ab84c868b553c74048a5f6acc9e3:
>
> tools: mkimage: Show where signatures/keys are written (2022-01-26
> 08:50:44 -0700)
>

I'm going to push back on this slightly. I ran "make pylint" (which
yes, is new) locally, and it complains about needing to update
scripts/pylint.base. Did that, and here's the less than obvious to me
results:

diff --git a/scripts/pylint.base b/scripts/pylint.base
index cefdc2355506..f5a045a384a9 100644
--- a/scripts/pylint.base
+++ b/scripts/pylint.base
@@ -1,71 +1,105 @@
+0.00 patman.checkpatch
+1.43 buildman.test
+1.71 buildman.builder
+10.00 binman.fmap_util
+3.12 rkmux
+3.25 patman.control
+4.15 buildman.board
+4.48 binman.main
+4.50 dtoc.fdt_util
+4.69 patman.tout
+4.74 patman.commit
+4.86 binman.setup
+5.00 binman.state
+5.00 dtoc.src_scan
+5.00 patman.status
+5.62 patman.main
+5.89 patman.setup
+6.16 patman.settings
+6.17 buildman.toolchain
+6.44 concurrencytest
+6.47 patman.gitutil
+6.67
+6.67 patman.series
+6.70 dtoc.main
+6.71 endian-swap
+6.81 patman.test_util
+6.88 binman.ftest
+6.89 patman.tools
+6.90 rmboard
+6.91 buildman.builderthread
+6.96 dtoc.test_src_scan
+7.05 patman.test_checkpatch
+7.10 binman.image_test
+7.18 buildman.kconfiglib
+7.25 moveconfig
+7.26 dtoc.dtb_platdata
+7.39 buildman.cmdline
+7.45 binman.image
+7.49 buildman.main
+7.56 patman.func_test
+7.76 zynqmp_pm_cfg_obj_convert
+7.78 dtoc.setup
+7.82 buildman.bsettings
+7.90 dtoc.fdt
+7.95 microcode-tool
+8.04 patman.command
+8.10 buildman.func_test
+8.14 patman.cros_subprocess
+8.14 patman.get_maintainer
+8.23 patman.patchstream
+8.32 patman
+8.56 dtoc.test_fdt
+8.62 patman.terminal
+8.91 dtoc.test_dtoc
+9.04 buildman.control
+9.11 patman.project
+9.29 genboardscfg
+9.43 efivar
_testing 0.83
+_testing 6.09
atf_bl31 -6.00
atf_fip 0.29
-binman.cbfs_util 8.38
-binman.cbfs_util_test 9.30
-binman.cmdline 9.09
-binman.control 4.92
+binman.bintool 8.59
+binman.bintool_test 9.87
+binman.cbfs_util 8.46
+binman.cbfs_util_test 9.38
+binman.cmdline 9.03
+binman.comp_util 6.88
+binman.control 5.01
binman.elf 6.73
binman.elf_test 5.41
-binman.entry 3.38
+binman.entry 3.36
binman.entry_test 5.34
binman.fdt_test 3.23
-binman.fip_util 9.86
-binman.fip_util_test 9.75
-binman.fmap_util 6.88
-binman.ftest 7.46
-binman.image 7.05
-binman.image_test 4.48
-binman.main 5.00
-binman.setup 5.00
-binman.state 4.15
+binman.fip_util 9.85
blob -1.58
blob_dtb -10.00
blob_ext -19.09
-blob_ext_list -0.32
+blob_ext_list 0.00
blob_named_by_arg -7.78
blob_phase -5.00
-buildman.board 7.82
-buildman.bsettings 1.71
-buildman.builder 6.91
-buildman.builderthread 7.39
-buildman.cmdline 9.04
-buildman.control 8.10
-buildman.func_test 7.18
-buildman.kconfiglib 7.49
-buildman.main 1.43
-buildman.test 6.17
-buildman.toolchain 6.55
capsule_defs 5.00
cbfs -1.44
+cbfstool 7.83
collection 2.67
-concurrencytest 7.26
conftest -3.29
conftest 1.88
conftest 5.13
conftest 6.56
cros_ec_rw -6.00
defs 6.67
-dtoc.dtb_platdata 7.90
-dtoc.fdt 4.50
-dtoc.fdt_util 6.70
-dtoc.main 7.78
-dtoc.setup 5.00
-dtoc.src_scan 8.91
-dtoc.test_dtoc 8.56
-dtoc.test_fdt 6.96
-dtoc.test_src_scan 9.43
-efivar 6.71
-endian-swap 9.29
fdtmap -3.28
files -7.43
fill -6.43
-fit 5.32
+fiptool 7.62
+fit 5.26
fmap -0.29
fstest_defs 8.33
fstest_helpers 4.29
-gbb -0.30
-genboardscfg 7.95
+futility 7.39
+gbb 0.83
+ifwitool 3.81
image_header 5.77
intel_cmc -12.50
intel_descriptor 4.62
@@ -75,43 +109,21 @@ intel_fsp -12.50
intel_fsp_m -12.50
intel_fsp_s -12.50
intel_fsp_t -12.50
-intel_ifwi 2.71
+intel_ifwi 2.88
intel_me -12.50
intel_mrc -10.00
intel_refcode -10.00
intel_vbt -12.50
intel_vga -12.50
-microcode-tool 7.25
-mkimage 2.57
-moveconfig 8.32
+lz4 6.30
+lzma_alone 6.97
+mkimage 2.31
+mkimage 7.86
multiplexed_log 7.49
opensbi -6.00
-patman 0.00
-patman.checkpatch 8.04
-patman.command 4.74
-patman.commit 3.25
-patman.control 8.14
-patman.cros_subprocess 7.56
-patman.func_test 8.14
-patman.get_maintainer 6.47
-patman.gitutil 5.62
-patman.main 8.23
-patman.patchstream 9.11
-patman.project 6.67
-patman.series 6.16
-patman.settings 5.89
-patman.setup 5.00
-patman.status 8.62
-patman.terminal 7.05
-patman.test_checkpatch 6.81
-patman.test_util 6.89
-patman.tools 4.31
-patman.tout 3.12
powerpc_mpc85xx_bootpg_resetvec -10.00
-rkmux 6.90
-rmboard 7.76
scp -6.00
-section 4.68
+section 4.56
sqfs_common 8.41
test 8.18
test_000_version 7.50
@@ -203,7 +215,7 @@ u_boot_tpl_with_ucode_ptr -20.83
u_boot_ucode 1.52
u_boot_utils 6.94
u_boot_with_ucode_ptr -0.71
-vblock -1.61
+vblock 0.27
vboot_evil 8.95
vboot_forge 9.22
x86_reset16 -15.71
@@ -212,4 +224,3 @@ x86_reset16_tpl -15.71
x86_start16 -15.71
x86_start16_spl -15.71
x86_start16_tpl -15.71
-zynqmp_pm_cfg_obj_convert 6.67

Entries like "score name" rather than "name score" are odd, why did that
happen? Also there's at least a few entries where the score decreased,
but I assume that's because of code removal. Can you interpret the
above and tell me what's going on, and that it makes sense to you at
least? And, as a problem, re-running "make pylint" with that base file
then fails with awk-spew related to "score name" and not "name score"
lines.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]