public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ovidiu Panait <ovpanait@gmail.com>
To: u-boot@lists.denx.de
Cc: Ovidiu Panait <ovpanait@gmail.com>,
	Alper Nebi Yasak <alpernebiyasak@gmail.com>,
	Andrew Davis <afd@ti.com>, Michal Simek <michal.simek@amd.com>,
	Michal Simek <monstr@monstr.eu>, Simon Glass <sjg@chromium.org>,
	Stefan Roese <sr@denx.de>
Subject: [PATCH] microblaze: spl: drop boot_linux and disable falcon mode by default
Date: Sun, 22 Jan 2023 20:02:54 +0200	[thread overview]
Message-ID: <20230122180255.1246963-1-ovpanait@gmail.com> (raw)

Make spl_start_uboot() available only if CONFIG_SPL_OS_BOOT is enabled
and drop boot_linux, as the variable is not assigned anywhere.

Also, disable CONFIG_SPL_OS_BOOT in defconfig so that a
microblaze-generic_defconfig build will still boot into u-boot proper, as
it does currently.

Signed-off-by: Ovidiu Panait <ovpanait@gmail.com>
---

 arch/microblaze/cpu/spl.c            | 11 ++---------
 common/spl/Kconfig                   |  2 ++
 configs/microblaze-generic_defconfig |  3 ---
 3 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/arch/microblaze/cpu/spl.c b/arch/microblaze/cpu/spl.c
index cea6d56f16..eaa095ba99 100644
--- a/arch/microblaze/cpu/spl.c
+++ b/arch/microblaze/cpu/spl.c
@@ -14,8 +14,6 @@
 #include <asm/u-boot.h>
 #include <linux/stringify.h>
 
-bool boot_linux;
-
 void board_boot_order(u32 *spl_boot_list)
 {
 	spl_boot_list[0] = BOOT_DEVICE_NOR;
@@ -41,17 +39,12 @@ void __noreturn jump_to_image_linux(struct spl_image_info *spl_image)
 
 	image_entry(NULL, 0, (ulong)spl_image->arg);
 }
-#endif /* CONFIG_SPL_OS_BOOT */
 
 int spl_start_uboot(void)
 {
-#ifdef CONFIG_SPL_OS_BOOT
-	if (boot_linux)
-		return 0;
-#endif
-
-	return 1;
+	return 0;
 }
+#endif /* CONFIG_SPL_OS_BOOT */
 
 int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 {
diff --git a/common/spl/Kconfig b/common/spl/Kconfig
index 3c2af453ab..de6d8c3a18 100644
--- a/common/spl/Kconfig
+++ b/common/spl/Kconfig
@@ -1081,6 +1081,7 @@ config SYS_SPL_ARGS_ADDR
 	hex "Address in memory to load 'args' file for Falcon Mode to"
 	depends on SPL_OS_BOOT
 	default 0x88000000 if ARCH_OMAP2PLUS
+	default 0x2a000000 if MICROBLAZE
 	help
 	  Address in memory where the 'args' file, typically a device tree
 	  will be loaded in to memory.
@@ -1092,6 +1093,7 @@ config SYS_NAND_SPL_KERNEL_OFFS
 config SYS_OS_BASE
 	hex "addr, where OS is found"
 	depends on SPL_OS_BOOT && SPL_NOR_SUPPORT
+	default 0x2c060000 if MICROBLAZE
 	help
 	  Specify the address, where the OS image is found, which
 	  gets booted.
diff --git a/configs/microblaze-generic_defconfig b/configs/microblaze-generic_defconfig
index be34941805..438540fbe4 100644
--- a/configs/microblaze-generic_defconfig
+++ b/configs/microblaze-generic_defconfig
@@ -33,9 +33,6 @@ CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 # CONFIG_SPL_SHARES_INIT_SP_ADDR is not set
 CONFIG_SPL_STACK=0x100000
 CONFIG_SPL_NOR_SUPPORT=y
-CONFIG_SPL_OS_BOOT=y
-CONFIG_SYS_SPL_ARGS_ADDR=0x2a000000
-CONFIG_SYS_OS_BASE=0x2c060000
 CONFIG_SYS_MAXARGS=15
 CONFIG_SYS_CBSIZE=512
 CONFIG_SYS_PBSIZE=544
-- 
2.25.1


             reply	other threads:[~2023-01-22 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22 18:02 Ovidiu Panait [this message]
2023-01-23  8:30 ` [PATCH] microblaze: spl: drop boot_linux and disable falcon mode by default Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230122180255.1246963-1-ovpanait@gmail.com \
    --to=ovpanait@gmail.com \
    --cc=afd@ti.com \
    --cc=alpernebiyasak@gmail.com \
    --cc=michal.simek@amd.com \
    --cc=monstr@monstr.eu \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox