Re: [PATCH v2 0/5] net: sun8i-emac: Allwinner D1 Support

[Andre Przywara <andre.przywara@arm.com>]

On Sun, 22 Jan 2023 16:51:01 -0600
Samuel Holland <samuel@sholland.org> wrote:

> D1 is a RISC-V SoC containing an EMAC compatible with the A64 EMAC. In a
> very roundabout way, this series finishes adding support for the D1 EMAC:
> patch 4 resolves a compiler warning when building the driver for RISC-V.
> The rest of the series is just cleanup requested by Jagan.

I like this one, nice cleanup, and nice patch structuring.
I will do a more thorough review later (ping me shall I forget about
this), but I aim to push this rather sooner than later.

Cheers,
Andre

> Changes in v2:
>  - Add a structure for driver data, and put the syscon offset there
> 
> Samuel Holland (5):
>   net: sun8i-emac: Add a structure for variant data
>   net: sun8i-emac: Add a flag for RMII support
>   net: sun8i-emac: Add a flag for the internal PHY switch
>   net: sun8i-emac: Use common syscon setup for R40
>   net: sun8i-emac: Remove the SoC variant ID
> 
>  drivers/net/sun8i_emac.c | 96 ++++++++++++++++++++++------------------
>  1 file changed, 53 insertions(+), 43 deletions(-)
>