From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C651C27C76 for ; Sun, 22 Jan 2023 23:48:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD9E6856B9; Mon, 23 Jan 2023 00:48:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DEDC9856DF; Mon, 23 Jan 2023 00:47:58 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 49DD0856B9 for ; Mon, 23 Jan 2023 00:47:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D424AD7; Sun, 22 Jan 2023 15:48:37 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6FDA03F5A1; Sun, 22 Jan 2023 15:47:54 -0800 (PST) Date: Sun, 22 Jan 2023 23:45:51 +0000 From: Andre Przywara To: Samuel Holland Cc: Jagan Teki , Joe Hershberger , Ramon Fried , u-boot@lists.denx.de Subject: Re: [PATCH v2 0/5] net: sun8i-emac: Allwinner D1 Support Message-ID: <20230122234551.3ba52de1@slackpad.lan> In-Reply-To: <20230122225107.62464-1-samuel@sholland.org> References: <20230122225107.62464-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, 22 Jan 2023 16:51:01 -0600 Samuel Holland wrote: > D1 is a RISC-V SoC containing an EMAC compatible with the A64 EMAC. In a > very roundabout way, this series finishes adding support for the D1 EMAC: > patch 4 resolves a compiler warning when building the driver for RISC-V. > The rest of the series is just cleanup requested by Jagan. I like this one, nice cleanup, and nice patch structuring. I will do a more thorough review later (ping me shall I forget about this), but I aim to push this rather sooner than later. Cheers, Andre > Changes in v2: > - Add a structure for driver data, and put the syscon offset there > > Samuel Holland (5): > net: sun8i-emac: Add a structure for variant data > net: sun8i-emac: Add a flag for RMII support > net: sun8i-emac: Add a flag for the internal PHY switch > net: sun8i-emac: Use common syscon setup for R40 > net: sun8i-emac: Remove the SoC variant ID > > drivers/net/sun8i_emac.c | 96 ++++++++++++++++++++++------------------ > 1 file changed, 53 insertions(+), 43 deletions(-) >