From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5E22C38142 for ; Mon, 23 Jan 2023 09:58:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B25B385716; Mon, 23 Jan 2023 10:58:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="E31rAjxz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D246B85707; Mon, 23 Jan 2023 10:58:24 +0100 (CET) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E9C3285722 for ; Mon, 23 Jan 2023 10:58:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id AE152E0005; Mon, 23 Jan 2023 09:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674467901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EaXrDWEkqb4eG7xlLU+mW0+GzezUliHSFIE7qmQ8euQ=; b=E31rAjxznAa8rIXB99VgrJvN+VKD1nw2fIInwHnNV9CCkK6lWvqSQY2gxe7SX/k+5z5dJe bjfWFiRyEaXGInBy/zHgLSgYc/RFYmelYB1v6+1ruxHsiE1yGIPrLI9LGUEfI8ZsTYQYgK V+amZEwvF0CTnFwniVVSQ9Qum3mQWOhlO8EVL0QlT6pGD3psS+/bUoqo9jWBPL1opq40Sq 7uFk7h5qw3gUv5UnsnrHFURs0SC2g19zdwouzzKbnJ4y9rAAyGCc8c1rLpbLXe+2r/3fsg pql23MQB9OpCpn8AlCI+cgS/zKN0FQ2XC4TKIksHEoFKCWhKvutqcMUJqdQcKA== Date: Mon, 23 Jan 2023 10:58:18 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Marek Vasut , Simon Glass , u-boot@lists.denx.de, Marcel Ziswiler , Francesco Dolcini Subject: Re: [PATCH v1 2/3] colibri-imx7: specify MTD partitions on command line Message-ID: <20230123105818.3fa4b26c@xps-13> In-Reply-To: References: <20230113184547.487322-1-francesco@dolcini.it> <20230113184547.487322-3-francesco@dolcini.it> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Francesco, francesco@dolcini.it wrote on Mon, 16 Jan 2023 14:58:28 +0100: > On Sun, Jan 15, 2023 at 03:33:25PM +0100, Marek Vasut wrote: > > On 1/13/23 19:45, Francesco Dolcini wrote: =20 > > > From: Francesco Dolcini > > >=20 > > > Disable fdt_fixup_mtdparts(), instead pass MTD partition on the comma= nd > > > line. This is the preferred method to be used when partitions are not > > > statically defined into the DTS according the Linux MTD subsystem > > > maintainer. =20 > >=20 > > Do we really want to do this ? > > I thought passing the mtdparts via DT is the preferred way ? =20 >=20 > Yes, to me it seems like the most robust approach to minimize chances > of regressions and boot issues. >=20 > With the current dts schema, that expects the partitions to not be > direct children of the nand controller node, but expecting having a > nand-chip, and partitions as a child of the nand-chip this is the most > likely approach to just works. >=20 > For example if I add a partition node to my DTS, older U-Boot will just > ignore it and add the partitions as children of the nand controller. > In this case the current parser will just fails leading to another > flavor of boot failure on our board. >=20 > In reality I cannot really tell which u-boot/kernel combination is going > to be used on our SOMs. >=20 > Said that, what would be the disadvantages of having the partitions on > the command line? Miquel? It only works with the simplest parser, but that's anyway the one implied when tweaking the DT from U-Boot to add the partitions. If that works, then it looks the simplest approach indeed. Thanks, Miqu=C3=A8l