From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BAFDC05027 for ; Mon, 23 Jan 2023 10:28:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB3E3856E9; Mon, 23 Jan 2023 11:28:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="cGzHkIPQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6FE438571E; Mon, 23 Jan 2023 11:28:14 +0100 (CET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 63081856BC for ; Mon, 23 Jan 2023 11:28:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 7610BC000E; Mon, 23 Jan 2023 10:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674469691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+2SYEdhJpTh34wfL2UZHxOj46QVjvkgYp58I1hg+RFk=; b=cGzHkIPQW0c3KQzcFMf1UtrMmId+gdcj+KXvfzVYSKmK+bdFgnt3TfMZOtmSWmd4ycizYi CkpaAyUrlybmySjtlOQVG/rcQ0sNALm46clF9j6DUtKzTUJ5100JwHP4oGO7Mryhq6WjGs TA/rsd9SPXwl4jKUlnQh7tDiL8ozbNJS+X+Gh/xXFvImOFTmu+92wACvEi1GOZ0pR2ljN5 S9qqg5aE5jsTV8pkzexOKuS1lX2lgCD+ie//oErDJv/Aq70qJqdTOwfb4kIVw1HenWukhV K53415sC9KJDqMtDsUFNpfW5eXp/k2PpaFAFkZKpm8KReKN054kPvM3Gmt2i7w== Date: Mon, 23 Jan 2023 11:28:08 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, Marek Vasut , Francesco Dolcini , u-boot@lists.denx.de, Greg Kroah-Hartman Subject: Re: [PATCH v2] mtd: parsers: ofpart: add workaround for #size-cells 0 Message-ID: <20230123112808.6340a016@xps-13> In-Reply-To: <20230113184556.487405-1-francesco@dolcini.it> References: <20230113184556.487405-1-francesco@dolcini.it> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Francesco, francesco@dolcini.it wrote on Fri, 13 Jan 2023 19:45:56 +0100: > From: Francesco Dolcini >=20 > Add a mechanism to handle the case in which partitions are present as > direct child of the nand controller node and #size-cells is set to <0>. >=20 > This could happen if the nand-controller node in the DTS is supposed to > have #size-cells set to 0, but for some historical reason/bug it was set > to 1 in the past, and the firmware (e.g. U-Boot) is adding the partition > as direct children of the nand-controller defaulting to #size-cells > being to 1. >=20 > This prevents a real boot failure on colibri-imx7 that happened during v6= .1 > development cycles. >=20 > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb.int.torad= ex.com/ > Link: https://lore.kernel.org/all/20221202071900.1143950-1-francesco@dolc= ini.it/ > Signed-off-by: Francesco Dolcini > Reviewed-by: Greg Kroah-Hartman > --- >=20 > Miquel, Marek: I do not expect this patch to be backported to stable, how= ever > I would expect that we do not backport nand-controller dts cleanups neith= er. Okay. >=20 > v2: > fixup size-cells only when partitions are direct children of the nand-co= ntroller > completely revised commit message, comments and warning print > use pr_warn instead of pr_warn_once > added Reviewed-by Greg > removed cc:stable@ and fixes tag, since the problematic commit was rever= ted > --- > drivers/mtd/parsers/ofpart_core.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd/parsers/ofpa= rt_core.c > index 192190c42fc8..46559a9248e6 100644 > --- a/drivers/mtd/parsers/ofpart_core.c > +++ b/drivers/mtd/parsers/ofpart_core.c > @@ -122,6 +122,26 @@ static int parse_fixed_partitions(struct mtd_info *m= aster, > =20 > a_cells =3D of_n_addr_cells(pp); > s_cells =3D of_n_size_cells(pp); > + if (!dedicated && s_cells =3D=3D 0) { > + /* > + * This is a hugly workaround to not create > + * regression on devices that are still creating > + * partitions as direct child of the nand controller. > + * This can happen in case the nand controller node has > + * #size-cells equal to 0 and the firmware (e.g. > + * U-Boot) just add the partitions there assuming > + * 32-bit addressing. > + * > + * If you get this warning your firmware and/or DTS > + * should be really fixed. > + * > + * This is working only for devices smaller than 4GiB. > + */ > + pr_warn("%s: ofpart partition %pOF (%pOF) #size-cells is wrongly set = to <0>, assuming <1> for parsing partitions.\n", > + master->name, pp, > + mtd_node); Why mtd_node on a new line? Otherwise looks good to me. > + s_cells =3D 1; > + } > if (len / 4 !=3D a_cells + s_cells) { > pr_debug("%s: ofpart partition %pOF (%pOF) error parsing reg property= .\n", > master->name, pp, Thanks, Miqu=C3=A8l