From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A09C25B50 for ; Mon, 23 Jan 2023 19:20:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56F1A85282; Mon, 23 Jan 2023 20:20:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="X4/ws7bU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 94EDA84931; Mon, 23 Jan 2023 20:20:09 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C7D5E85021 for ; Mon, 23 Jan 2023 20:20:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id x5so10666652qti.3 for ; Mon, 23 Jan 2023 11:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+g9HNrgIJSmMqwEyvOM2jXNYlTdSyg2c6hHKVcIgYIw=; b=X4/ws7bUUBU2621i98+rilMXOVjDHiE7HyZP7UaEIVzQMYbfPmRu6fS+1fbAFcVydd 6xKFkSFGLEbgG9ZTQ+0GBYapXMvuhQwJQh5eNwtiqhL6NW1XR3sAGeqaZt4mxw5ZJ0FK 9IUDatM8ZYIg2JHo7MzPKSpOX+HUNqlGbLdmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+g9HNrgIJSmMqwEyvOM2jXNYlTdSyg2c6hHKVcIgYIw=; b=2tc043aPjDbk6QywouxhUctho0HR1ir+yaQ6Lhd+rQmjmcEssHjWZJId3CKAMTCMjz aWNcedj+RlWX+ib16MhCExBgC4HRklxfh7XELeMiL6bMqqWQoKrpNNf2SvY8jAPgKFeA OEDvxywhnYQhNaslHC+p9p3cb08cFMxqjoe+CzpoCkZBl3hX/ea2525IbeZD0pX0cT6I 7PqUYmbOTEeJv9zRAawI9j39IsKp5whU/o/1FUUKr7XyOHTQbrLyXYBBZQ8gYgEyC7Z+ BaXma8eOlz4RN8h/BoyvHq0senIbbKLHlmrih2b3+ekZkU1/YZEoyd7diCXp13LGmPcf MliA== X-Gm-Message-State: AFqh2kpwhMOqn/6hpzXOSwe8NNJyvXket56CWnxxvl7nLbcBx9/IlQH5 EDJjErVhwbFErBvNs/+i9cLX2w== X-Google-Smtp-Source: AMrXdXu8r4XEFrzWdPzUmz/mxQ0MW7HBpV5S3wpBTstMZ99HQs86ECuHb86HMjRFkePv5s99JlgsnQ== X-Received: by 2002:ac8:702:0:b0:3a9:6cf8:9b4e with SMTP id g2-20020ac80702000000b003a96cf89b4emr36556184qth.35.1674501605514; Mon, 23 Jan 2023 11:20:05 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-6451-01cf-0286-1d77.res6.spectrum.com. [2603:6081:7b00:6400:6451:1cf:286:1d77]) by smtp.gmail.com with ESMTPSA id e26-20020ac8491a000000b003b62fcd6d50sm9842710qtq.28.2023.01.23.11.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 11:20:04 -0800 (PST) Date: Mon, 23 Jan 2023 14:20:02 -0500 From: Tom Rini To: Nikhil M Jain Cc: u-boot@lists.denx.de, vigneshr@ti.com, nm@ti.com Subject: Re: [PATCH] include: configs: am62x_evm: Add .env file for Am62x Message-ID: <20230123192002.GA631605@bill-the-cat> References: <20230123063018.6061-1-n-jain1@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Og4V1LL7XI16KR+9" Content-Disposition: inline In-Reply-To: <20230123063018.6061-1-n-jain1@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Og4V1LL7XI16KR+9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 23, 2023 at 12:00:18PM +0530, Nikhil M Jain wrote: > Use .env file for setting board related environment variables, > in place of am62x_evm.h file. Except for BOOTENV settings, as > config_distro_boot.env file doesn't exist. >=20 > Signed-off-by: Nikhil M Jain > --- > board/ti/am62x/am62x.env | 105 ++++++++++++++++++++++++++++++++++++ > include/configs/am62x_evm.h | 43 --------------- > 2 files changed, 105 insertions(+), 43 deletions(-) > create mode 100644 board/ti/am62x/am62x.env >=20 > diff --git a/board/ti/am62x/am62x.env b/board/ti/am62x/am62x.env > new file mode 100644 > index 0000000000..3d4ab84fa3 > --- /dev/null > +++ b/board/ti/am62x/am62x.env > @@ -0,0 +1,105 @@ > +#define CFG_SYS_SDRAM_BASE1 0x880000000 This isn't used, please remove. Otherwise looks good, thanks! --=20 Tom --Og4V1LL7XI16KR+9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmPO3dsACgkQFHw5/5Y0 tyyblAv/UMOFHYQvXvDtQ5SrLY6mgyGdRtxm0JTQytvA9q93bUi5rqnQBgrQ/LdK MnsdD+/n9hj2kR34u8DNEVoPyTcet9cydP9vAmYAONsxXFf7VsloGUUkwQTaUj8v w2wHv79+5+YkSKEzUPA5oNUWw0ECGOiZpGE2BHkmgjt4dr4MtQY1LuyTraWS4JOy o3nqL7J9lEs5u2krdgKymJwUaHeLxR/26fdgMZajjfkJ3nqIncGZi6ZN2fC9S80N 3XLon1ANln79ReAMjYJ4QjBA38Tnywe6szUW/idNw+zaWAGhXsJAsesV9uMO50C7 9ZgL6oaZ+QpyLaYWLjEO64WAhkumsnvozHJcxsIg7geabsNtJRmsZgjkCUvskN8Q i7H639olW3RZ5dO95aVK6YnLgrKULgl/s4AGL1HI+Lv8mLT/GxAk4aTyasvmgMF0 u5gV1GAZH/yWdkJndu0ZPQ1arKwpDcyEABX6k82LDNtzH7MlI8ke12f9NvlsMr+J 4Net3UnA =PVEw -----END PGP SIGNATURE----- --Og4V1LL7XI16KR+9--