Re: [PATCH u-boot 3/3] tools: imagetool: Skip autodetection of gpimage type

Tom Rini
2023-02-03T20:23:31Z

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

On Fri, Feb 03, 2023 at 08:24:20PM +0100, Pali Rohár wrote:
> On Monday 30 January 2023 13:02:42 Tom Rini wrote:
> > On Mon, Jan 30, 2023 at 08:50:15AM -0700, Simon Glass wrote:
> > > On Sun, 29 Jan 2023 at 09:46, Pali Rohár <pali@kernel.org> wrote:
> > > >
> > > > gpimage type requires only that two first 32-bit words of data file are
> > > > non-zero. So basically every random data file can be guessed and verified
> > > > as gpimage. So completely skip gpimage type from image autodetection code
> > > > to prevent lot of false positive results. Data file with gpimage type can
> > > > be still verified and parsed by explicitly specifying -T gpimage.
> > > >
> > > > Signed-off-by: Pali Rohár <pali@kernel.org>
> > > > ---
> > > > tools/imagetool.c | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > >
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > I see we've had problems with gpimage before too. This seems reasonable
> > but I'm adding Nishanth here too, as the current interested person in
> > keystone2 platforms, to see if there's any other / better ways to
> > address this problem.
>
> I do not think that there is a better solution for gpimage. Basically it
> is not possible to write autodetection code for gpimage due to its
> generic nature. So the best what we can do is to disable gpimage in
> autodetection code.
>
> I would suggest to apply this patch, so people can test their build
> setups sooner than later.

Yes, I will pick this up before -rc2. I was wondering / hoping Nishanth
might have access to further internal information that might be helpful
here.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]