From: sbabic@denx.de
To: Mikhail Ilin <ilin.mikhail.ol@gmail.com>,u-boot@lists.denx.de
Subject: [PATCH] tools: imx8image: Fix handle leak
Date: Tue, 31 Jan 2023 10:50:37 +0100 (CET) [thread overview]
Message-ID: <20230131095050.12EB085A41@phobos.denx.de> (raw)
In-Reply-To: <20221123105949.26475-1-ilin.mikhail.ol@gmail.com>
> The handle "fd" was created in imx8image.c:249 by calling the "fopen"
> function and is lost in imx8image.c:282.
> Should close the 'fd' file descriptor before exiting the
> parse_cfg_file(image_t *param_stack, char *name) function.
> Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support")
> Signed-off-by: Mikhail Ilin <ilin.mikhail.ol@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
prev parent reply other threads:[~2023-01-31 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:59 [PATCH] tools: imx8image: Fix handle leak Mikhail Ilin
2022-11-25 4:01 ` Simon Glass
2023-01-31 9:50 ` sbabic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131095050.12EB085A41@phobos.denx.de \
--to=sbabic@denx.de \
--cc=ilin.mikhail.ol@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox