[PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

[PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

[Marek Vasut]

The default configuration of the PMIC behavior makes the PMIC
power cycle most regulators on WDOG_B assertion. This power
cycling causes the memory contents of OCRAM to be lost.
Some systems neeeds some memory that survives reset and
reboot, therefore this patch is created.

The implementation is taken almost verbatim from Linux commit
2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B assertion")

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Rickard x Andersson <rickaran@axis.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tim Harvey <tharvey@gateworks.com>
---
 drivers/power/pmic/pca9450.c | 11 ++++++++++-
 include/power/pca9450.h      |  4 ++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
index a186edc08da..2427abfb7a5 100644
--- a/drivers/power/pmic/pca9450.c
+++ b/drivers/power/pmic/pca9450.c
@@ -86,6 +86,7 @@ static int pca9450_bind(struct udevice *dev)
 static int pca9450_probe(struct udevice *dev)
 {
 	struct pca9450_priv *priv = dev_get_priv(dev);
+	unsigned int reset_ctrl;
 	int ret = 0;
 
 	if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
@@ -95,10 +96,18 @@ static int pca9450_probe(struct udevice *dev)
 		if (IS_ERR(priv->sd_vsel_gpio)) {
 			ret = PTR_ERR(priv->sd_vsel_gpio);
 			dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
+			if (ret)
+				return ret;
 		}
 	}
 
-	return ret;
+	if (ofnode_read_bool(dev_ofnode(dev), "nxp,wdog_b-warm-reset"))
+		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_WARM;
+	else
+		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_COLD_LDO12;
+
+	return pmic_clrsetbits(dev, PCA9450_RESET_CTRL,
+			       PCA9450_PMIC_RESET_WDOG_B_CFG_MASK, reset_ctrl);
 }
 
 static struct dm_pmic_ops pca9450_ops = {
diff --git a/include/power/pca9450.h b/include/power/pca9450.h
index fa0405fcb87..6efecee96c8 100644
--- a/include/power/pca9450.h
+++ b/include/power/pca9450.h
@@ -67,4 +67,8 @@ enum {
 #define PCA9450_LDO34_MASK		0x1f
 #define PCA9450_LDO5_MASK		0x0f
 
+#define PCA9450_PMIC_RESET_WDOG_B_CFG_MASK		0xc0
+#define PCA9450_PMIC_RESET_WDOG_B_CFG_WARM		0x40
+#define PCA9450_PMIC_RESET_WDOG_B_CFG_COLD_LDO12	0x80
+
 #endif
-- 
2.35.1

[PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

[Marek Vasut]

The PCA9450 reset configuration can now be performed by the PCA9450 PMIC
driver itself, remove the hard-coded variant from board code and let the
PMIC driver perform this task using one-liner:

```
$ sed -i '/set WDOG_B_CFG to cold reset/,+2 d' $(git grep -l PCA9450_RESET_CTRL.*0xA1 board/)
```

Venice and i.MX93 EVK required slight manual fix up.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
Cc: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tim Harvey <tharvey@gateworks.com>
---
 board/advantech/imx8mp_rsb3720a1/spl.c | 3 ---
 board/dhelectronics/dh_imx8mp/spl.c    | 3 ---
 board/engicam/imx8mp/spl.c             | 3 ---
 board/freescale/imx8mm_evk/spl.c       | 3 ---
 board/freescale/imx8mn_evk/spl.c       | 3 ---
 board/freescale/imx8mp_evk/spl.c       | 3 ---
 board/freescale/imx93_evk/spl.c        | 3 ---
 board/gateworks/venice/spl.c           | 3 ---
 board/kontron/sl-mx8mm/spl.c           | 3 ---
 board/toradex/verdin-imx8mm/spl.c      | 3 ---
 board/toradex/verdin-imx8mp/spl.c      | 3 ---
 11 files changed, 33 deletions(-)

diff --git a/board/advantech/imx8mp_rsb3720a1/spl.c b/board/advantech/imx8mp_rsb3720a1/spl.c
index 6cc8c23ecf8..f4257bc993d 100644
--- a/board/advantech/imx8mp_rsb3720a1/spl.c
+++ b/board/advantech/imx8mp_rsb3720a1/spl.c
@@ -209,9 +209,6 @@ int power_init_board(void)
 	/* To avoid timing risk from SOC to ARM,increase VDD_ARM to OD voltage 0.95v */
 	pmic_reg_write(pdev, PCA9450_BUCK2OUT_DVS0, 0x1C);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(pdev, PCA9450_RESET_CTRL, 0xA1);
-
 	/* Forced enable the I2C level translator*/
 	pmic_reg_write(pdev, PCA9450_CONFIG2, 0x03);
 
diff --git a/board/dhelectronics/dh_imx8mp/spl.c b/board/dhelectronics/dh_imx8mp/spl.c
index 60450bfe369..e2aa874723a 100644
--- a/board/dhelectronics/dh_imx8mp/spl.c
+++ b/board/dhelectronics/dh_imx8mp/spl.c
@@ -88,9 +88,6 @@ static int dh_imx8mp_board_power_init(void)
 	/* To avoid timing risk from SoC to ARM, increase VDD_ARM to OD voltage 0.95V */
 	pmic_reg_write(dev, PCA9450_BUCK2OUT_DVS0, 0x1c);
 
-	/* Set WDOG_B_CFG to cold reset. */
-	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
-
 	/* Set LDO4 and CONFIG2 to enable the I2C level translator. */
 	pmic_reg_write(dev, PCA9450_LDO4CTRL, 0x59);
 	pmic_reg_write(dev, PCA9450_CONFIG2, 0x1);
diff --git a/board/engicam/imx8mp/spl.c b/board/engicam/imx8mp/spl.c
index 6a16d58ae5a..36b83aace39 100644
--- a/board/engicam/imx8mp/spl.c
+++ b/board/engicam/imx8mp/spl.c
@@ -95,9 +95,6 @@ int power_init_board(void)
 	pmic_reg_write(p, PCA9450_BUCK6OUT, 0x18);
 #endif
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
-
 	return 0;
 }
 #endif
diff --git a/board/freescale/imx8mm_evk/spl.c b/board/freescale/imx8mm_evk/spl.c
index b5a2faf3a18..6e9513805cd 100644
--- a/board/freescale/imx8mm_evk/spl.c
+++ b/board/freescale/imx8mm_evk/spl.c
@@ -99,9 +99,6 @@ static int power_init_board(void)
 	/* set VDD_SNVS_0V8 from default 0.85V */
 	pmic_reg_write(dev, PCA9450_LDO2CTRL, 0xC0);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
-
 	return 0;
 }
 
diff --git a/board/freescale/imx8mn_evk/spl.c b/board/freescale/imx8mn_evk/spl.c
index 380abecd746..ec0378b5b76 100644
--- a/board/freescale/imx8mn_evk/spl.c
+++ b/board/freescale/imx8mn_evk/spl.c
@@ -95,9 +95,6 @@ int power_init_board(void)
 	/* enable LDO4 to 1.2v */
 	pmic_reg_write(dev, PCA9450_LDO4CTRL, 0x44);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
-
 	return 0;
 }
 #endif
diff --git a/board/freescale/imx8mp_evk/spl.c b/board/freescale/imx8mp_evk/spl.c
index f1b285417d0..246826a0d48 100644
--- a/board/freescale/imx8mp_evk/spl.c
+++ b/board/freescale/imx8mp_evk/spl.c
@@ -102,9 +102,6 @@ int power_init_board(void)
 	/* To avoid timing risk from SOC to ARM,increase VDD_ARM to OD voltage 0.95v */
 	pmic_reg_write(p, PCA9450_BUCK2OUT_DVS0, 0x1C);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
-
 	return 0;
 }
 #endif
diff --git a/board/freescale/imx93_evk/spl.c b/board/freescale/imx93_evk/spl.c
index 38cfbac6ea6..1aa2977b409 100644
--- a/board/freescale/imx93_evk/spl.c
+++ b/board/freescale/imx93_evk/spl.c
@@ -74,9 +74,6 @@ int power_init_board(void)
 
 	/* I2C_LT_EN*/
 	pmic_reg_write(dev, 0xa, 0x3);
-
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
 	return 0;
 }
 #endif
diff --git a/board/gateworks/venice/spl.c b/board/gateworks/venice/spl.c
index e06de8bb54c..60830766ca9 100644
--- a/board/gateworks/venice/spl.c
+++ b/board/gateworks/venice/spl.c
@@ -165,9 +165,6 @@ static int power_init_board(void)
 		/* Kernel uses OD/OD freq for SOC */
 		/* To avoid timing risk from SOC to ARM, increase VDD_ARM to OD voltage 0.95v */
 		dm_i2c_reg_write(dev, PCA9450_BUCK2OUT_DVS0, 0x1C);
-
-		/* set WDOG_B_CFG to cold reset */
-		dm_i2c_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
 	}
 
 	else if ((!strncmp(model, "GW7901", 6)) ||
diff --git a/board/kontron/sl-mx8mm/spl.c b/board/kontron/sl-mx8mm/spl.c
index 25ee925ceb0..3a919d0a9c3 100644
--- a/board/kontron/sl-mx8mm/spl.c
+++ b/board/kontron/sl-mx8mm/spl.c
@@ -193,9 +193,6 @@ static int power_init_board(void)
 	/* set VDD_SNVS_0V8 from default 0.85V to 0.8V */
 	pmic_reg_write(dev, PCA9450_LDO2CTRL, 0xC0);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
-
 	return 0;
 }
 
diff --git a/board/toradex/verdin-imx8mm/spl.c b/board/toradex/verdin-imx8mm/spl.c
index 210665bd6a9..9d54d60bb17 100644
--- a/board/toradex/verdin-imx8mm/spl.c
+++ b/board/toradex/verdin-imx8mm/spl.c
@@ -92,9 +92,6 @@ int power_init_board(void)
 		/* increase VDD_DRAM to 0.975v for 1.5Ghz DDR */
 		pmic_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x1c);
 
-		/* set WDOG_B_CFG to cold reset */
-		pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
-
 		pmic_reg_write(dev, PCA9450_CONFIG2, 0x1);
 
 		return 0;
diff --git a/board/toradex/verdin-imx8mp/spl.c b/board/toradex/verdin-imx8mp/spl.c
index 1838b464a0d..ea99e370850 100644
--- a/board/toradex/verdin-imx8mp/spl.c
+++ b/board/toradex/verdin-imx8mp/spl.c
@@ -116,9 +116,6 @@ int power_init_board(void)
 	/* To avoid timing risk from SoC to ARM, increase VDD_ARM to OD voltage 0.95v */
 	pmic_reg_write(p, PCA9450_BUCK2OUT_DVS0, 0x1c);
 
-	/* set WDOG_B_CFG to cold reset */
-	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
-
 	/* set LDO4 and CONFIG2 to enable the I2C level translator */
 	pmic_reg_write(p, PCA9450_LDO4CTRL, 0x59);
 	pmic_reg_write(p, PCA9450_CONFIG2, 0x1);
-- 
2.35.1

Re: [PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

[Fabio Estevam]

On 09/12/2022 16:35, Marek Vasut wrote:
> The PCA9450 reset configuration can now be performed by the PCA9450 
> PMIC
> driver itself, remove the hard-coded variant from board code and let 
> the
> PMIC driver perform this task using one-liner:
> 
> ```
> $ sed -i '/set WDOG_B_CFG to cold reset/,+2 d' $(git grep -l
> PCA9450_RESET_CTRL.*0xA1 board/)
> ```
> 
> Venice and i.MX93 EVK required slight manual fix up.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Fabio Estevam <festevam@denx.de>

Re: [PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

[Peng Fan]

On 12/10/2022 3:35 AM, Marek Vasut wrote:
> The PCA9450 reset configuration can now be performed by the PCA9450 PMIC
> driver itself, remove the hard-coded variant from board code and let the
> PMIC driver perform this task using one-liner:
> 
> ```
> $ sed -i '/set WDOG_B_CFG to cold reset/,+2 d' $(git grep -l PCA9450_RESET_CTRL.*0xA1 board/)
> ```
> 
> Venice and i.MX93 EVK required slight manual fix up.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
> Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
> Cc: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
>   board/advantech/imx8mp_rsb3720a1/spl.c | 3 ---
>   board/dhelectronics/dh_imx8mp/spl.c    | 3 ---
>   board/engicam/imx8mp/spl.c             | 3 ---
>   board/freescale/imx8mm_evk/spl.c       | 3 ---
>   board/freescale/imx8mn_evk/spl.c       | 3 ---
>   board/freescale/imx8mp_evk/spl.c       | 3 ---
>   board/freescale/imx93_evk/spl.c        | 3 ---
>   board/gateworks/venice/spl.c           | 3 ---
>   board/kontron/sl-mx8mm/spl.c           | 3 ---
>   board/toradex/verdin-imx8mm/spl.c      | 3 ---
>   board/toradex/verdin-imx8mp/spl.c      | 3 ---
>   11 files changed, 33 deletions(-)
> 
> diff --git a/board/advantech/imx8mp_rsb3720a1/spl.c b/board/advantech/imx8mp_rsb3720a1/spl.c
> index 6cc8c23ecf8..f4257bc993d 100644
> --- a/board/advantech/imx8mp_rsb3720a1/spl.c
> +++ b/board/advantech/imx8mp_rsb3720a1/spl.c
> @@ -209,9 +209,6 @@ int power_init_board(void)
>   	/* To avoid timing risk from SOC to ARM,increase VDD_ARM to OD voltage 0.95v */
>   	pmic_reg_write(pdev, PCA9450_BUCK2OUT_DVS0, 0x1C);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(pdev, PCA9450_RESET_CTRL, 0xA1);
> -
>   	/* Forced enable the I2C level translator*/
>   	pmic_reg_write(pdev, PCA9450_CONFIG2, 0x03);
>   
> diff --git a/board/dhelectronics/dh_imx8mp/spl.c b/board/dhelectronics/dh_imx8mp/spl.c
> index 60450bfe369..e2aa874723a 100644
> --- a/board/dhelectronics/dh_imx8mp/spl.c
> +++ b/board/dhelectronics/dh_imx8mp/spl.c
> @@ -88,9 +88,6 @@ static int dh_imx8mp_board_power_init(void)
>   	/* To avoid timing risk from SoC to ARM, increase VDD_ARM to OD voltage 0.95V */
>   	pmic_reg_write(dev, PCA9450_BUCK2OUT_DVS0, 0x1c);
>   
> -	/* Set WDOG_B_CFG to cold reset. */
> -	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
> -
>   	/* Set LDO4 and CONFIG2 to enable the I2C level translator. */
>   	pmic_reg_write(dev, PCA9450_LDO4CTRL, 0x59);
>   	pmic_reg_write(dev, PCA9450_CONFIG2, 0x1);
> diff --git a/board/engicam/imx8mp/spl.c b/board/engicam/imx8mp/spl.c
> index 6a16d58ae5a..36b83aace39 100644
> --- a/board/engicam/imx8mp/spl.c
> +++ b/board/engicam/imx8mp/spl.c
> @@ -95,9 +95,6 @@ int power_init_board(void)
>   	pmic_reg_write(p, PCA9450_BUCK6OUT, 0x18);
>   #endif
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
> -
>   	return 0;
>   }
>   #endif
> diff --git a/board/freescale/imx8mm_evk/spl.c b/board/freescale/imx8mm_evk/spl.c
> index b5a2faf3a18..6e9513805cd 100644
> --- a/board/freescale/imx8mm_evk/spl.c
> +++ b/board/freescale/imx8mm_evk/spl.c
> @@ -99,9 +99,6 @@ static int power_init_board(void)
>   	/* set VDD_SNVS_0V8 from default 0.85V */
>   	pmic_reg_write(dev, PCA9450_LDO2CTRL, 0xC0);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
> -
>   	return 0;
>   }
>   
> diff --git a/board/freescale/imx8mn_evk/spl.c b/board/freescale/imx8mn_evk/spl.c
> index 380abecd746..ec0378b5b76 100644
> --- a/board/freescale/imx8mn_evk/spl.c
> +++ b/board/freescale/imx8mn_evk/spl.c
> @@ -95,9 +95,6 @@ int power_init_board(void)
>   	/* enable LDO4 to 1.2v */
>   	pmic_reg_write(dev, PCA9450_LDO4CTRL, 0x44);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
> -
>   	return 0;
>   }
>   #endif
> diff --git a/board/freescale/imx8mp_evk/spl.c b/board/freescale/imx8mp_evk/spl.c
> index f1b285417d0..246826a0d48 100644
> --- a/board/freescale/imx8mp_evk/spl.c
> +++ b/board/freescale/imx8mp_evk/spl.c
> @@ -102,9 +102,6 @@ int power_init_board(void)
>   	/* To avoid timing risk from SOC to ARM,increase VDD_ARM to OD voltage 0.95v */
>   	pmic_reg_write(p, PCA9450_BUCK2OUT_DVS0, 0x1C);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
> -
>   	return 0;
>   }
>   #endif
> diff --git a/board/freescale/imx93_evk/spl.c b/board/freescale/imx93_evk/spl.c
> index 38cfbac6ea6..1aa2977b409 100644
> --- a/board/freescale/imx93_evk/spl.c
> +++ b/board/freescale/imx93_evk/spl.c
> @@ -74,9 +74,6 @@ int power_init_board(void)
>   
>   	/* I2C_LT_EN*/
>   	pmic_reg_write(dev, 0xa, 0x3);
> -
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
>   	return 0;
>   }
>   #endif
> diff --git a/board/gateworks/venice/spl.c b/board/gateworks/venice/spl.c
> index e06de8bb54c..60830766ca9 100644
> --- a/board/gateworks/venice/spl.c
> +++ b/board/gateworks/venice/spl.c
> @@ -165,9 +165,6 @@ static int power_init_board(void)
>   		/* Kernel uses OD/OD freq for SOC */
>   		/* To avoid timing risk from SOC to ARM, increase VDD_ARM to OD voltage 0.95v */
>   		dm_i2c_reg_write(dev, PCA9450_BUCK2OUT_DVS0, 0x1C);
> -
> -		/* set WDOG_B_CFG to cold reset */
> -		dm_i2c_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
>   	}
>   
>   	else if ((!strncmp(model, "GW7901", 6)) ||
> diff --git a/board/kontron/sl-mx8mm/spl.c b/board/kontron/sl-mx8mm/spl.c
> index 25ee925ceb0..3a919d0a9c3 100644
> --- a/board/kontron/sl-mx8mm/spl.c
> +++ b/board/kontron/sl-mx8mm/spl.c
> @@ -193,9 +193,6 @@ static int power_init_board(void)
>   	/* set VDD_SNVS_0V8 from default 0.85V to 0.8V */
>   	pmic_reg_write(dev, PCA9450_LDO2CTRL, 0xC0);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
> -
>   	return 0;
>   }
>   
> diff --git a/board/toradex/verdin-imx8mm/spl.c b/board/toradex/verdin-imx8mm/spl.c
> index 210665bd6a9..9d54d60bb17 100644
> --- a/board/toradex/verdin-imx8mm/spl.c
> +++ b/board/toradex/verdin-imx8mm/spl.c
> @@ -92,9 +92,6 @@ int power_init_board(void)
>   		/* increase VDD_DRAM to 0.975v for 1.5Ghz DDR */
>   		pmic_reg_write(dev, PCA9450_BUCK3OUT_DVS0, 0x1c);
>   
> -		/* set WDOG_B_CFG to cold reset */
> -		pmic_reg_write(dev, PCA9450_RESET_CTRL, 0xA1);
> -
>   		pmic_reg_write(dev, PCA9450_CONFIG2, 0x1);
>   
>   		return 0;
> diff --git a/board/toradex/verdin-imx8mp/spl.c b/board/toradex/verdin-imx8mp/spl.c
> index 1838b464a0d..ea99e370850 100644
> --- a/board/toradex/verdin-imx8mp/spl.c
> +++ b/board/toradex/verdin-imx8mp/spl.c
> @@ -116,9 +116,6 @@ int power_init_board(void)
>   	/* To avoid timing risk from SoC to ARM, increase VDD_ARM to OD voltage 0.95v */
>   	pmic_reg_write(p, PCA9450_BUCK2OUT_DVS0, 0x1c);
>   
> -	/* set WDOG_B_CFG to cold reset */
> -	pmic_reg_write(p, PCA9450_RESET_CTRL, 0xA1);
> -
>   	/* set LDO4 and CONFIG2 to enable the I2C level translator */
>   	pmic_reg_write(p, PCA9450_LDO4CTRL, 0x59);
>   	pmic_reg_write(p, PCA9450_CONFIG2, 0x1);
Reviewed-by: Peng Fan <peng.fan@nxp.com>

[PATCH 2/2] ARM: imx: Remove PMIC reset configuration from board files

[sbabic]

> The PCA9450 reset configuration can now be performed by the PCA9450 PMIC
> driver itself, remove the hard-coded variant from board code and let the
> PMIC driver perform this task using one-liner:
> ```
> $ sed -i '/set WDOG_B_CFG to cold reset/,+2 d' $(git grep -l PCA9450_RESET_CTRL.*0xA1 board/)
> ```
> Venice and i.MX93 EVK required slight manual fix up.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

[Fabio Estevam]

On 09/12/2022 16:35, Marek Vasut wrote:
> The default configuration of the PMIC behavior makes the PMIC
> power cycle most regulators on WDOG_B assertion. This power
> cycling causes the memory contents of OCRAM to be lost.
> Some systems neeeds some memory that survives reset and
> reboot, therefore this patch is created.
> 
> The implementation is taken almost verbatim from Linux commit
> 2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B 
> assertion")
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Reviewed-by: Fabio Estevam <festevam@denx.de>

Re: [PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

[Peng Fan]

On 12/10/2022 3:35 AM, Marek Vasut wrote:
> The default configuration of the PMIC behavior makes the PMIC
> power cycle most regulators on WDOG_B assertion. This power
> cycling causes the memory contents of OCRAM to be lost.
> Some systems neeeds some memory that survives reset and
> reboot, therefore this patch is created.
> 
> The implementation is taken almost verbatim from Linux commit
> 2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B assertion")
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
> Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Frieder Schrempf <frieder.schrempf@kontron.de>
> Cc: Manoj Sai <abbaraju.manojsai@amarulasolutions.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Rickard x Andersson <rickaran@axis.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> ---
>   drivers/power/pmic/pca9450.c | 11 ++++++++++-
>   include/power/pca9450.h      |  4 ++++
>   2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/power/pmic/pca9450.c b/drivers/power/pmic/pca9450.c
> index a186edc08da..2427abfb7a5 100644
> --- a/drivers/power/pmic/pca9450.c
> +++ b/drivers/power/pmic/pca9450.c
> @@ -86,6 +86,7 @@ static int pca9450_bind(struct udevice *dev)
>   static int pca9450_probe(struct udevice *dev)
>   {
>   	struct pca9450_priv *priv = dev_get_priv(dev);
> +	unsigned int reset_ctrl;
>   	int ret = 0;
>   
>   	if (CONFIG_IS_ENABLED(DM_GPIO) && CONFIG_IS_ENABLED(DM_REGULATOR_PCA9450)) {
> @@ -95,10 +96,18 @@ static int pca9450_probe(struct udevice *dev)
>   		if (IS_ERR(priv->sd_vsel_gpio)) {
>   			ret = PTR_ERR(priv->sd_vsel_gpio);
>   			dev_err(dev, "Failed to request SD_VSEL GPIO: %d\n", ret);
> +			if (ret)
> +				return ret;
>   		}
>   	}
>   
> -	return ret;
> +	if (ofnode_read_bool(dev_ofnode(dev), "nxp,wdog_b-warm-reset"))
> +		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_WARM;
> +	else
> +		reset_ctrl = PCA9450_PMIC_RESET_WDOG_B_CFG_COLD_LDO12;
> +
> +	return pmic_clrsetbits(dev, PCA9450_RESET_CTRL,
> +			       PCA9450_PMIC_RESET_WDOG_B_CFG_MASK, reset_ctrl);
>   }
>   
>   static struct dm_pmic_ops pca9450_ops = {
> diff --git a/include/power/pca9450.h b/include/power/pca9450.h
> index fa0405fcb87..6efecee96c8 100644
> --- a/include/power/pca9450.h
> +++ b/include/power/pca9450.h
> @@ -67,4 +67,8 @@ enum {
>   #define PCA9450_LDO34_MASK		0x1f
>   #define PCA9450_LDO5_MASK		0x0f
>   
> +#define PCA9450_PMIC_RESET_WDOG_B_CFG_MASK		0xc0
> +#define PCA9450_PMIC_RESET_WDOG_B_CFG_WARM		0x40
> +#define PCA9450_PMIC_RESET_WDOG_B_CFG_COLD_LDO12	0x80
> +
>   #endif

Reviewed-by: Peng Fan <peng.fan@nxp.com>

[PATCH 1/2] pmic: pca9450: Make warm reset on WDOG_B assertion

[sbabic]

> The default configuration of the PMIC behavior makes the PMIC
> power cycle most regulators on WDOG_B assertion. This power
> cycling causes the memory contents of OCRAM to be lost.
> Some systems neeeds some memory that survives reset and
> reboot, therefore this patch is created.
> The implementation is taken almost verbatim from Linux commit
> 2364a64d0673f ("regulator: pca9450: Make warm reset on WDOG_B assertion")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================