* [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access
@ 2022-11-14 12:01 Frieder Schrempf
2022-12-02 3:21 ` Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Frieder Schrempf @ 2022-11-14 12:01 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, Ashish Kumar, Frieder Schrempf,
Kuldeep Singh, u-boot, Ye Li
Cc: Andrew Davis
From: Frieder Schrempf <frieder.schrempf@kontron.de>
The introduction of CONFIG_FSL_QSPI_AHB_FULL_MAP as default in:
def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
broke the SPI NAND read access on the Kontron SL i.MX6UL/ULL boards.
Reading data from the flash returns garbage instead of the actual
content. Fix this for now by disabling the introduced option.
In the long run this should be fixed globally.
Fixes: def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
configs/kontron-sl-mx6ul_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/kontron-sl-mx6ul_defconfig b/configs/kontron-sl-mx6ul_defconfig
index aa789fc6e5e..db4b684690f 100644
--- a/configs/kontron-sl-mx6ul_defconfig
+++ b/configs/kontron-sl-mx6ul_defconfig
@@ -95,6 +95,7 @@ CONFIG_MXC_UART=y
CONFIG_SPI=y
CONFIG_DM_SPI=y
CONFIG_FSL_QSPI=y
+# CONFIG_FSL_QSPI_AHB_FULL_MAP is not set
CONFIG_MXC_SPI=y
CONFIG_IMX_THERMAL=y
CONFIG_USB=y
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access
2022-11-14 12:01 [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access Frieder Schrempf
@ 2022-12-02 3:21 ` Fabio Estevam
2023-01-31 10:08 ` Frieder Schrempf
2023-01-31 16:52 ` sbabic
2 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2022-12-02 3:21 UTC (permalink / raw)
To: Frieder Schrempf
Cc: Stefano Babic, Ashish Kumar, Frieder Schrempf, Kuldeep Singh,
u-boot, Ye Li, Andrew Davis
Hi Frieder,
On Mon, Nov 14, 2022 at 9:02 AM Frieder Schrempf <frieder@fris.de> wrote:
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The introduction of CONFIG_FSL_QSPI_AHB_FULL_MAP as default in:
>
> def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
>
> broke the SPI NAND read access on the Kontron SL i.MX6UL/ULL boards.
> Reading data from the flash returns garbage instead of the actual
> content. Fix this for now by disabling the introduced option.
>
> In the long run this should be fixed globally.
Yes, most likely more boards have the same problem.
Reviewed-by: Fabio Estevam <festevam@denx.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access
2022-11-14 12:01 [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access Frieder Schrempf
2022-12-02 3:21 ` Fabio Estevam
@ 2023-01-31 10:08 ` Frieder Schrempf
2023-01-31 10:16 ` Stefano Babic
2023-01-31 16:52 ` sbabic
2 siblings, 1 reply; 5+ messages in thread
From: Frieder Schrempf @ 2023-01-31 10:08 UTC (permalink / raw)
To: Stefano Babic
Cc: Andrew Davis, Frieder Schrempf, Ashish Kumar, Fabio Estevam,
Ye Li, u-boot
Hi Stefano,
On 14.11.22 13:01, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> The introduction of CONFIG_FSL_QSPI_AHB_FULL_MAP as default in:
>
> def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
>
> broke the SPI NAND read access on the Kontron SL i.MX6UL/ULL boards.
> Reading data from the flash returns garbage instead of the actual
> content. Fix this for now by disabling the introduced option.
>
> In the long run this should be fixed globally.
>
> Fixes: def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Can you pick up this patch, please?
Thanks
Frieder
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access
2023-01-31 10:08 ` Frieder Schrempf
@ 2023-01-31 10:16 ` Stefano Babic
0 siblings, 0 replies; 5+ messages in thread
From: Stefano Babic @ 2023-01-31 10:16 UTC (permalink / raw)
To: Frieder Schrempf, Stefano Babic
Cc: Andrew Davis, Frieder Schrempf, Ashish Kumar, Fabio Estevam,
Ye Li, u-boot
On 31.01.23 11:08, Frieder Schrempf wrote:
> Hi Stefano,
>
> On 14.11.22 13:01, Frieder Schrempf wrote:
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> The introduction of CONFIG_FSL_QSPI_AHB_FULL_MAP as default in:
>>
>> def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
>>
>> broke the SPI NAND read access on the Kontron SL i.MX6UL/ULL boards.
>> Reading data from the flash returns garbage instead of the actual
>> content. Fix this for now by disabling the introduced option.
>>
>> In the long run this should be fixed globally.
>>
>> Fixes: def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Can you pick up this patch, please?
Yes, it is already marked for the next CI run.
Regards,
Stefano
>
> Thanks
> Frieder
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access
2022-11-14 12:01 [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access Frieder Schrempf
2022-12-02 3:21 ` Fabio Estevam
2023-01-31 10:08 ` Frieder Schrempf
@ 2023-01-31 16:52 ` sbabic
2 siblings, 0 replies; 5+ messages in thread
From: sbabic @ 2023-01-31 16:52 UTC (permalink / raw)
To: Frieder Schrempf, u-boot
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> The introduction of CONFIG_FSL_QSPI_AHB_FULL_MAP as default in:
> def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
> broke the SPI NAND read access on the Kontron SL i.MX6UL/ULL boards.
> Reading data from the flash returns garbage instead of the actual
> content. Fix this for now by disabling the introduced option.
> In the long run this should be fixed globally.
> Fixes: def88bce094e ("spi: fsl_qspi: Support to use full AHB space on i.MX")
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-31 16:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-14 12:01 [PATCH] imx: imx6ul: kontron-sl-mx6ul: Disable CONFIG_FSL_QSPI_AHB_FULL_MAP to fix SPI NAND read access Frieder Schrempf
2022-12-02 3:21 ` Fabio Estevam
2023-01-31 10:08 ` Frieder Schrempf
2023-01-31 10:16 ` Stefano Babic
2023-01-31 16:52 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox