From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EE4CC636D3 for ; Wed, 1 Feb 2023 00:28:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 87AFE85BD2; Wed, 1 Feb 2023 01:28:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id B03EB85BD0; Wed, 1 Feb 2023 01:28:45 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 62AD085BAD for ; Wed, 1 Feb 2023 01:28:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A498B2F4; Tue, 31 Jan 2023 16:29:23 -0800 (PST) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 97A393F882; Tue, 31 Jan 2023 16:28:40 -0800 (PST) Date: Wed, 1 Feb 2023 00:26:17 +0000 From: Andre Przywara To: Joe Hershberger , Ramon Fried Cc: Samuel Holland , Jagan Teki , u-boot@lists.denx.de Subject: Re: [PATCH v2 0/5] net: sun8i-emac: Allwinner D1 Support Message-ID: <20230201002242.755906d9@slackpad.lan> In-Reply-To: <20230122225107.62464-1-samuel@sholland.org> References: <20230122225107.62464-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, 22 Jan 2023 16:51:01 -0600 Samuel Holland wrote: Hi Joe, Ramon, > D1 is a RISC-V SoC containing an EMAC compatible with the A64 EMAC. In a > very roundabout way, this series finishes adding support for the D1 EMAC: > patch 4 resolves a compiler warning when building the driver for RISC-V. > The rest of the series is just cleanup requested by Jagan. So I reviewed, but also tested this series on an H3, A64, H6 and R40 board, and Ethernet still worked on all of them. How do we handle the merge? Do you want to ACK the patches, and I take them through the sunxi tree? Or do you want to take the series? Patchwork put this on my plate, but get_maintainer.pl listed you two as the maintainers. Cheers, Andre > Changes in v2: > - Add a structure for driver data, and put the syscon offset there > > Samuel Holland (5): > net: sun8i-emac: Add a structure for variant data > net: sun8i-emac: Add a flag for RMII support > net: sun8i-emac: Add a flag for the internal PHY switch > net: sun8i-emac: Use common syscon setup for R40 > net: sun8i-emac: Remove the SoC variant ID > > drivers/net/sun8i_emac.c | 96 ++++++++++++++++++++++------------------ > 1 file changed, 53 insertions(+), 43 deletions(-) >