From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B29EFC61DA4 for ; Fri, 3 Feb 2023 12:37:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BDD5685F4C; Fri, 3 Feb 2023 13:37:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id D242B85F66; Fri, 3 Feb 2023 13:37:45 +0100 (CET) Received: from smtprelay07.ispgateway.de (smtprelay07.ispgateway.de [134.119.228.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0D36C85CFD for ; Fri, 3 Feb 2023 13:37:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=LW@KARO-electronics.de Received: from [89.1.81.74] (helo=ipc1.ka-ro) by smtprelay07.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pNvK2-0001at-5Y; Fri, 03 Feb 2023 13:37:42 +0100 Date: Fri, 3 Feb 2023 13:37:41 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Jan Kiszka Cc: U-Boot Mailing List Subject: Re: [PATCH V5 09/12] arm: dts: iot2050: Optionally embed OTP programming data into image Message-ID: <20230203133741.3a314673@ipc1.ka-ro> In-Reply-To: References: Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kb21haW5mYWN0b3J5LWt1bmRlLmRl X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi, On Fri, 3 Feb 2023 13:26:38 +0100 Jan Kiszka wrote: > From: Jan Kiszka >=20 > Use external blob otpcmd.bin to replace the 0xff filled OTP programming > command block to create a firmware image that provisions the OTP on > first boot. This otpcmd.bin is generated from the customer keys using > steps described in the meta-iot2050 integration layer for the device. >=20 > Based on original patch by Baocheng Su. >=20 > Signed-off-by: Jan Kiszka > --- > arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 8 ++++++++ > board/siemens/iot2050/Kconfig | 7 +++++++ > doc/board/siemens/iot2050.rst | 8 ++++++++ > tools/binman/missing-blob-help | 8 ++++++++ > 4 files changed, 31 insertions(+) >=20 > diff --git a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi b/arch/arm/dts/= k3-am65-iot2050-boot-image.dtsi > index 9082a79a034..25a22a7b7b8 100644 > --- a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi > +++ b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi > @@ -111,10 +111,18 @@ > }; > =20 > /* OTP update command block */ > +#if CONFIG_IOT2050_EMBED_OTPCMD > + blob-ext@0x6c0000 { > + offset =3D <0x6c0000>; > + size =3D <0x010000>; > + filename =3D "otpcmd.bin"; > + missing-msg =3D "iot2050-otpcmd"; > +#else > fill@0x6c0000 { > offset =3D <0x6c0000>; > size =3D <0x010000>; > fill-byte =3D [ff]; > +#endif > }; > I would rather include the closing brace in the #if #else block... Otherwise people who might copy part of the code will have a bad experience. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________