From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8AB4C61DA4 for ; Fri, 3 Feb 2023 18:16:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 918A485C78; Fri, 3 Feb 2023 19:16:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="TMIxHRP6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0196585C0F; Fri, 3 Feb 2023 19:16:32 +0100 (CET) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C32185C78 for ; Fri, 3 Feb 2023 19:16:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 21C1AC0006; Fri, 3 Feb 2023 18:16:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675448186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yBCQFLN6QvrkX1uLWmasfv0xC+uAw5r8x+2VJeEMlSQ=; b=TMIxHRP6EXIOQOZ0JgScy8cPLhqyrzvjfVSHKLZ38bfcgLvQAiomm+T4Q1tyKdoY6zd2yN HtbOTdTYbpEg4/Tjs7FEbQnlgJtU5zHG+tAPmsDZ62zVCYyJzU8gsuL1Xp4OnxHXYVYTP3 xgcUPAFzF3Up7IJ+1mi1zCAtZvUVhYyE/c6UERdLiu5m/OIXnpcVBW+PqGTFxKGhAvlmRh yjXgaFiyxjDRXZJxRBAcjPp9WZD/8RPVe/Zvj2YU/uEhKzTrzczd2wyy9UC26TptvMvSwM /rJ0NuYYZqam43/pftGz6V6qOUpLu7RDQ7fOCFCCLVj0VQc+4RZlvYscRzSZ/A== Date: Fri, 3 Feb 2023 19:16:23 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Marek Vasut , Francesco Dolcini , u-boot@lists.denx.de Subject: Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0 Message-ID: <20230203191623.5535e8e2@xps-13> In-Reply-To: <04A414CC-7CB6-45E0-B4EA-1489D51E9425@dolcini.it> References: <20230124104444.330913-1-francesco@dolcini.it> <20230126101204.245ace0d@xps-13> <20230203161202.76f3b057@xps-13> <04A414CC-7CB6-45E0-B4EA-1489D51E9425@dolcini.it> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Francesco, francesco@dolcini.it wrote on Fri, 03 Feb 2023 19:03:27 +0100: > Il 3 febbraio 2023 16:12:02 CET, Miquel Raynal ha scritto: > >Hi Francesco, > > > >francesco@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > > =20 > >> On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal wrote: =20 > >> > gregkh@linuxfoundation.org wrote on Thu, 26 Jan 2023 10:01:02 +0100: > >> > =20 > >> > > On Wed, Jan 25, 2023 at 10:06:57PM +0100, Francesco Dolcini wrote:= =20 > >> > > > Hello Miquel, Greg and all > >> > > >=20 > >> > > > On Tue, Jan 24, 2023 at 04:38:59PM +0100, Greg Kroah-Hartman wro= te: =20 > >> > > > > On Tue, Jan 24, 2023 at 11:44:44AM +0100, Francesco Dolcini wr= ote: =20 > >> > > > > > From: Francesco Dolcini > >> > > > > >=20 > >> > > > > > Add a mechanism to handle the case in which partitions are p= resent as > >> > > > > > direct child of the nand controller node and #size-cells is = set to <0>. > >> > > > > >=20 > >> > > > > > This could happen if the nand-controller node in the DTS is = supposed to > >> > > > > > have #size-cells set to 0, but for some historical reason/bu= g it was set > >> > > > > > to 1 in the past, and the firmware (e.g. U-Boot) is adding t= he partition > >> > > > > > as direct children of the nand-controller defaulting to #siz= e-cells > >> > > > > > being to 1. > >> > > > > >=20 > >> > > > > > This prevents a real boot failure on colibri-imx7 that happe= ned during v6.1 > >> > > > > > development cycles. > >> > > > > >=20 > >> > > > > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco= -nb.int.toradex.com/ > >> > > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-f= rancesco@dolcini.it/ > >> > > > > > Signed-off-by: Francesco Dolcini > >> > > > > > Reviewed-by: Greg Kroah-Hartman > >> > > > > > --- > >> > > > > > I do not expect this patch to be backported to stable, howev= er I would expect > >> > > > > > that we do not backport nand-controller dts cleanups neither. > >> > > > > >=20 > >> > > > > > v4: > >> > > > > > fixed wrong English spelling in the comment > >> > > > > >=20 > >> > > > > > v3: > >> > > > > > minor formatting change, removed not needed new-line and sp= ace.=20 > >> > > > > >=20 > >> > > > > > v2: > >> > > > > > fixup size-cells only when partitions are direct children o= f the nand-controller > >> > > > > > completely revised commit message, comments and warning pri= nt > >> > > > > > use pr_warn instead of pr_warn_once > >> > > > > > added Reviewed-by Greg > >> > > > > > removed cc:stable@ and fixes tag, since the problematic com= mit was reverted > >> > > > > > --- > >> > > > > > drivers/mtd/parsers/ofpart_core.c | 19 +++++++++++++++++++ > >> > > > > > 1 file changed, 19 insertions(+) > >> > > > > >=20 > >> > > > > > diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd= /parsers/ofpart_core.c > >> > > > > > index 192190c42fc8..e7b8e9d0a910 100644 > >> > > > > > --- a/drivers/mtd/parsers/ofpart_core.c > >> > > > > > +++ b/drivers/mtd/parsers/ofpart_core.c > >> > > > > > @@ -122,6 +122,25 @@ static int parse_fixed_partitions(struc= t mtd_info *master, > >> > > > > > =20 > >> > > > > > a_cells =3D of_n_addr_cells(pp); > >> > > > > > s_cells =3D of_n_size_cells(pp); > >> > > > > > + if (!dedicated && s_cells =3D=3D 0) { > >> > > > > > + /* > >> > > > > > + * This is a ugly workaround to not create > >> > > > > > + * regression on devices that are still creating > >> > > > > > + * partitions as direct children of the nand controller. > >> > > > > > + * This can happen in case the nand controller node has > >> > > > > > + * #size-cells equal to 0 and the firmware (e.g. > >> > > > > > + * U-Boot) just add the partitions there assuming > >> > > > > > + * 32-bit addressing. > >> > > > > > + * > >> > > > > > + * If you get this warning your firmware and/or DTS > >> > > > > > + * should be really fixed. > >> > > > > > + * > >> > > > > > + * This is working only for devices smaller than 4GiB. > >> > > > > > + */ > >> > > > > > + pr_warn("%s: ofpart partition %pOF (%pOF) #size-cells is= wrongly set to <0>, assuming <1> for parsing partitions.\n", > >> > > > > > + master->name, pp, mtd_node); =20 > >> > > > >=20 > >> > > > > This is a driver, always use dev_*() calls, not pr_*() calls s= o that we > >> > > > > know what is being referred to exactly. =20 > >> > > >=20 > >> > > > Is this reasonable here? Where can I get the struct device? = =20 > >> > >=20 > >> > > Walk back up the call chain, there has to be a device somewhere > >> > > controlling this, right? > >> > > =20 > >> > > > In general this file uses only pr_* debug API and messages are a= bout OF > >> > > > nodes/properties, not about a device. =20 > >> > >=20 > >> > > OF nodes and properties are part of a device's properties :) =20 > >> >=20 > >> > Yes but the warning comes from a wrong DT description, hence it felt > >> > better suited to warn against the node name which is easily identifi= able > >> > in a text file and must be fixed rather than the device which is a p= ure > >> > software component. > >> >=20 > >> > Anyway, Francesco, please show us the resultant line and if it feels > >> > meaningful enough we'll take the dev_warn approach. =20 > >>=20 > >> So, I tried, but I guess I failed. > >>=20 > >> Both > >>=20 > >> dev_warn(&mtd_get_master(master)->dev, ...); > >>=20 > >> and > >>=20 > >> dev_warn(&master->dev, ...); > >>=20 > >> are NULL. =20 > > > >mtd->dev (in raw NAND) is populated by the controller drivers, so the > >master mtd device is pointing to the bus "struct device" in its > >dev.parent field. This happens at the end of the probe of the > >controller, after setting the dev entry, so we expect the name of the > >controller to appear. > > =20 > >> (null): gpmi-nand: ofpart partition /soc/nand-controller@33002000/part= ition@0 (/soc/nand-controller@33002000) #size-cells is wrongly set to <0>, = assuming <1> for parsing partitions. =20 > > > >Second field looks right, first field does not (bus or class id?) I > >have no idea why it has not been populated at this point (end of the > >controller probe). But it's not a big deal, at least we have the device > >name, so it's ok for me. =20 >=20 > If I understand correctly you are fine with the current patch v4 that jus= t print (on colibri-imx7) Well, yes I was fine with it, but no that's not what I meant. AFAIS, using dev_warn() starts with "(null): gpmi-nand:" while pr_warn started with "gpmi-nand:", so for me the main and relevant information is present, that's all what I care about. Greg cared about the API used so I believe he would prefer us to use dev_warn(). It is unusual to apply a patch on which someone active in the community answered negatively as long as his concerns can be addressed, so I would like Greg to either state that he is fine with the pr_warn or you to send a v5 using dev_warn() and him to send his R-by back. If this happens early next week I'll take the patch for my next PR. > gpmi-nand: ofpart partition /soc/nand-controller@33002000/partition@0 (/s= oc/nand-controller@33002000) #size-cells is wrongly set to <0>, assuming <1= > for parsing partitions. >=20 > Correct? Do you want a v5 with the reviewed-by greg removed or you remove= it yourself? >=20 > Francesco >=20 Thanks, Miqu=C3=A8l