From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2F69C6379F for ; Thu, 9 Feb 2023 14:32:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C445B85F5F; Thu, 9 Feb 2023 15:32:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="M1IE8IQm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8175685F5A; Thu, 9 Feb 2023 15:32:23 +0100 (CET) Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D7B7D85EED for ; Thu, 9 Feb 2023 15:32:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jagan@amarulasolutions.com Received: by mail-pj1-x1032.google.com with SMTP id s89-20020a17090a2f6200b0023125ebb4b1so2503450pjd.3 for ; Thu, 09 Feb 2023 06:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2bEh6OLiZLSsblqZCcW3j0yP0wFtvY9DVsT5+AnVvSw=; b=M1IE8IQmXlHmvwt8gPc1ilc4QxjYkyxGpCcyHBgFK5zLZZgG1FvH7ZgpevN0rzzaKM 80yJ8UpW9eePzu3nSehd/DorKwAgl3JkvmmQSVU7DJu668Tfnvl4B8MOJE6joC2w7QnB 5w+kVAIqfjjpjc5lwOjFJAw/SBUh/c/ei8VkY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2bEh6OLiZLSsblqZCcW3j0yP0wFtvY9DVsT5+AnVvSw=; b=EKxUUQwh94OftsPHjiNemm1ZqOywbxh1lvcTMquK5rFHNeOVLdPD2tVKOB6NLwWvEb QBPoJ4nd/dWtqN79ffSGk5Z15fy5LaDwqK10E7QCf2epyzAvhMBqFhRfj1SWBdqz1HON hALeKGv2FChEuajH6XZfpAtseMZBh34/6PKXTne+jAiVFDO2wnv+O8oiBx5BVfF255da dpPdZsOD+9fnAWNajnMjZqNveKrQaOLQz/DdawRcNA6Xqm2v4gCxmzgGS06aNqvLlXn1 cvQFcsuLJcqjZW2ES2GMkgM3Jpz14TY8KwC/AxoorIrHO079QondpMqEM9tMmLzV7dEw xiFw== X-Gm-Message-State: AO0yUKXoNMVrgFl2+jfk2v3c/Zd8voP0s99XdGTwawJaq13HJQ/QAEme wzPwDOWnHMIzSqTdOt5Qy9gyTShDbK3pSu4oPok= X-Google-Smtp-Source: AK7set8CzKn2/7vWZ4ezBAJfaaX0Xp5x/nux+SD8pz6cVFNHrvVFkXULZxA7Q0HhNVIw7CaRZ53vjA== X-Received: by 2002:a05:6a20:840d:b0:bf:6cd3:954a with SMTP id c13-20020a056a20840d00b000bf6cd3954amr15962308pzd.42.1675953122247; Thu, 09 Feb 2023 06:32:02 -0800 (PST) Received: from localhost.localdomain ([183.83.141.79]) by smtp.gmail.com with ESMTPSA id j7-20020aa783c7000000b005938bd2bfd3sm1501226pfn.120.2023.02.09.06.31.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Feb 2023 06:32:01 -0800 (PST) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Jagan Teki , Manoj Sai Subject: [PATCH v3 5/7] phy: rockchip: inno-usb2: Add support #address_cells = 2 Date: Thu, 9 Feb 2023 20:00:58 +0530 Message-Id: <20230209143100.113376-5-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209143100.113376-1-jagan@amarulasolutions.com> References: <20230209143100.113376-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean New Rockchip devices have the usb phy nodes as standalone devices. These nodes have register nodes with #address_cells = 2, but only use 32 bit addresses. Adjust the driver to check if the returned address is "0", and adjust the index in that case. Derived and adjusted the similar change from linux-next with below commit <9c19c531dc98> ("phy: phy-rockchip-inno-usb2: support #address_cells = 2") Co-developed-by: Manoj Sai Signed-off-by: Manoj Sai Signed-off-by: Jagan Teki --- Changes for v3: - new patch drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index b32a498ea7..a01148db22 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -179,12 +179,21 @@ static int rockchip_usb2phy_probe(struct udevice *dev) if (IS_ERR(priv->reg_base)) return PTR_ERR(priv->reg_base); - ret = ofnode_read_u32(dev_ofnode(dev), "reg", ®); + ret = ofnode_read_u32_index(dev_ofnode(dev), "reg", 0, ®); if (ret) { dev_err(dev, "failed to read reg property (ret = %d)\n", ret); return ret; } + /* support address_cells=2 */ + if (reg == 0) { + if (ofnode_read_u32_index(dev_ofnode(dev), "reg", 1, ®)) { + dev_err(dev, "%s must have reg[1]\n", + ofnode_get_name(dev_ofnode(dev))); + return -EINVAL; + } + } + phy_cfgs = (const struct rockchip_usb2phy_cfg *) dev_get_driver_data(dev); if (!phy_cfgs) -- 2.25.1