From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF997C61DA4 for ; Thu, 9 Feb 2023 21:52:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6593C8545E; Thu, 9 Feb 2023 22:52:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675979528; bh=u7Xv4XnZbqQeYOOgg3Neyunb0iB8dH59dQf0qSxD//Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oLdT2NUkaWeXBAmNOlqdyizMu2WikE8NcKfRkBZ4Gvf0IG1Im7y5Pt7/06JjgaHpc dBo72ZP+vR5JI9g7hnuqvxgOO/1ukzopukKQ8uri1Xj+ZUplroUNsdFd3zLVq7+8jw Q4M2NK3vOj4YbDBIe6udpOBST3MVDeHrqBEyUG0/5qoH/yyjby2jH/E8b+GxAAUoNb Sigjn9Xcv/5oVRnBwIJzxKLLh39XYlwMZPYNBpHEV9xEW7k/pamy5vgKgjswLQhHDJ 5OdQYJqUgLkea9tEOGU0AzGrdzxE7e8cceCCGaQCmPdBLSgiojoqYlSOt+8tnklAx3 tY8j5d/2tuwgA== Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id DDDB785F50; Thu, 9 Feb 2023 22:51:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1675979484; bh=u7Xv4XnZbqQeYOOgg3Neyunb0iB8dH59dQf0qSxD//Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JamLl8Z1TwJeiW2J+5M4487CLE9NVT1Fz38JmmuRFs7PUE3CnsbNib7rZVWj1qoq3 eKM/bUjun1I354kHkASpBoEzi3sJzYmuntIKOPn1oJQ8eHWFKINy0t8Ts4+j6Mq8aI B0s69tPaP7vrxmG1DxE8gfEv6W+tybzeFNvdazeHgHZ+RueRoJMDlp60Fk1SvMKjSd LWM2X5b0AKHmHMAaj0N7eWFROsu17TJUcvZ2x7IN8oDl7LT964CghQ3xRKl8kz5l4a iHbivNZ4gfqSoNanJJ4zMZVB8gkQXVtNzx3a4TYSN+C/+tjwvup7t7BAQ3UC3ecQZp qqe4EzWbfIHYw== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Ramon Fried , "Ariel D'Alessandro" , "NXP i.MX U-Boot Team" , Andrey Zhizhikin , Fabio Estevam , Joe Hershberger , Lukasz Majewski , Marcel Ziswiler , Michael Trimarchi , Peng Fan , Sean Anderson , Stefano Babic , Tim Harvey , Tommaso Merciai Subject: [PATCH v2 03/10] net: dwc_eth_qos: Drop unused dm_gpio_free() on STM32 Date: Thu, 9 Feb 2023 22:50:41 +0100 Message-Id: <20230209215048.259223-3-marex@denx.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230209215048.259223-1-marex@denx.de> References: <20230209215048.259223-1-marex@denx.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The dm_gpio_free() is never called, because for stm32, the phy_reset_gpio pointer is never valid. This is because only tegra186 ever claims the phy_reset_gpio, all other platforms use the PHY framework to reset the PHY instead. Drop the dm_gpio_free() and dm_gpio_is_valid(). Reviewed-by: Ramon Fried Signed-off-by: Marek Vasut --- Cc: "Ariel D'Alessandro" Cc: "NXP i.MX U-Boot Team" Cc: Andrey Zhizhikin Cc: Fabio Estevam Cc: Joe Hershberger Cc: Lukasz Majewski Cc: Marcel Ziswiler Cc: Marek Vasut Cc: Michael Trimarchi Cc: Peng Fan Cc: Ramon Fried Cc: Sean Anderson Cc: Stefano Babic Cc: Tim Harvey Cc: Tommaso Merciai Cc: u-boot@lists.denx.de --- V2: - Add RB from Ramon - Mark eqos variable in eqos_remove_resources_stm32() with __maybe_unused --- drivers/net/dwc_eth_qos.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index 44d05908894..3b62b283c45 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -1490,7 +1490,7 @@ static int eqos_remove_resources_tegra186(struct udevice *dev) static int eqos_remove_resources_stm32(struct udevice *dev) { - struct eqos_priv *eqos = dev_get_priv(dev); + struct eqos_priv * __maybe_unused eqos = dev_get_priv(dev); debug("%s(dev=%p):\n", __func__, dev); @@ -1502,9 +1502,6 @@ static int eqos_remove_resources_stm32(struct udevice *dev) clk_free(&eqos->clk_ck); #endif - if (dm_gpio_is_valid(&eqos->phy_reset_gpio)) - dm_gpio_free(dev, &eqos->phy_reset_gpio); - debug("%s: OK\n", __func__); return 0; } -- 2.39.1