* [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
@ 2023-02-10 21:08 Tony Dinh
2023-02-13 8:43 ` Stefan Roese
2023-02-13 14:01 ` Stefan Roese
0 siblings, 2 replies; 6+ messages in thread
From: Tony Dinh @ 2023-02-10 21:08 UTC (permalink / raw)
To: Stefan Roese, U-Boot Mailing List
Cc: Michael Walle, Tom Rini, Pali Roh�r, Tony Dinh, Peng Fan
When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
required for this board to boot over UART with kwboot. Enable this in
kirkwood-pogoplug-series-4-u-boot.dtsi.
Signed-off-by: Tony Dinh <mibodhi@gmail.com>
---
arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
new file mode 100644
index 0000000000..f9e127234c
--- /dev/null
+++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
@@ -0,0 +1,7 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com>
+ */
+&uart0 {
+ u-boot,dm-pre-reloc;
+};
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
2023-02-10 21:08 [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board Tony Dinh
@ 2023-02-13 8:43 ` Stefan Roese
2023-02-13 8:48 ` Michael Walle
2023-02-13 14:01 ` Stefan Roese
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2023-02-13 8:43 UTC (permalink / raw)
To: Tony Dinh, U-Boot Mailing List
Cc: Michael Walle, Tom Rini, Pali Roh�r, Peng Fan
On 2/10/23 22:08, Tony Dinh wrote:
> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
> required for this board to boot over UART with kwboot. Enable this in
> kirkwood-pogoplug-series-4-u-boot.dtsi.
>
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
>
> arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
>
> diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
> new file mode 100644
> index 0000000000..f9e127234c
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com>
> + */
> +&uart0 {
> + u-boot,dm-pre-reloc;
> +};
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
2023-02-13 8:43 ` Stefan Roese
@ 2023-02-13 8:48 ` Michael Walle
2023-02-13 9:12 ` Stefan Roese
0 siblings, 1 reply; 6+ messages in thread
From: Michael Walle @ 2023-02-13 8:48 UTC (permalink / raw)
To: Stefan Roese
Cc: Tony Dinh, U-Boot Mailing List, Tom Rini, Pali Roh�r,
Peng Fan
Am 2023-02-13 09:43, schrieb Stefan Roese:
> On 2/10/23 22:08, Tony Dinh wrote:
>> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
>> required for this board to boot over UART with kwboot. Enable this in
>> kirkwood-pogoplug-series-4-u-boot.dtsi.
>>
>> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
>
> Reviewed-by: Stefan Roese <sr@denx.de>
If I understood it correctly, this is a workaround, right? Maybe we
can include a link to the original discussion here for the case when
someone stumbles over this commit:
Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
2023-02-13 8:48 ` Michael Walle
@ 2023-02-13 9:12 ` Stefan Roese
2023-02-13 17:56 ` Tony Dinh
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2023-02-13 9:12 UTC (permalink / raw)
To: Michael Walle
Cc: Tony Dinh, U-Boot Mailing List, Tom Rini, Pali Roh�r,
Peng Fan
Hi Michael,
On 2/13/23 09:48, Michael Walle wrote:
> Am 2023-02-13 09:43, schrieb Stefan Roese:
>> On 2/10/23 22:08, Tony Dinh wrote:
>>> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
>>> required for this board to boot over UART with kwboot. Enable this in
>>> kirkwood-pogoplug-series-4-u-boot.dtsi.
>>>
>>> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
>>
>> Reviewed-by: Stefan Roese <sr@denx.de>
>
> If I understood it correctly, this is a workaround, right? Maybe we
> can include a link to the original discussion here for the case when
> someone stumbles over this commit:
>
> Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/
Correct, it's not fully understood, why this property is really needed.
Some bug still might be hidden in the early DT console code. Still we
want to move forward with this board, so this dm-pre-reloc property
helps here.
I'll add the link to the discussion to the commit text. Good idea.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
2023-02-10 21:08 [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board Tony Dinh
2023-02-13 8:43 ` Stefan Roese
@ 2023-02-13 14:01 ` Stefan Roese
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2023-02-13 14:01 UTC (permalink / raw)
To: Tony Dinh, U-Boot Mailing List
Cc: Michael Walle, Tom Rini, Pali Roh�r, Peng Fan
On 2/10/23 22:08, Tony Dinh wrote:
> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
> required for this board to boot over UART with kwboot. Enable this in
> kirkwood-pogoplug-series-4-u-boot.dtsi.
>
> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
Applied to u-boot-marvell/master
Thanks,
Stefan
> ---
>
> arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
> create mode 100644 arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
>
> diff --git a/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
> new file mode 100644
> index 0000000000..f9e127234c
> --- /dev/null
> +++ b/arch/arm/dts/kirkwood-pogoplug-series-4-u-boot.dtsi
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright (C) 2023 Tony Dinh <mibodhi@gmail.com>
> + */
> +&uart0 {
> + u-boot,dm-pre-reloc;
> +};
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board
2023-02-13 9:12 ` Stefan Roese
@ 2023-02-13 17:56 ` Tony Dinh
0 siblings, 0 replies; 6+ messages in thread
From: Tony Dinh @ 2023-02-13 17:56 UTC (permalink / raw)
To: Stefan Roese
Cc: Michael Walle, U-Boot Mailing List, Tom Rini, Pali Roh�r,
Peng Fan
On Mon, Feb 13, 2023 at 1:12 AM Stefan Roese <sr@denx.de> wrote:
>
> Hi Michael,
>
> On 2/13/23 09:48, Michael Walle wrote:
> > Am 2023-02-13 09:43, schrieb Stefan Roese:
> >> On 2/10/23 22:08, Tony Dinh wrote:
> >>> When DM_SERIAL is enabled, the device-tree tag u-boot,dm-pre-reloc is
> >>> required for this board to boot over UART with kwboot. Enable this in
> >>> kirkwood-pogoplug-series-4-u-boot.dtsi.
> >>>
> >>> Signed-off-by: Tony Dinh <mibodhi@gmail.com>
> >>
> >> Reviewed-by: Stefan Roese <sr@denx.de>
> >
> > If I understood it correctly, this is a workaround, right? Maybe we
> > can include a link to the original discussion here for the case when
> > someone stumbles over this commit:
> >
> > Link: https://lore.kernel.org/r/20230201080210.ypz4nrj4y2igwxz3@pali/
>
> Correct, it's not fully understood, why this property is really needed.
> Some bug still might be hidden in the early DT console code. Still we
> want to move forward with this board, so this dm-pre-reloc property
> helps here.
>
> I'll add the link to the discussion to the commit text. Good idea.
Thanks Stefan!
All the best,
Tony
>
> Thanks,
> Stefan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-02-13 17:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-10 21:08 [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Pogoplug V4 board Tony Dinh
2023-02-13 8:43 ` Stefan Roese
2023-02-13 8:48 ` Michael Walle
2023-02-13 9:12 ` Stefan Roese
2023-02-13 17:56 ` Tony Dinh
2023-02-13 14:01 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox