Re: [PATCH V2 5/9] rockchip: rk3568: add boot device detection

Kever Yang
2023-02-22T07:46:10Z

On 2023/2/16 02:28, Jonas Karlman wrote:
> Hi Chris,
>
> On 2023-02-13 23:27, Chris Morgan wrote:
>> From: Chris Morgan <macromorgan@hotmail.com>
>>
>> Enable spl to detect which device it was booted from.
>>
>> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>> ---
>> arch/arm/mach-rockchip/rk3568/rk3568.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/mach-rockchip/rk3568/rk3568.c b/arch/arm/mach-rockchip/rk3568/rk3568.c
>> index 22eeb77d41..a2d59abc26 100644
>> --- a/arch/arm/mach-rockchip/rk3568/rk3568.c
>> +++ b/arch/arm/mach-rockchip/rk3568/rk3568.c
>> @@ -7,6 +7,7 @@
>> #include <dm.h>
>> #include <asm/armv8/mmu.h>
>> #include <asm/io.h>
>> +#include <asm/arch-rockchip/bootrom.h>
>> #include <asm/arch-rockchip/grf_rk3568.h>
>> #include <asm/arch-rockchip/hardware.h>
>> #include <dt-bindings/clock/rk3568-cru.h>
>> @@ -70,6 +71,12 @@ static struct mm_region rk3568_mem_map[] = {
>> }
>> };
>>
>> +const char * const boot_devices[BROM_LAST_BOOTSOURCE + 1] = {
>> + [BROM_BOOTSOURCE_EMMC] = "/sdhci@fe310000",
> This should be mmc@@fe310000.

With this update.

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever

>
> Regards,
> Jonas
>
>> + [BROM_BOOTSOURCE_SPINOR] = "/spi@fe300000/flash@0",
>> + [BROM_BOOTSOURCE_SD] = "/mmc@fe2b0000",
>> +};
>> +
>> struct mm_region *mem_map = rk3568_mem_map;
>>
>> void board_debug_uart_init(void)