From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F388C05027 for ; Mon, 20 Feb 2023 10:39:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 50D17857B1; Mon, 20 Feb 2023 11:39:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="Mxs0HAYr"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="dv+W95xg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 306ED8583D; Mon, 20 Feb 2023 11:39:27 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B5FB85769 for ; Mon, 20 Feb 2023 11:39:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=msuchanek@suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id F08FD1FE0A; Mon, 20 Feb 2023 10:39:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676889563; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AlZGe8DcO1pr+OY9opw4E3xtHj5dIIMh0heNV+jgZYA=; b=Mxs0HAYrTln45vtX5Paf1eiD1LVqsd3Z02JextcjvwpM2wL0qWUdKhR+GN/zLQjSkpAI1Y n2PvoGywwta628dG3rESeUiFcI2nOv9CO/jiclVKoptVJJ9nxbqXuPEwLQlgDfZTXqaHIE QVem43xeaXeTHlhDZZQ9ZuTJVWJ8Xxo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676889563; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AlZGe8DcO1pr+OY9opw4E3xtHj5dIIMh0heNV+jgZYA=; b=dv+W95xgOydwvxJRujQoXqOzRAa5rX5rbcY8DqiIqzHL+cpyixyo67GHMmY0Fd29+U2NNy eQjblkYo7d3k9EBw== Received: from kitsune.suse.cz (kitsune.suse.cz [10.100.12.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B7AEC2C141; Mon, 20 Feb 2023 10:39:23 +0000 (UTC) Date: Mon, 20 Feb 2023 11:39:22 +0100 From: Michal =?iso-8859-1?Q?Such=E1nek?= To: Samuel Holland Cc: Lukasz Majewski , Sean Anderson , Simon Glass , Dario Binacchi , Jean-Jacques Hiblot , Neil Armstrong , Peng Fan , u-boot@lists.denx.de Subject: Re: [PATCH 3/6] clk: Fix error handling in clk_get_parent() Message-ID: <20230220103922.GI19419@kitsune.suse.cz> References: <20230220055940.41890-1-samuel@sholland.org> <20230220055940.41890-4-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230220055940.41890-4-samuel@sholland.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Sun, Feb 19, 2023 at 11:59:36PM -0600, Samuel Holland wrote: > Do not return both NULL and error pointers. The function is only > documented as returning error pointers. > > Fixes: 8a1661f20e6c ("drivers: clk: Handle gracefully NULL pointers") > Signed-off-by: Samuel Holland > --- > > drivers/clk/clk-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/clk-uclass.c b/drivers/clk/clk-uclass.c > index 78299dbceb2..5bce976b060 100644 > --- a/drivers/clk/clk-uclass.c > +++ b/drivers/clk/clk-uclass.c > @@ -490,7 +490,7 @@ struct clk *clk_get_parent(struct clk *clk) > > debug("%s(clk=%p)\n", __func__, clk); > if (!clk_valid(clk)) > - return NULL; > + return ERR_PTR(-ENODEV); > > pdev = dev_get_parent(clk->dev); > if (!pdev) Do we really need this? Who cares about the distinction? Just returning NULL on any error makes the code so much simpler and easier to understand. Thanks Michal