* [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
@ 2023-02-20 15:03 Elmar Psilog
2023-03-19 10:43 ` Elmar Psilog
2023-05-06 14:54 ` Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Elmar Psilog @ 2023-02-20 15:03 UTC (permalink / raw)
To: u-boot; +Cc: marex, rfried.dev, Elmar Psilog
Without that patch it lost track to the node to scan
speed and duplex.
Patch was created by Marek Vasut, just tested by me.
Signed-off-by: Elmar Psilog <epsi at gmx.de>
Reviewed-by: Marek Vasut <marex at denx.de>
---
changes v2: fix format issues
changes v3: remove {} around single if, add reviewd..
drivers/net/dwc_eth_qos.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
index 112deb546d..b9de205b8a 100644
--- a/drivers/net/dwc_eth_qos.c
+++ b/drivers/net/dwc_eth_qos.c
@@ -788,9 +788,21 @@ static int eqos_start(struct udevice *dev)
*/
if (!eqos->phy) {
int addr = -1;
- addr = eqos_get_phy_addr(eqos, dev);
- eqos->phy = phy_connect(eqos->mii, addr, dev,
- eqos->config->interface(dev));
+ ofnode fixed_node;
+
+ if (IS_ENABLED(CONFIG_PHY_FIXED)) {
+ fixed_node = ofnode_find_subnode(dev_ofnode(dev),
+ "fixed-link");
+ if (ofnode_valid(fixed_node))
+ eqos->phy = fixed_phy_create(dev_ofnode(dev));
+ }
+
+ if (!eqos->phy) {
+ addr = eqos_get_phy_addr(eqos, dev);
+ eqos->phy = phy_connect(eqos->mii, addr, dev,
+ eqos->config->interface(dev));
+ }
+
if (!eqos->phy) {
pr_err("phy_connect() failed");
goto err_stop_resets;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
2023-02-20 15:03 [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too Elmar Psilog
@ 2023-03-19 10:43 ` Elmar Psilog
2023-03-19 17:21 ` Marek Vasut
2023-05-06 14:54 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Elmar Psilog @ 2023-03-19 10:43 UTC (permalink / raw)
To: u-boot; +Cc: marex, rfried.dev
> Without that patch it lost track to the node to scan
> speed and duplex.
> Patch was created by Marek Vasut, just tested by me.
>
> Signed-off-by: Elmar Psilog <epsi at gmx.de>
> Reviewed-by: Marek Vasut <marex at denx.de>
> ---
> changes v2: fix format issues
> changes v3: remove {} around single if, add reviewd..
>
> drivers/net/dwc_eth_qos.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
> index 112deb546d..b9de205b8a 100644
> --- a/drivers/net/dwc_eth_qos.c
> +++ b/drivers/net/dwc_eth_qos.c
> @@ -788,9 +788,21 @@ static int eqos_start(struct udevice *dev)
> */
> if (!eqos->phy) {
> int addr = -1;
> - addr = eqos_get_phy_addr(eqos, dev);
> - eqos->phy = phy_connect(eqos->mii, addr, dev,
> - eqos->config->interface(dev));
> + ofnode fixed_node;
> +
> + if (IS_ENABLED(CONFIG_PHY_FIXED)) {
> + fixed_node = ofnode_find_subnode(dev_ofnode(dev),
> + "fixed-link");
> + if (ofnode_valid(fixed_node))
> + eqos->phy = fixed_phy_create(dev_ofnode(dev));
> + }
> +
> + if (!eqos->phy) {
> + addr = eqos_get_phy_addr(eqos, dev);
> + eqos->phy = phy_connect(eqos->mii, addr, dev,
> + eqos->config->interface(dev));
> + }
> +
> if (!eqos->phy) {
> pr_err("phy_connect() failed");
> goto err_stop_resets;
> --
> 2.34.1
I would give a short reminder about the patch. Reviewed by Marek, ok for
Ramon. Would be glad to see it in 2023.04.
Thanks
Elmar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
2023-03-19 10:43 ` Elmar Psilog
@ 2023-03-19 17:21 ` Marek Vasut
2023-03-19 20:02 ` Elmar Psilog
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2023-03-19 17:21 UTC (permalink / raw)
To: Elmar Psilog, u-boot; +Cc: rfried.dev
On 3/19/23 11:43, Elmar Psilog wrote:
>> Without that patch it lost track to the node to scan
>> speed and duplex.
>> Patch was created by Marek Vasut, just tested by me.
>>
>> Signed-off-by: Elmar Psilog <epsi at gmx.de>
>> Reviewed-by: Marek Vasut <marex at denx.de>
>> ---
>> changes v2: fix format issues
>> changes v3: remove {} around single if, add reviewd..
>>
>> drivers/net/dwc_eth_qos.c | 18 +++++++++++++++---
>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
>> index 112deb546d..b9de205b8a 100644
>> --- a/drivers/net/dwc_eth_qos.c
>> +++ b/drivers/net/dwc_eth_qos.c
>> @@ -788,9 +788,21 @@ static int eqos_start(struct udevice *dev)
>> */
>> if (!eqos->phy) {
>> int addr = -1;
>> - addr = eqos_get_phy_addr(eqos, dev);
>> - eqos->phy = phy_connect(eqos->mii, addr, dev,
>> - eqos->config->interface(dev));
>> + ofnode fixed_node;
>> +
>> + if (IS_ENABLED(CONFIG_PHY_FIXED)) {
>> + fixed_node = ofnode_find_subnode(dev_ofnode(dev),
>> + "fixed-link");
>> + if (ofnode_valid(fixed_node))
>> + eqos->phy = fixed_phy_create(dev_ofnode(dev));
>> + }
>> +
>> + if (!eqos->phy) {
>> + addr = eqos_get_phy_addr(eqos, dev);
>> + eqos->phy = phy_connect(eqos->mii, addr, dev,
>> + eqos->config->interface(dev));
>> + }
>> +
>> if (!eqos->phy) {
>> pr_err("phy_connect() failed");
>> goto err_stop_resets;
>> --
>> 2.34.1
>
>
> I would give a short reminder about the patch. Reviewed by Marek, ok for
> Ramon. Would be glad to see it in 2023.04.
We're already in 2023.04-rc4 , this is material for v2023.07 , i.e. for
u-boot/next branch .
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
2023-03-19 17:21 ` Marek Vasut
@ 2023-03-19 20:02 ` Elmar Psilog
2023-03-19 22:58 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Elmar Psilog @ 2023-03-19 20:02 UTC (permalink / raw)
To: Marek Vasut, u-boot; +Cc: rfried.dev
Am 19.03.23 um 18:21 schrieb Marek Vasut:
> On 3/19/23 11:43, Elmar Psilog wrote:
>>> Without that patch it lost track to the node to scan
>>> speed and duplex.
>>> Patch was created by Marek Vasut, just tested by me.
>>>
>>> Signed-off-by: Elmar Psilog <epsi at gmx.de>
>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>> ---
>>> changes v2: fix format issues
>>> changes v3: remove {} around single if, add reviewd..
>>>
>>> drivers/net/dwc_eth_qos.c | 18 +++++++++++++++---
>>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
>>> index 112deb546d..b9de205b8a 100644
>>> --- a/drivers/net/dwc_eth_qos.c
>>> +++ b/drivers/net/dwc_eth_qos.c
>>> @@ -788,9 +788,21 @@ static int eqos_start(struct udevice *dev)
>>> */
>>> if (!eqos->phy) {
>>> int addr = -1;
>>> - addr = eqos_get_phy_addr(eqos, dev);
>>> - eqos->phy = phy_connect(eqos->mii, addr, dev,
>>> - eqos->config->interface(dev));
>>> + ofnode fixed_node;
>>> +
>>> + if (IS_ENABLED(CONFIG_PHY_FIXED)) {
>>> + fixed_node = ofnode_find_subnode(dev_ofnode(dev),
>>> + "fixed-link");
>>> + if (ofnode_valid(fixed_node))
>>> + eqos->phy = fixed_phy_create(dev_ofnode(dev));
>>> + }
>>> +
>>> + if (!eqos->phy) {
>>> + addr = eqos_get_phy_addr(eqos, dev);
>>> + eqos->phy = phy_connect(eqos->mii, addr, dev,
>>> + eqos->config->interface(dev));
>>> + }
>>> +
>>> if (!eqos->phy) {
>>> pr_err("phy_connect() failed");
>>> goto err_stop_resets;
>>> --
>>> 2.34.1
>>
>>
>> I would give a short reminder about the patch. Reviewed by Marek, ok for
>> Ramon. Would be glad to see it in 2023.04.
>
> We're already in 2023.04-rc4 , this is material for v2023.07 , i.e.
> for u-boot/next branch .
Ok, but does it change anything for the patch itself? As source isn't
touched in last weeks it is still needed. Other way asked: Any action
(from my side) needed? I just afraid your (@Marek) and my work gets
lost. I would expect either an "accepted" or "rejected" (for a reason).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
2023-03-19 20:02 ` Elmar Psilog
@ 2023-03-19 22:58 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2023-03-19 22:58 UTC (permalink / raw)
To: Elmar Psilog, u-boot; +Cc: rfried.dev
On 3/19/23 21:02, Elmar Psilog wrote:
>
> Am 19.03.23 um 18:21 schrieb Marek Vasut:
>> On 3/19/23 11:43, Elmar Psilog wrote:
>>>> Without that patch it lost track to the node to scan
>>>> speed and duplex.
>>>> Patch was created by Marek Vasut, just tested by me.
>>>>
>>>> Signed-off-by: Elmar Psilog <epsi at gmx.de>
>>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>>> ---
>>>> changes v2: fix format issues
>>>> changes v3: remove {} around single if, add reviewd..
>>>>
>>>> drivers/net/dwc_eth_qos.c | 18 +++++++++++++++---
>>>> 1 file changed, 15 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c
>>>> index 112deb546d..b9de205b8a 100644
>>>> --- a/drivers/net/dwc_eth_qos.c
>>>> +++ b/drivers/net/dwc_eth_qos.c
>>>> @@ -788,9 +788,21 @@ static int eqos_start(struct udevice *dev)
>>>> */
>>>> if (!eqos->phy) {
>>>> int addr = -1;
>>>> - addr = eqos_get_phy_addr(eqos, dev);
>>>> - eqos->phy = phy_connect(eqos->mii, addr, dev,
>>>> - eqos->config->interface(dev));
>>>> + ofnode fixed_node;
>>>> +
>>>> + if (IS_ENABLED(CONFIG_PHY_FIXED)) {
>>>> + fixed_node = ofnode_find_subnode(dev_ofnode(dev),
>>>> + "fixed-link");
>>>> + if (ofnode_valid(fixed_node))
>>>> + eqos->phy = fixed_phy_create(dev_ofnode(dev));
>>>> + }
>>>> +
>>>> + if (!eqos->phy) {
>>>> + addr = eqos_get_phy_addr(eqos, dev);
>>>> + eqos->phy = phy_connect(eqos->mii, addr, dev,
>>>> + eqos->config->interface(dev));
>>>> + }
>>>> +
>>>> if (!eqos->phy) {
>>>> pr_err("phy_connect() failed");
>>>> goto err_stop_resets;
>>>> --
>>>> 2.34.1
>>>
>>>
>>> I would give a short reminder about the patch. Reviewed by Marek, ok for
>>> Ramon. Would be glad to see it in 2023.04.
>>
>> We're already in 2023.04-rc4 , this is material for v2023.07 , i.e.
>> for u-boot/next branch .
>
> Ok, but does it change anything for the patch itself?
No, it will be applied to u-boot-net / next and then proceed via PR to
u-boot / next .
> As source isn't
> touched in last weeks it is still needed. Other way asked: Any action
> (from my side) needed?
No, it is up to Ramon now.
> I just afraid your (@Marek) and my work gets
> lost. I would expect either an "accepted" or "rejected" (for a reason).
It's just overloaded/busy maintainers problem, sadly, this does happen
from time to time. The patch is tracked by patchwork, so it shouldn't be
lost.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too.
2023-02-20 15:03 [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too Elmar Psilog
2023-03-19 10:43 ` Elmar Psilog
@ 2023-05-06 14:54 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2023-05-06 14:54 UTC (permalink / raw)
To: Elmar Psilog; +Cc: u-boot, marex, rfried.dev
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
On Mon, Feb 20, 2023 at 04:03:15PM +0100, Elmar Psilog wrote:
> Without that patch it lost track to the node to scan
> speed and duplex.
> Patch was created by Marek Vasut, just tested by me.
>
> Signed-off-by: Elmar Psilog <epsi at gmx.de>
> Reviewed-by: Marek Vasut <marex at denx.de>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-05-06 14:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-20 15:03 [PATCH v3] Let the EQoS in imx8mp handle fixed-phy too Elmar Psilog
2023-03-19 10:43 ` Elmar Psilog
2023-03-19 17:21 ` Marek Vasut
2023-03-19 20:02 ` Elmar Psilog
2023-03-19 22:58 ` Marek Vasut
2023-05-06 14:54 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox