From: Dylan Hung <dylan_hung@aspeedtech.com>
To: <lukma@denx.de>, <seanga2@gmail.com>, <ryan_chen@aspeedtech.com>,
<chiawei_wang@aspeedtech.com>, <BMC-SW@aspeedtech.com>,
<joel@jms.id.au>, <u-boot@lists.denx.de>
Subject: [PATCH 1/2] ram: ast2600: Keep MPLL power on
Date: Tue, 21 Feb 2023 21:01:09 +0800 [thread overview]
Message-ID: <20230221130110.29656-2-dylan_hung@aspeedtech.com> (raw)
In-Reply-To: <20230221130110.29656-1-dylan_hung@aspeedtech.com>
According to the PLL vendor, we should keep the PLL power on, so we
shouldn't toggle the power-down bit during PLL initialization.
Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
---
drivers/ram/aspeed/sdram_ast2600.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ram/aspeed/sdram_ast2600.c b/drivers/ram/aspeed/sdram_ast2600.c
index 18767554123f..d463933363ee 100644
--- a/drivers/ram/aspeed/sdram_ast2600.c
+++ b/drivers/ram/aspeed/sdram_ast2600.c
@@ -1089,13 +1089,13 @@ static int ast2600_sdrammc_probe(struct udevice *dev)
}
reg = readl(&priv->scu->mpll);
- reg &= ~(SCU_PLL_BYPASS | SCU_PLL_DIV_MASK |
+ reg &= ~(SCU_PLL_BYPASS | SCU_PLL_OFF | SCU_PLL_DIV_MASK |
SCU_PLL_DENUM_MASK | SCU_PLL_NUM_MASK);
- reg |= (SCU_PLL_RST | SCU_PLL_OFF | SCU_MPLL_FREQ_CFG);
+ reg |= (SCU_PLL_RST | SCU_MPLL_FREQ_CFG);
writel(reg, &priv->scu->mpll);
writel(SCU_MPLL_EXT_CFG, &priv->scu->mpll_ext);
udelay(100);
- reg &= ~(SCU_PLL_RST | SCU_PLL_OFF);
+ reg &= ~SCU_PLL_RST;
writel(reg, &priv->scu->mpll);
while ((readl(&priv->scu->mpll_ext) & BIT(31)) == 0)
--
2.25.1
next prev parent reply other threads:[~2023-02-21 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 13:01 [PATCH 0/2] Keep PLL power on Dylan Hung
2023-02-21 13:01 ` Dylan Hung [this message]
2023-02-21 23:07 ` [PATCH 1/2] ram: ast2600: Keep MPLL " Joel Stanley
2023-03-07 17:52 ` Tom Rini
2023-02-21 13:01 ` [PATCH 2/2] clk: ast2600: Keep PLL " Dylan Hung
2023-02-21 23:07 ` Joel Stanley
2023-03-07 17:52 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221130110.29656-2-dylan_hung@aspeedtech.com \
--to=dylan_hung@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=chiawei_wang@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=lukma@denx.de \
--cc=ryan_chen@aspeedtech.com \
--cc=seanga2@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox