public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dylan Hung <dylan_hung@aspeedtech.com>
To: <lukma@denx.de>, <seanga2@gmail.com>, <ryan_chen@aspeedtech.com>,
	<chiawei_wang@aspeedtech.com>, <BMC-SW@aspeedtech.com>,
	<joel@jms.id.au>, <u-boot@lists.denx.de>
Subject: [PATCH 2/2] clk: ast2600: Keep PLL power on
Date: Tue, 21 Feb 2023 21:01:10 +0800	[thread overview]
Message-ID: <20230221130110.29656-3-dylan_hung@aspeedtech.com> (raw)
In-Reply-To: <20230221130110.29656-1-dylan_hung@aspeedtech.com>

According to the PLL vendor, we should keep the PLL power on, so we
shouldn't toggle the power-down bit during PLL initialization.

Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
---
 drivers/clk/aspeed/clk_ast2600.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/clk/aspeed/clk_ast2600.c b/drivers/clk/aspeed/clk_ast2600.c
index 0df1dc3718d3..e5ada5b6d49c 100644
--- a/drivers/clk/aspeed/clk_ast2600.c
+++ b/drivers/clk/aspeed/clk_ast2600.c
@@ -538,7 +538,7 @@ static uint32_t ast2600_configure_pll(struct ast2600_scu *scu,
 	}
 
 	p_cfg->reg.b.bypass = 0;
-	p_cfg->reg.b.off = 1;
+	p_cfg->reg.b.off = 0;
 	p_cfg->reg.b.reset = 1;
 
 	reg = readl(addr);
@@ -549,7 +549,6 @@ static uint32_t ast2600_configure_pll(struct ast2600_scu *scu,
 	/* write extend parameter */
 	writel(p_cfg->ext_reg, addr_ext);
 	udelay(100);
-	p_cfg->reg.b.off = 0;
 	p_cfg->reg.b.reset = 0;
 	reg &= ~GENMASK(25, 0);
 	reg |= p_cfg->reg.w;
-- 
2.25.1


  parent reply	other threads:[~2023-02-21 13:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 13:01 [PATCH 0/2] Keep PLL power on Dylan Hung
2023-02-21 13:01 ` [PATCH 1/2] ram: ast2600: Keep MPLL " Dylan Hung
2023-02-21 23:07   ` Joel Stanley
2023-03-07 17:52   ` Tom Rini
2023-02-21 13:01 ` Dylan Hung [this message]
2023-02-21 23:07   ` [PATCH 2/2] clk: ast2600: Keep PLL " Joel Stanley
2023-03-07 17:52   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230221130110.29656-3-dylan_hung@aspeedtech.com \
    --to=dylan_hung@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=lukma@denx.de \
    --cc=ryan_chen@aspeedtech.com \
    --cc=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox