Re: [PATCH 2/2] arm: mvebu: clearfog: Add defconfig for SPI booting

Pali Rohár
2023-02-25T21:55:58Z

On Saturday 25 February 2023 11:51:28 Josua Mayer wrote:
> While I haven't tested this patchset

Are you going to test it?

> I have tested SPI booting with
> v2022.01 after applying lots of patches.
> I found that the magic value reported by bootrom when booting from SPI will
> be 0x34 on clearfog.
> The current sources only handle 0x32, hence having or not having SPL_SPI
> will always lead to returning to the bootrom.
>
> Please consider pulling in this patch:
> https://github.com/SolidRun/u-boot/commit/f4f8a69740a8415c05359e01e51650f445cda03d
> I can send it separately if you like.

There are lot of more strapping boot options for SPI and for other
peripherals. All are described in the A38x Hardware Specifications
document, publicly available and linked from the Linux ARM Marvell
documentation. Maybe it would make sense to rework this code to handle
all combinations and not just selected one?

> which I have tested by adding these config options:
>
> |CONFIG_MVEBU_SPL_BOOT_DEVICE_SPI=y # CONFIG_MVEBU_SPL_BOOT_DEVICE_MMC is
> not set # CONFIG_SPL_MMC is not set CONFIG_SPL_SPI_FLASH_SUPPORT=y
> CONFIG_SPL_SPI=y CONFIG_SPL_SPI_FLASH_TINY=y CONFIG_SPL_SPI_LOAD=y
> CONFIG_SYS_SPI_U_BOOT_OFFS=0x0 # CONFIG_ENV_IS_IN_MMC is not set
> CONFIG_ENV_IS_IN_SPI_FLASH=y # CONFIG_ENV_SECT_SIZE_AUTO is not set #
> CONFIG_USE_ENV_SPI_BUS is not set # CONFIG_USE_ENV_SPI_CS is not set #
> CONFIG_USE_ENV_SPI_MAX_HZ is not set # CONFIG_USE_ENV_SPI_MODE is not set #
> CONFIG_ENV_SPI_EARLY is not set CONFIG_ENV_ADDR=0x0|
>
> > > > CONFIG_SYS_LOAD_ADDR=0x800000
> > > > CONFIG_DEBUG_UART=y
> > > > CONFIG_AHCI=y
> > > > @@ -59,6 +63,7 @@ CONFIG_SYS_I2C_MVTWSI=y
> > > > CONFIG_I2C_EEPROM=y
> > > > CONFIG_SPL_I2C_EEPROM=y
> > > > CONFIG_MMC_BROKEN_CD=y
> > > > +CONFIG_SPL_DM_MMC=y
> > > > CONFIG_SUPPORT_EMMC_BOOT=y
> > > > CONFIG_MMC_SDHCI=y
> > > > CONFIG_MMC_SDHCI_SDMA=y
> > > > --
> > > > 2.39.2
> > > >