From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1BACCC636D6 for ; Wed, 22 Feb 2023 16:58:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F59E804E7; Wed, 22 Feb 2023 17:57:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="uAnp+POi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E600801DB; Wed, 22 Feb 2023 17:57:55 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 38B70804E7 for ; Wed, 22 Feb 2023 17:57:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-qt1-x835.google.com with SMTP id x1so8881017qtw.3 for ; Wed, 22 Feb 2023 08:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6D+RbD6feUvESzSbMwmn7g0VstnkJ9wZbKhtaMA7k8M=; b=uAnp+POiIGhqkIL6dWAwDFqb7nOvYVivmNBbeLcP2pW/36lIitGPBApENIWdHNLSRO hvFc3VrypjhVTbwfpak2obtYNwMEjU/cgfIOvoKJQENg0JbWFncL0tOmvWMq7W4K9P8r nO7j1FcjwScHXaWiXSnZ2RSYDEFga4+XJ4qLWIe+SiOT/ZxCzzUW8VD0dfXlGLhcfIvL XyYMGcTL6/PjjxKkAUF6m4bN73hpRgZf2w35Pi+ZXxKQwYblNPzYIxVICDamM01fELYM zdmlo/9Fx6EVY9jwTtn4XJqkl4RA+flWdvXmZbilYnaQeK1W1BQmMYcu+MqSFl/MDFlT iE2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6D+RbD6feUvESzSbMwmn7g0VstnkJ9wZbKhtaMA7k8M=; b=Ak3GGwA+SDyapBObn3ci1wYnGN+3JXEQKOqvudTn/X3U52Gtp5ydfY2sbTyRyaZGBd iWF80DAE7AeF1v7SrxNoPTFv8Zu6ucKtMLGwcMhWodN1BOy3mgB9251umGfiM5fhg+lF J27GnvR8bmeo03+88DjbaKXCzRewWLJKJXj81Z4BTVfGmxrH2OjuVI0YYuZJAz1REXHp IwplL205ZAtygDptjA0KiFWGziHaYTEXxWn4n/mVIelFIDkGpTsB0afHzrgWuaIHbX6a DHHpvbF3ml1gepQu8P6ZXtPVya5/iP4AxxKLib8WfGcmbpuLyrrJjCYaZ98my2LfWUWu Qxqw== X-Gm-Message-State: AO0yUKXliBdY2nxPf9I9HjPQFJRb1oc5yMJ5TypLlb1MtfTc3RYFu6t2 L3ErYMKqQrRQHLQ3WW8M+OZVRg== X-Google-Smtp-Source: AK7set/oGjivFidWgCXNJkaZIirj4Y7mbOWb0ttCu+a7oJ9gyimJ+rb9CtzgHuUFaH+OhQntchtkEg== X-Received: by 2002:ac8:5951:0:b0:3bd:a75:1cb with SMTP id 17-20020ac85951000000b003bd0a7501cbmr15349474qtz.53.1677085070934; Wed, 22 Feb 2023 08:57:50 -0800 (PST) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id fb20-20020a05622a481400b003995f6513b9sm3000545qtb.95.2023.02.22.08.57.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 08:57:50 -0800 (PST) Date: Wed, 22 Feb 2023 11:57:49 -0500 From: Ralph Siemsen To: Marek Vasut Cc: u-boot@lists.denx.de, Hai Pham , Lukasz Majewski , Marek Vasut , Sean Anderson Subject: Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver Message-ID: <20230222165749.GA50215@maple.netwinder.org> References: <20230222154414.49219-1-ralph.siemsen@linaro.org> <20230222154414.49219-4-ralph.siemsen@linaro.org> <49f64e41-adfe-b426-2a57-9c4721894885@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <49f64e41-adfe-b426-2a57-9c4721894885@mailbox.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Wed, Feb 22, 2023 at 05:06:14PM +0100, Marek Vasut wrote: >On 2/22/23 16:44, Ralph Siemsen wrote: >>Clock driver for the Renesas RZ/N1 SoC family. This is based >>on the Linux kernel drivers/clk/renesas/r9a06g032-clocks.c. > >For starters, can you please include the exact kernel version , >ideally commit ID, from which this way pulled, so that future updates >can pull in the diffs from that commit easily ? Very reasonable request, but a bit difficult to give a concise answer. Originally I took the driver as found in the 5.15 kernel. The driver actually had not changed since 5.13 commit 6bd913f54f2f ("clk: renesas: r9a06g032: Switch to .determine_rate()"). So that's the starting point. I incorporated subsequent changes to the clock tables and related cleanups. Those were only merged into Linux much later: 2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel f46efcc4746f clk: renesas: r9a06g032: Drop some unused fields 2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description Linux driver also had a few other commits, but these are not applicable to the u-boot version due to structural changes: 6bd913f54f2f clk: renesas: r9a06g032: Switch to .determine_rate() f2fb4fe62390 clk: renesas: Zero init clk_init_data 2182066d95c3 clk: renesas: r9a06g032: Probe possible children 885525c1e7e2 clk: renesas: r9a06g032: Export function to set dmamux 02693e11611e clk: renesas: r9a06g032: Repair grave increment error So I would say it is "up to date" with the lastest Linux commit, even though it is based on an earlier version. Is there a good way to include the above in the commit message, succinctly? >Also, can you please CC me on the entire series ? I've added you to series-cc for future versions. Note that some of the mails are currently stuck in moderation queue (too many recipients). I let patman pick the default recipients. Ralph