Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

Marek Vasut
2023-02-22T17:08:01Z

On 2/22/23 17:57, Ralph Siemsen wrote:
> On Wed, Feb 22, 2023 at 05:06:14PM +0100, Marek Vasut wrote:
>> On 2/22/23 16:44, Ralph Siemsen wrote:
>>> Clock driver for the Renesas RZ/N1 SoC family. This is based
>>> on the Linux kernel drivers/clk/renesas/r9a06g032-clocks.c.
>>
>> For starters, can you please include the exact kernel version ,
>> ideally commit ID, from which this way pulled, so that future updates
>> can pull in the diffs from that commit easily ?
>
> Very reasonable request, but a bit difficult to give a concise answer.
> Originally I took the driver as found in the 5.15 kernel. The driver
> actually had not changed since 5.13 commit 6bd913f54f2f ("clk: renesas:
> r9a06g032: Switch to .determine_rate()"). So that's the starting point.
>
> I incorporated subsequent changes to the clock tables and related
> cleanups. Those were only merged into Linux much later:
>
> 2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel
> f46efcc4746f clk: renesas: r9a06g032: Drop some unused fields
> 2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description
>
> Linux driver also had a few other commits, but these are not applicable
> to the u-boot version due to structural changes:
>
> 6bd913f54f2f clk: renesas: r9a06g032: Switch to .determine_rate()
> f2fb4fe62390 clk: renesas: Zero init clk_init_data
> 2182066d95c3 clk: renesas: r9a06g032: Probe possible children
> 885525c1e7e2 clk: renesas: r9a06g032: Export function to set dmamux
> 02693e11611e clk: renesas: r9a06g032: Repair grave increment error
>
> So I would say it is "up to date" with the lastest Linux commit, even
> though it is based on an earlier version. Is there a good way to include
> the above in the commit message, succinctly?

Is this still in sync with Linux 6.1.y ? That's the latest LTS .

>> Also, can you please CC me on the entire series ?
>
> I've added you to series-cc for future versions. Note that some of the
> mails are currently stuck in moderation queue (too many recipients). I
> let patman pick the default recipients.

Thanks