Re: [RFC PATCH v3 3/9] clk: renesas: add R906G032 driver

Miquel Raynal
2023-02-23T07:17:52Z

Hello Marek & Ralph,

marek.vasut@mailbox.org wrote on Thu, 23 Feb 2023 01:12:49 +0100:

> On 2/22/23 20:32, Ralph Siemsen wrote:
> > On Wed, Feb 22, 2023 at 07:45:45PM +0100, Marek Vasut wrote:
> >> On 2/22/23 19:32, Ralph Siemsen wrote:
> >>> On Wed, Feb 22, 2023 at 06:47:44PM +0100, Marek Vasut wrote:
> >>>> Are those fixes in mainline Linux ?
> >>>
> >>> Yes, they are in mainline:
> >>> 2dee50ab9e72 clk: renesas: r9a06g032: Fix UART clkgrp bitsel
> >>>   merged into 6.0, and also backported to earlier LTS branches
> >>> 2a6da4a11f47 clk: renesas: r9a06g032: Fix the RTC hclock description
> >>>    merged into 5.19, seems to be missing from LTS branches
> >>
> >> Use Linux 6.2.y as a base then.
> >
> > Okay, done.
> >
> >> And please submit the missing patches for LTS branch inclusion too if >> possible, I guess they were missing Fixes: tag ?
> >
> > Seems it was part of a series which added support for the RTC device:
> > https://lore.kernel.org/all/20220421090016.79517-3-miquel.raynal@bootlin.com/
> > Since it is new feature, I guess one could argue that the clock table > fix is not needed in older LTS kernels, since no driver uses that clock.
> > But most likely it was just overlooked. I'll check with Miquel.
>
> Much appreciated, thanks !
>
> +CC Miquel

As Ralph rightly pointed out, even though the clock description was
wrong there was no user at that time so I did not bother with a Fixes
tag. Anyhow, as the change does only impact the RTC clock, it should be
harmless to backport if you want.

Thanks,
Miquèl