From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A8B0C7EE23 for ; Wed, 1 Mar 2023 22:24:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1933B85B3F; Wed, 1 Mar 2023 23:24:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677709482; bh=uQlRSEiy4NuBryGP1UTReA9Wd/sl8ZZMLetlbJCIxIk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZDpJk+tiP/8gbcguOrXakcfsjfA/WlOxZ8rg+p8lh7dCdSClalJODRPVdfInY/ie4 7JkLFg/4ewnxJI5Yv5leLwrXd90yXr4DZYTBhOg5SD+Vj/0JgIlYEYQWYr7cGmVUB1 Ggha6RJ1x9NOhRMPHezFRx5ExAywzI14VH3i3Hmc8f6elxNzLk/l1iUjd4JOzIXz80 9S6ANb1m+L9t0Dg40qIf1WoCzn6P6OXBcAWu4Ag9nUgTbgv0p++IjFqVj0TnoRODM6 +7bJeJ4CA0IbQwUJnZbCIfnjf93Af7jdmf/kb3CudPvSuFP2IUCnMhYp7oUT6a09DG kMwVK5Q536uJA== Received: from crub (p508b636f.dip0.t-ipconnect.de [80.139.99.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D4928857CE; Wed, 1 Mar 2023 23:24:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677709480; bh=uQlRSEiy4NuBryGP1UTReA9Wd/sl8ZZMLetlbJCIxIk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ty7pWC4UEI6803QZO06+Z6DraMp0oKVZ/C/ONjSORkEYAYIEaOMfAWHcGShK9zpT1 7B1BS1MpamiokwY1fVq8NJLGHRF701e0R/8f+ZDoIRsYaEwepvcxBg2qwb33g4K9yX 5BZVhKGkBoLKoJCqfPUDrTPBHdNURTl1AbmZnT9JqftxwuiKJPGRBLeH602DjCcTQZ qTnU5d2hkeyCD3UScF0GodPWC54O1emBQgot6LunRch7JomM4UDBlMIY+mM75dqeZ9 tTITDh97fI+f6DWNjvwm/j8ObUGGDDZIxZ3UdE5+Yu2OIm0ao4BRQMfVH942e0ywXW r3qk9/GbtiXQA== Date: Wed, 1 Mar 2023 23:24:36 +0100 From: Anatolij Gustschin To: Dzmitry Sankouski Cc: u-boot@lists.denx.de, Simon Glass Subject: Re: [PATCH v7 01/10] video console: refactoring and optimization Message-ID: <20230301232436.2dbfed0b@crub> In-Reply-To: <20230227173710.1688611-2-dsankouski@gmail.com> References: <20230227173710.1688611-1-dsankouski@gmail.com> <20230227173710.1688611-2-dsankouski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Dzmitry, On Mon, 27 Feb 2023 20:37:01 +0300 Dzmitry Sankouski dsankouski@gmail.com wrote: > - move common code to vidconsole_internal.h and console_core.c > - unite probe functions > - get rid of code duplications in switch across bpp values > - extract common pixel fill logic in two functions one per > horizontal and vertical filling > - rearrange statements in put_xy* methods in unified way > - replace types - uint*_t to u* > > Signed-off-by: Dzmitry Sankouski > Reviewed-by: Simon Glass > --- > Changes for v2: none > Changes for v3: none > Changes for v4: > - move common code to vidconsole_internal.h > - unite probe functions > Changes for v5: > - move common functions to console-core.c file > - remove static keyword from shared functions > Changes for v6: none > Changes for v7: none > > drivers/video/Makefile | 6 + > drivers/video/console_core.c | 141 +++++++++++++ Building console_core.c fails for board configs without CONFIG_VIDEO_COPY, i.e.: https://source.denx.de/u-boot/custodians/u-boot-video/-/jobs/587261 I fixed it for further build testing by additionally applying: diff --git a/include/video_console.h b/include/video_console.h index 9d2c0f210e..3e1e00c23f 100644 --- a/include/video_console.h +++ b/include/video_console.h @@ -340,6 +340,9 @@ int vidconsole_sync_copy(struct udevice *dev, void *from, void *to); int vidconsole_memmove(struct udevice *dev, void *dst, const void *src, int size); #else + +#include + static inline int vidconsole_sync_copy(struct udevice *dev, void *from, void *to) { -- Anatolij