From: Tom Rini <trini@konsulko.com>
To: Troy Kisky <troykiskyboundary@gmail.com>
Cc: sjg@chromium.org, u-boot@lists.denx.de,
gary.bisson@lairdconnect.com,
"Andre Przywara" <andre.przywara@arm.com>,
"Heiko Thiery" <heiko.thiery@gmail.com>,
"Max Krummenacher" <max.krummenacher@toradex.com>,
"Pali Rohár" <pali@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Stefan Roese" <sr@denx.de>,
"Sughosh Ganu" <sughosh.ganu@linaro.org>
Subject: Re: [PATCH v2 09/26] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx
Date: Thu, 2 Mar 2023 14:19:15 -0500 [thread overview]
Message-ID: <20230302191915.GC968799@bill-the-cat> (raw)
In-Reply-To: <CAO46J5X2mW_+LHRqKBBDr7yz9CXAbOh4SZ6Gw5wdF-hyNxFNag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
On Thu, Mar 02, 2023 at 10:21:29AM -0800, Troy Kisky wrote:
> On Wed, Mar 1, 2023 at 7:33 AM Tom Rini <trini@konsulko.com> wrote:
>
> > On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote:
> > > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for
> > > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation.
> > >
> > > Signed-off-by: Troy Kisky <troykiskyboundary@gmail.com>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > > tools/Makefile | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/tools/Makefile b/tools/Makefile
> > > index 5d6284e6451..86f1b6b5049 100644
> > > --- a/tools/Makefile
> > > +++ b/tools/Makefile
> > > @@ -162,8 +162,10 @@ ifdef CONFIG_TOOLS_LIBCRYPTO
> > > # This affects include/image.h, but including the board config file
> > > # is tricky, so manually define this options here.
> > > HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE
> > > +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_SIGNATURE=1
> > > HOST_EXTRACFLAGS += -DCONFIG_FIT_SIGNATURE_MAX_SIZE=0xffffffff
> > > HOST_EXTRACFLAGS += -DCONFIG_FIT_CIPHER
> > > +HOST_EXTRACFLAGS += -DCONFIG_TOOLS_FIT_CIPHER=1
> > > endif
> >
> > Is the "=1" required here, as in we check the value of the define, not
> > just that it is defined?
> >
> > --
> > Tom
> >
>
> When it is converted to CONFIG_IS_ENABLED it will require the =1
> The CONFIG_IS_ENABLED logic counts the number of parameters and "empty
> string" doesn't count.
> I think it also compares to 1 somewhere in there.
Ah, OK, thanks.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-03-02 19:20 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:10 [PATCH v2 00/26] CONFIG_IS_ENABLED vs IS_ENABLED Troy Kisky
2023-02-24 18:10 ` [PATCH v2 01/26] kconfig: add IS_ENABLED_NOCHECK to bypass usage_of_is_enabled_check Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 02/26] cmd: nvedit: check for ENV_SUPPORT Troy Kisky
2023-03-01 15:33 ` Tom Rini
2023-03-09 19:20 ` Troy Kisky
2023-03-09 19:36 ` Tom Rini
2023-03-09 20:45 ` Troy Kisky
2023-03-10 23:29 ` Tom Rini
2023-02-24 18:10 ` [PATCH v2 03/26] lib: crc32: prepare for CONFIG_IS_ENABLED changes Troy Kisky
2023-03-01 15:33 ` Tom Rini
2023-02-24 18:10 ` [PATCH v2 04/26] lib: md5: " Troy Kisky
2023-02-24 18:10 ` [PATCH v2 05/26] lib: sha1: " Troy Kisky
2023-02-24 18:10 ` [PATCH v2 06/26] lib: sha256: " Troy Kisky
2023-02-24 18:10 ` [PATCH v2 07/26] lib: sha512: " Troy Kisky
2023-02-24 18:10 ` [PATCH v2 08/26] tools: prevent CONFIG_IS_ENABLED errors by including linux/kconfig.h Troy Kisky
2023-03-01 15:33 ` Tom Rini
2023-02-24 18:10 ` [PATCH v2 09/26] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx Troy Kisky
2023-03-01 15:33 ` Tom Rini
2023-03-02 18:21 ` Troy Kisky
2023-03-02 19:19 ` Tom Rini [this message]
2023-02-24 18:10 ` [PATCH v2 10/26] x86: cpu: qemu: qemu: remove SPL use with CONFIG_IS_ENABLED Troy Kisky
2023-02-24 18:10 ` [PATCH v2 11/26] config_distro_bootcmd: remove booting environment variables from SPL environment Troy Kisky
2023-02-24 18:10 ` [PATCH v2 12/26] ofnode: fdt_support definitions needed if OF_CONTROL is enabled Troy Kisky
2023-02-24 18:10 ` [PATCH v2 13/26] ringneck-px30: use IS_ENABLED_NOCHECK to avoid CI test failure for ENV_IS_NOWHERE Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 14/26] puma-rk3399: " Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-03-01 15:33 ` Tom Rini
2023-02-24 18:10 ` [PATCH v2 15/26] fdt_support: always define fdt_fixup_mtdparts Troy Kisky
2023-02-24 18:10 ` [PATCH v2 16/26] m53menlo: define ft_board_setup only if CONFIG_IS_ENABLED(OF_LIBFDT) Troy Kisky
2023-02-24 18:10 ` [PATCH v2 17/26] freescale: common: pfuze: define pfuze_mode_init only if defined(CONFIG_DM_PMIC) Troy Kisky
2023-02-24 18:10 ` [PATCH v2 18/26] ns16550: match when to define bdf with uart code Troy Kisky
2023-02-24 18:10 ` [PATCH v2 19/26] solidrun: mx6cuboxi: use CONFIG_IS_ENABLED(SATA) instead of CONFIG_CMD_SATA Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 20/26] wandboard: use CONFIG_IS_ENABLED(SATA) instead of ifdef CONFIG_SATA Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 21/26] arm: mach-imx: use CONFIG_$(SPL_)SATA instead of CONFIG_SATA Troy Kisky
2023-02-24 18:10 ` [PATCH v2 22/26] x86: cpu: i386: cpu: only set pci_ram_top if CONFIG_IS_ENABLED(PCI) Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 23/26] gateworks: venice: Always define setup_fec and setup_eqos Troy Kisky
2023-02-26 14:56 ` Simon Glass
2023-02-24 18:10 ` [PATCH v2 24/26] power: pmic: add dm style definitions if not CONFIG_IS_ENABLED(POWER_LEGACY) Troy Kisky
2023-02-24 18:10 ` [PATCH v2 25/26] arm: cpu: armv7: ls102xa: fdt: remove eth_device support Troy Kisky
2023-02-24 18:10 ` [PATCH v2 26/26] CI: add test/usage_of_is_enabled_check.sh Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302191915.GC968799@bill-the-cat \
--to=trini@konsulko.com \
--cc=andre.przywara@arm.com \
--cc=gary.bisson@lairdconnect.com \
--cc=heiko.thiery@gmail.com \
--cc=max.krummenacher@toradex.com \
--cc=pali@kernel.org \
--cc=samuel@sholland.org \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=sughosh.ganu@linaro.org \
--cc=troykiskyboundary@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox