From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8F8BC678D4 for ; Thu, 2 Mar 2023 19:20:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E03B85C84; Thu, 2 Mar 2023 20:20:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tUbmEy01"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3942B85C9D; Thu, 2 Mar 2023 20:20:51 +0100 (CET) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F57085B2A for ; Thu, 2 Mar 2023 20:20:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id bo10so213790qvb.12 for ; Thu, 02 Mar 2023 11:20:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677784847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9DckDSinDfInfJPssGmnaWx21jbGxONneJlhz+hmkTA=; b=tUbmEy010nRD4PrLS7JMvOUfvqZc1kNwedE0RqZ2awXX4sKCjsT5XdL9Ryll69IkWP SKLfxhRPKVnJmZmvEtj0XS2Sa1Bv3TdxuWD5H/Run+q5tWUgakKGzI8cUVfb+509v0Iv kevOuTFj7uJU+NBvVFOFtLDs+bqznDWFa8PoA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677784847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9DckDSinDfInfJPssGmnaWx21jbGxONneJlhz+hmkTA=; b=EZ5Ssf2eMrtCYeqvFgZNOQ87CvgGN2jKDXZw+DRrQ1oxtv3N1J0fuOQoWTTIYmrxpX y8g0u1TIVzTbbUkMC4iBcy9VDM154GomC2UuKmxFhMJd8qfPSxRP7ZBpmHlSF0KVX4oE AXraOxso0DI+kuQG67/M8lJ12B8QQFh1tx0uTuUcpY7fG24hg4zxDfH3NHdOsjfG4Nhu 9N7GWixegK8G513Mlos/mM2mC52IQ8l2XzWkKB+B7OHBtTJ7deiOiuCS7yWB+5iQFakX yJqnH746mAOU+NS43SKGvk0TgF2iSWQZCGW/72aS0Cy7OFaHyVsiqxBWIut4ITJ/mJTu q6gQ== X-Gm-Message-State: AO0yUKUw/T2OXUyVRHSdJYSMUrvA0G09YDvWtsG24OLSqAAhsjbdCV2/ Hci8XrTj7LeEdy3vAS4ATmP3mA== X-Google-Smtp-Source: AK7set+tBBRrU2W8ACniPVaq0lcSrNYTCooHRJTHQgKMLHFtP7pe4OX7Fum4flp262afnc4/pp7LGQ== X-Received: by 2002:a05:6214:c4f:b0:56c:52e:b169 with SMTP id r15-20020a0562140c4f00b0056c052eb169mr18176289qvj.50.1677784847103; Thu, 02 Mar 2023 11:20:47 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id 73-20020a370c4c000000b007423ccd892csm241323qkm.47.2023.03.02.11.19.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 11:20:00 -0800 (PST) Date: Thu, 2 Mar 2023 14:19:15 -0500 From: Tom Rini To: Troy Kisky Cc: sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Andre Przywara , Heiko Thiery , Max Krummenacher , Pali =?iso-8859-1?Q?Roh=E1r?= , Samuel Holland , Stefan Roese , Sughosh Ganu Subject: Re: [PATCH v2 09/26] tools: Makefile: prepare for CONFIG_IS_ENABLED changes by adding CONFIG_TOOLS_xxx Message-ID: <20230302191915.GC968799@bill-the-cat> References: <20230224181047.2775829-1-troykiskyboundary@gmail.com> <20230224181047.2775829-10-troykiskyboundary@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dG9EqOxcXXcVSLJt" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --dG9EqOxcXXcVSLJt Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 02, 2023 at 10:21:29AM -0800, Troy Kisky wrote: > On Wed, Mar 1, 2023 at 7:33=E2=80=AFAM Tom Rini wrot= e: >=20 > > On Fri, Feb 24, 2023 at 10:10:30AM -0800, Troy Kisky wrote: > > > CONFIG_IS_ENABLED(FIT_SIGNATURE) will check for > > > CONFIG_TOOLS_FIT_SIGNATURE. So define it now in preparation. > > > > > > Signed-off-by: Troy Kisky > > > Reviewed-by: Simon Glass > > > --- > > > > > > (no changes since v1) > > > > > > tools/Makefile | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/tools/Makefile b/tools/Makefile > > > index 5d6284e6451..86f1b6b5049 100644 > > > --- a/tools/Makefile > > > +++ b/tools/Makefile > > > @@ -162,8 +162,10 @@ ifdef CONFIG_TOOLS_LIBCRYPTO > > > # This affects include/image.h, but including the board config file > > > # is tricky, so manually define this options here. > > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_SIGNATURE > > > +HOST_EXTRACFLAGS +=3D -DCONFIG_TOOLS_FIT_SIGNATURE=3D1 > > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_SIGNATURE_MAX_SIZE=3D0xffffff= ff > > > HOST_EXTRACFLAGS +=3D -DCONFIG_FIT_CIPHER > > > +HOST_EXTRACFLAGS +=3D -DCONFIG_TOOLS_FIT_CIPHER=3D1 > > > endif > > > > Is the "=3D1" required here, as in we check the value of the define, not > > just that it is defined? > > > > -- > > Tom > > >=20 > When it is converted to CONFIG_IS_ENABLED it will require the =3D1 > The CONFIG_IS_ENABLED logic counts the number of parameters and "empty > string" doesn't count. > I think it also compares to 1 somewhere in there. Ah, OK, thanks. --=20 Tom --dG9EqOxcXXcVSLJt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQA9q0ACgkQFHw5/5Y0 tyz4Hgv/R7mLgq3I8samfdDcgyH2vqPTczK0FOdSm+WAFjVlqVA0wSFg1YClUNYb bEs1ezcS3+dFBQ3Ir0MUkXrdFELUeucYOEeAde8Wim2strFIhKGyAYveecDph99V a6P8m3VtnqqV8eMfqLJ872NQV9SaqOs6HicyHR+Nhr6DX3Q5U2oeQq9emj5ojcx1 n00KUaiWzAXK6l37I91klD8xss4nHcYhxPYRLFDZscD315Z45rsPq2WlR5Q8hvi1 ZaMTIdHFysC8xxbjc4FUbsGl6BZ2Gs5x2m6TV/jE8aKmYlJNKgxkdWEtK0FI+ImY SHsMURU4F0iqqJUe8DIfRIiuJtn9gVl6nPfGALJt6aEcB38In0CkvIJCS2z09Nth pRAkB9jkv/J4apXYrEuH+QSUItigf2b3Wm0m/WtsYcDvkoHXTAmSP3C+6PlSiGC8 OKjIcNX9FwFdi2J/miy3/33FIhL1RBPvbaNwUMWMooh7L3GlFGv90RQ+HVL9yEP2 gJrsJWD0 =Inmq -----END PGP SIGNATURE----- --dG9EqOxcXXcVSLJt--