From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E2AFC64EC4 for ; Fri, 3 Mar 2023 17:34:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B80BC85D69; Fri, 3 Mar 2023 18:34:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BuYpa+Q6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 08C7785D69; Fri, 3 Mar 2023 18:34:11 +0100 (CET) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3446A85A8C for ; Fri, 3 Mar 2023 18:34:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id l13so3701651qtv.3 for ; Fri, 03 Mar 2023 09:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677864847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3KrMySFbqfLsgMm6FPZELnLFlLI2IyVYoKmNT+xQe44=; b=BuYpa+Q6QWDFrZGw7XKdz/X41V+RQzOMrNuVseMWnvpipFAJAxBV4+1GrOrTcYHPJF F6RIGKe9KmHoLUfJhn7vSj9f+ppaizrID+2LMaUaM3qfeCKnf4y4jB+OiWgWwnJ0c8HC yw+hCuHDPQ9/V5RwqL0KQ3TP7q2raomgkrkQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677864847; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3KrMySFbqfLsgMm6FPZELnLFlLI2IyVYoKmNT+xQe44=; b=UED3bY2OqIgYPa/NP4cAUH906xzY3qY808CrNfPG2mIMt348jfNjeWjl6iogiCJhzj Y3Bnazm8ezP+xdMMJpmckNmO6Ctily7sv4prQ8G8edVJmaljIi9DpME3mhDi2rqM7Dq2 6KE+bP9/NAToN6P707gvSN6Ew5c+26bBqCLjSsCOcrGCF1W+uxkkyjkw952rUtYURrCq sc6iQ7OnGtgpUyASKSOEsJg142udXTHMr5UYoJDuf/qfxfd+/D6KIXhqyV8XijxToCiW moS7heyaPZ6GJNQf7ZtIsWR+8Yd2JawiI2FTCdpTvI8prq8RCfepuCKZcXzd5GcdTCdo J5yA== X-Gm-Message-State: AO0yUKV3DMAXUgL95WVThjuoFqCVEnxpoHDdmyMy7e1Rq++P0EFkdWlH by14WNW8/8H+KEBQzydvMMS4nw== X-Google-Smtp-Source: AK7set+bxiXpdkdCGQp3Hzy/e1Q2c1tTBrVG/iae0as7SchyvX15D74nQ/5awK0hEUO9kxHAejojhA== X-Received: by 2002:a05:622a:390:b0:3af:b6bd:aba7 with SMTP id j16-20020a05622a039000b003afb6bdaba7mr4083729qtx.43.1677864846842; Fri, 03 Mar 2023 09:34:06 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id g5-20020ac87d05000000b003b68d445654sm2183016qtb.91.2023.03.03.09.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 09:34:05 -0800 (PST) Date: Fri, 3 Mar 2023 12:34:03 -0500 From: Tom Rini To: Manorit Chawdhry Cc: u-boot@lists.denx.de, Andrew Davis , Vignesh Raghavendra , Neha Francis , Jayesh Choudhary , Judith Mendez , Kamlesh Gurudasani Subject: Re: [PATCH v3 3/4] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region Message-ID: <20230303173403.GE968799@bill-the-cat> References: <20230303102936.350096-1-m-chawdhry@ti.com> <20230303102936.350096-4-m-chawdhry@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NPD1wcHEl8KbblvC" Content-Disposition: inline In-Reply-To: <20230303102936.350096-4-m-chawdhry@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --NPD1wcHEl8KbblvC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 03, 2023 at 03:59:35PM +0530, Manorit Chawdhry wrote: > In non-combined boot flow for K3, all the firewalls are locked by default > until sysfw comes up. Rom configures some of the firewall for its usage > along with the SRAM for R5 but the PSRAM region is still locked. >=20 > The K3 MCU Scratchpad for j721e was set to a PSRAM region triggering the > firewall exception before sysfw came up. The exception started happening > after adding multi dtb support that accesses the scratchpad for reading > EEPROM contents. >=20 > The commit changes R5 MCU scratchpad for j721e to an SRAM region. >=20 > Old Map: > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 0x41c00000 > =E2=94=82 SPL =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41c40000 (approx) > =E2=94=82 STACK =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41c85b20 > =E2=94=82 Global data =E2=94=82 > =E2=94=82 sizeof(struct global_data) =3D 0xd8 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 gd->malloc_base =3D = 0x41c85bfc > =E2=94=82 HEAP =E2=94=82 > =E2=94=82 CONFIG_SYS_MALLOC_F_LEN =3D 0x70000 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 CONFIG_SPL_BSS_START= _ADDR > =E2=94=82 SPL BSS =E2=94=82 (0x41cf5bfc) > =E2=94=82 CONFIG_SPL_BSS_MAX_SIZE =3D 0xA000 =E2=94=82 > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 CONFIG_SYS_K3_BOOT_P= ARAM_TABLE_INDEX > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0(0x41cffbfc) >=20 > New Map: > =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 0x41c00000 > =E2=94=82 SPL =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41c40000 (approx) > =E2=94=82 EMPTY =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41c81920 > =E2=94=82 STACK =E2=94=82 > =E2=94=82 SPL_SIZE_LIMIT_PROVIDE_STACK=3D0x4000 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41c85920 > =E2=94=82 Global data =E2=94=82 > =E2=94=82 sizeof(struct global_data) =3D 0xd8 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 gd->malloc_base =3D = 0x41c859f0 > =E2=94=82 HEAP =E2=94=82 > =E2=94=82 CONFIG_SYS_MALLOC_F_LEN =3D 0x70000 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 CONFIG_SPL_BSS_START= _ADDR > =E2=94=82 SPL BSS =E2=94=82 (0x41cf59f0) > =E2=94=82 CONFIG_SPL_BSS_MAX_SIZE =3D 0xA000 =E2=94=82 > =E2=94=9C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=A4 0x41cff9fc > =E2=94=82 NEW MCU SCRATCHPAD =E2=94=82 > =E2=94=82 SYS_K3_MCU_SCRATCHPAD_SIZE =3D 0x200 =E2=94=82 > =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 CONFIG_SYS_K3_BOOT_P= ARAM_TABLE_INDEX > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0(0x41cffbfc) >=20 > Fixes: ab977c8b91b4 ("configs: j721s2_evm_r5: Enable support for building= multiple dtbs into FIT") >=20 > Signed-off-by: Manorit Chawdhry > [n-francis@ti.com: SRAM allocation addressing diagram] > Signed-off-by: Neha Francis > Reviewed-by: Tom Rini > --- > arch/arm/mach-k3/Kconfig | 3 ++- > configs/j721e_evm_r5_defconfig | 10 ++++++++-- > doc/board/ti/j721e_evm.rst | 24 ++++++++++++++++++++++++ OK, sorry. I'm glad you added this to the rst, but it's not a literal drop-in. The first issue is that "make htmldocs" notices indentation problems, and I was checking this because I'm not sure how what you did would render. Please make sure "make htmldocs" at least passes, and check the output in a browser as well to make sure the table reads well. FWIW, this is the same sphinx docbook stuff as the kernel, so there's probably some other examples in tree there you can look at if you can't find anything in-tree here that gets you the output you want. --=20 Tom --NPD1wcHEl8KbblvC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQCL4gACgkQFHw5/5Y0 tyzK/AwAjrHdV5140kDqwstQS04T0Ngq7ci642lUv77RdlycmdvRvVMT8NzRVahv z807NNjHKhMM08BIEDCd0Ken2QwNHqjot9fFa/2/djst1Ob1V2UxgAo/1Mrb+4xG tJ1wwjLgY4ExeBWvmndC99yuMt1usAxhXDMs4d+mqLcuYlPxhBU8FpBxyUsL234w 91BTB8/4kA55shHyOWp+CvGWm3egBJ9VSeCSBcLV8F4AwqwIzwQc3OrGg5F4/bah U+DkjQa38fTza7Rlns/Ste1Y1B+Xh6vwpgBocxnvEBJO2NeYw7eypJMXSjq3uqyn rAAEUIMQE+TkkIrDdj6pSFTx5RMZEsQUty3yD49/jpYTPCyc+3+bGX2QHcjdgnRd Ght1uk/V5u2/dLqEOmpvoo/ldv/tHhzNziLt+CUvdliG2xkNOPUFPR2P6m9zpiDP EjOvSDoAcOUjhuZ/OCmgY+jd2WbdFpckc87OcCmFwNWVZ89p4zS9+MbUXIC9NkXK rX1oxTND =8G3b -----END PGP SIGNATURE----- --NPD1wcHEl8KbblvC--