Re: [PATCH v5 30/44] lib: Add an SPL config for LIB_UUID

Simon Glass
2023-02-23T23:08:00Z

Hi Heinrich,

On Wed, 22 Feb 2023 at 23:19, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
>
>
> Am 22. Februar 2023 17:34:11 MEZ schrieb Simon Glass <sjg@chromium.org>:
> >This is selected by PARTITION_UUIDS which has a separate option for SPL.
> >Add an SPL option for LIB_UUID also, so that we can keep them consistent.
> >
> >Also add one for PARTITION_TYPE_GUID to avoid a build error in part_efi.c
> >which wants to call a uuid function in SPL.
> >
> >Signed-off-by: Simon Glass <sjg@chromium.org>
> >---
> >
> >(no changes since v1)
> >
> > disk/Kconfig | 8 ++++++++
> > lib/Kconfig | 4 ++++
> > 2 files changed, 12 insertions(+)
> >
> >diff --git a/disk/Kconfig b/disk/Kconfig
> >index c9b9dbaf1a6..817b7c8c76d 100644
> >--- a/disk/Kconfig
> >+++ b/disk/Kconfig
> >@@ -149,6 +149,7 @@ config SPL_PARTITION_UUIDS
> > bool "Enable support of UUID for partition in SPL"
> > depends on SPL_PARTITIONS
> > default y if SPL_EFI_PARTITION
> >+ select SPL_LIB_UUID
> >
> > config PARTITION_TYPE_GUID
> > bool "Enable support of GUID for partition type"
> >@@ -157,4 +158,11 @@ config PARTITION_TYPE_GUID
> > Activate the configuration of GUID type
> > for EFI partition
> >
> >+config SPL_PARTITION_TYPE_GUID
>
> Hello Simon,
>
> you have seen my series for using the partition type guid to load main U-Boot. I would like to put that change into v2023.04.
>
> If my series goes in first, we will have to add a patch to this series to adjust dependencies.

OK

>
> Can we use the mmc driver in sandbox_spl for testing loading main U-Boot from mmc based on different criteria like partition number, partion_type_guid, file name?
>

Yes you can.

But I suggest using sandbox_vpl, since in that build we are using
OF_REAL in SPL, i.e. it has an actual device tree. That means you
won't have to adjust the sandbox mmc driver to use of-platdata (not
that it would be particularly tricky).

You'll need to update 'TEST_PY_TEST_SPEC: "test_vpl_help or test_spl"'
in CI though, so it runs.

Regards,
Simon