From: Tom Rini <trini@konsulko.com>
To: Manorit Chawdhry <m-chawdhry@ti.com>
Cc: u-boot@lists.denx.de, Andrew Davis <afd@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Neha Francis <n-francis@ti.com>,
Jayesh Choudhary <j-choudhary@ti.com>, Judith Mendez <jm@ti.com>,
Kamlesh Gurudasani <kamlesh@ti.com>
Subject: Re: [PATCH v4 3/4] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region
Date: Mon, 6 Mar 2023 14:01:24 -0500 [thread overview]
Message-ID: <20230306190124.GC968799@bill-the-cat> (raw)
In-Reply-To: <20230306054254.28068-4-m-chawdhry@ti.com>
[-- Attachment #1: Type: text/plain, Size: 4474 bytes --]
On Mon, Mar 06, 2023 at 11:12:53AM +0530, Manorit Chawdhry wrote:
> In non-combined boot flow for K3, all the firewalls are locked by default
> until sysfw comes up. Rom configures some of the firewall for its usage
> along with the SRAM for R5 but the PSRAM region is still locked.
>
> The K3 MCU Scratchpad for j721e was set to a PSRAM region triggering the
> firewall exception before sysfw came up. The exception started happening
> after adding multi dtb support that accesses the scratchpad for reading
> EEPROM contents.
>
> The commit changes R5 MCU scratchpad for j721e to an SRAM region.
>
> Old Map:
> ┌─────────────────────────────────────┐ 0x41c00000
> │ SPL │
> ├─────────────────────────────────────┤ 0x41c40000 (approx)
> │ STACK │
> ├─────────────────────────────────────┤ 0x41c85b20
> │ Global data │
> │ sizeof(struct global_data) = 0xd8 │
> ├─────────────────────────────────────┤ gd->malloc_base = 0x41c85bfc
> │ HEAP │
> │ CONFIG_SYS_MALLOC_F_LEN = 0x70000 │
> ├─────────────────────────────────────┤ CONFIG_SPL_BSS_START_ADDR
> │ SPL BSS │ (0x41cf5bfc)
> │ CONFIG_SPL_BSS_MAX_SIZE = 0xA000 │
> └─────────────────────────────────────┘ CONFIG_SYS_K3_BOOT_PARAM_TABLE_INDEX
> (0x41cffbfc)
>
> New Map:
> ┌─────────────────────────────────────┐ 0x41c00000
> │ SPL │
> ├─────────────────────────────────────┤ 0x41c40000 (approx)
> │ EMPTY │
> ├─────────────────────────────────────┤ 0x41c81920
> │ STACK │
> │ SPL_SIZE_LIMIT_PROVIDE_STACK=0x4000 │
> ├─────────────────────────────────────┤ 0x41c85920
> │ Global data │
> │ sizeof(struct global_data) = 0xd8 │
> ├─────────────────────────────────────┤ gd->malloc_base = 0x41c859f0
> │ HEAP │
> │ CONFIG_SYS_MALLOC_F_LEN = 0x70000 │
> ├─────────────────────────────────────┤ CONFIG_SPL_BSS_START_ADDR
> │ SPL BSS │ (0x41cf59f0)
> │ CONFIG_SPL_BSS_MAX_SIZE = 0xA000 │
> ├─────────────────────────────────────┤ 0x41cff9fc
> │ NEW MCU SCRATCHPAD │
> │ SYS_K3_MCU_SCRATCHPAD_SIZE = 0x200 │
> └─────────────────────────────────────┘ CONFIG_SYS_K3_BOOT_PARAM_TABLE_INDEX
> (0x41cffbfc)
>
> Fixes: ab977c8b91b4 ("configs: j721s2_evm_r5: Enable support for building multiple dtbs into FIT")
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> [n-francis@ti.com: SRAM allocation addressing diagram]
> Signed-off-by: Neha Francis <n-francis@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---
> arch/arm/mach-k3/Kconfig | 3 ++-
> configs/j721e_evm_r5_defconfig | 10 ++++++++--
> doc/board/ti/j721e_evm.rst | 27 +++++++++++++++++++++++++++
OK, but now this just renders differently poorly. Please see the
list-table directive as used for example in doc/board/apple/m1.rst and
it would be good to get other ascii tables updated to produce nice
output as well.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-03-06 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 5:42 [PATCH v4 0/4] J721E HS Fixes Manorit Chawdhry
2023-03-06 5:42 ` [PATCH v4 1/4] arm: k3: config.mk: Add missing dependencies on tispl.bin HS Manorit Chawdhry
2023-03-06 5:42 ` [PATCH v4 2/4] configs: j721e: Merge the HS and non-HS defconfigs Manorit Chawdhry
2023-03-06 5:42 ` [PATCH v4 3/4] Kconfig: j721e: Change K3_MCU_SCRATCHPAD_BASE to non firewalled region Manorit Chawdhry
2023-03-06 19:01 ` Tom Rini [this message]
2023-03-15 6:48 ` Manorit Chawdhry
2023-03-16 18:16 ` Tom Rini
2023-03-06 5:42 ` [PATCH v4 4/4] arm: mach-k3: Increase SYSFW max image size Manorit Chawdhry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230306190124.GC968799@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=j-choudhary@ti.com \
--cc=jm@ti.com \
--cc=kamlesh@ti.com \
--cc=m-chawdhry@ti.com \
--cc=n-francis@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox