From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94004C61DA4 for ; Mon, 6 Mar 2023 20:07:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC22F84459; Mon, 6 Mar 2023 21:07:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EeLJBGjW"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 501F884459; Mon, 6 Mar 2023 21:07:50 +0100 (CET) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6695183523 for ; Mon, 6 Mar 2023 21:07:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id c19so11921515qtn.13 for ; Mon, 06 Mar 2023 12:07:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1678133265; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T+QbCJy7Np+0wxWXdeicBkk/K+PMJu+5gcLya+bI4Sc=; b=EeLJBGjWjOEd2oCJbrrecdFowFLlcFHTTILpovr0yuwqSdZr8mPr6AqyUndEUbAEMH wSE1waXwJ9cJ7bxjOTaAD2mhzetugsIc7+eqsnE2Mm0CV7z7pbJDG2M8JHCw3OZe6Xx2 zyI2Gd1tyOdFpZJTz4Ih7+LU2pHvN+/WKr8O0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678133265; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T+QbCJy7Np+0wxWXdeicBkk/K+PMJu+5gcLya+bI4Sc=; b=vHT1bhR5YOnBkbA8cUY4PtDdcxwJxRSGKRdnhVU+KUn/0yF7Dt7BFlk3v3HJ+AvGCQ nFUNaXdqxhi+JDqf90otrgV1US1eAp+jIKYYNgpGKZpyNH/ZS+TGEaiuz+iPihi0DvRa qe5mUdFERR7yR6LPsm7W6ImovYZfIJX+mQLMup3gEtQh0WzaLjEOSjWVHC+/cSOjRgvU Rq+QSznive3vZIILGVwsIDERJW9w3LP5R5mmtzIW7EM81pNBirSvdzKREAVPw+G0HOWS GWC0Qy5uQdcycc5keoyXGksSn3IOdCKkMfavTMXp0GZVCH9ssLN0ywPMUNBrycHvBwZG +Ptg== X-Gm-Message-State: AO0yUKUhZcZtG1Iut2h9sn0rFwTP8XQTMqMtcAIoaVv22H79vBdhA3dc 9381pWi4HRxjtXQZSa7joELiAA== X-Google-Smtp-Source: AK7set/aAdJPuTDysts5IXe5iVVWyE1165fElfn64Xm6R8N5DhUvbVY2Cl6CqqdG8wIoWfO6plJ7KQ== X-Received: by 2002:ac8:5f0d:0:b0:3b9:bf83:d5de with SMTP id x13-20020ac85f0d000000b003b9bf83d5demr21024166qta.26.1678133265016; Mon, 06 Mar 2023 12:07:45 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id d12-20020ac8614c000000b003b63b8df24asm8115586qtm.36.2023.03.06.12.07.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 12:07:44 -0800 (PST) Date: Mon, 6 Mar 2023 15:07:42 -0500 From: Tom Rini To: Safae Ouajih Cc: sjg@chromium.org, u-boot@lists.denx.de, sean.anderson@seco.com, r.stratiienko@gmail.com, mkorpershoek@baylibre.com, glaroque@baylibre.com, khilman@baylibre.com Subject: Re: [PATCH v3 18/19] test/py: android: extend abootimg test Message-ID: <20230306200742.GD968799@bill-the-cat> References: <20230205235021.355410-1-souajih@baylibre.com> <20230205235021.355410-19-souajih@baylibre.com> <363a0ffd-e00d-7428-5c1c-6ac96c0d948c@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fZuLq5jY9vNyvrWs" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --fZuLq5jY9vNyvrWs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 06, 2023 at 08:49:02PM +0100, Safae Ouajih wrote: >=20 > On 27/02/2023 15:18, Tom Rini wrote: > > On Mon, Feb 27, 2023 at 03:15:31PM +0100, Safae Ouajih wrote: > > > On 07/02/2023 20:02, Tom Rini wrote: > > > > On Mon, Feb 06, 2023 at 12:50:20AM +0100, Safae Ouajih wrote: > > > >=20 > > > > > test_abootimg is extended to include the testing of boot images > > > > > version 4. For this, boot.img and vendor_boot.img have been > > > > > generated using mkbootimg tool with setting the header > > > > > version to 4. > > > > >=20 > > > > > This tests: > > > > > - Getting the header version using abootimg > > > > > - Extracting the load address of the dtb > > > > > - Extracting the dtb start address in RAM > > > > >=20 > > > > > Running test: > > > > > $ ./test/py/test.py --bd sandbox --build -k test_abootimg > > > > >=20 > > > > > Signed-off-by: Safae Ouajih > > > > > Reviewed-by: Simon Glass > > > > > --- > > > > > test/py/tests/test_android/test_abootimg.py | 136 ++++++++++++= ++++++-- > > > > > 1 file changed, 123 insertions(+), 13 deletions(-) > > > > Alright, so I don't know where the failure starts, exactly. And to = make > > > > testing this easier, there's currently the > > > > trini/u-boot-gitlab-ci-runner:jammy-20230126-07Feb2023 container yo= u can > > > > use to replicate my problem. The problem is that while this test pa= sses > > > > in CI, with GCC, with Clang it fails, consistently: > > > > https://source.denx.de/u-boot/u-boot/-/jobs/572239#L284 > > > > and I'm not quite sure why. I hope that building sandbox with clang= and > > > > also just trying these features out interactively will fail too, an= d so > > > > debugging this will be less of a problem. > > > >=20 > > > Hello Tom, > > >=20 > > > I have investigated this issue, clang has a strange behavior in: > > >=20 > > > * abootimg_get_dtb_load_addr() : cmd/abootimg.c > > > * android_image_get_dtb_by_index() : boot/image-android.c > > >=20 > > > That is probably linked to some sort of optimization clang does. > > >=20 > > > However, The fail is not reproducible using clang-15 and clang-16 and= also > > > not reproducible when turning off clang optimizations. > > >=20 > > > I suggest using clang-15 to run the test or I can remove all optimiza= tions > > >=20 > > > on the related functions if clang-14 is used. > > Thanks for investigating. I see that 15 is now considered stable, so > > I'll update the next branch for that, then re-take this series. > >=20 >=20 > Hello Tom, >=20 > Thank you. >=20 > I am a bit confused, do you mean that you will apply this series after > clang-15 update? Yes, and the series to move CI to clang-15 is currently stuck on some pytest (real) failures that need to be resolved. But I would expect this to all be resolved in time for this series here to be included in v2023.07. --=20 Tom --fZuLq5jY9vNyvrWs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQGSAcACgkQFHw5/5Y0 tyw8PQv+LMm+Sm/tAc+a8swdofY0oue8789+UjET2DqU+ktatStMDt2dT5Ok3fhb It/tH6Ew7Z+/gJSkG3DPYAQEzPi6iUawJNhdu0f9Dcvq5gW6MYkQeawNfTV95cQo i1kzBXNhYLZXnvP6bisiAwbQEHiOu3wwBycO3Wv8BMktnIdrPhio7xWtxnRQpt7a vhRdi1TbY5zdmeTBCpbCyIJQzfkHLA4JoV98Tn1Yo478/qWbRrCuR6CainQFNJ5U G3qxnYFoJrVLEG01v85OSBh3/lQYgELbHlU3hXZ/Cx7uwdHl+xEB09cF9UrZAIDj tQqqvecGcg6WwGHOIqsrn1EJoNOI30yNrkl3vTKa3FTV8KYt/hLqU7f+hySXroI7 n7nbUulUc+5G0tz7PsUzgvvkV/AWQFlhEXrr2ZOa53iPyPnjC8SeWcEVpejY7pAQ ldDHX9XnEWjAzE2Ao6F0fMFv3YGEQAtv84iHs/ojxgh/ABmpDSg5Src57g1uizWF VPZgwKKs =nghA -----END PGP SIGNATURE----- --fZuLq5jY9vNyvrWs--