[PATCH] arm: dts: Enable full 4GB LPDDR4

[PATCH] arm: dts: Enable full 4GB LPDDR4

[Devarsh Thakkar]

AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part
but only 2GB was enabled early.

Enable full 4GB memory by updating the latter 2GB memory region
which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
Table 2-1. AM62A Common SoC Memory of AM62Ax TRM [1].

[1] : https://www.ti.com/lit/zip/spruj16
Logs: https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8

Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
---
 arch/arm/dts/k3-am62a7-r5-sk.dts | 4 +++-
 arch/arm/dts/k3-am62a7-sk.dts    | 5 +++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/arm/dts/k3-am62a7-r5-sk.dts b/arch/arm/dts/k3-am62a7-r5-sk.dts
index 58b7c8ad05..bead57dffe 100644
--- a/arch/arm/dts/k3-am62a7-r5-sk.dts
+++ b/arch/arm/dts/k3-am62a7-r5-sk.dts
@@ -25,7 +25,9 @@
 
 	memory@80000000 {
 		device_type = "memory";
-		reg = <0x00000000 0x80000000 0x00000000 0x80000000>; /* 2G RAM */
+		/* 4G RAM */
+		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
+		      <0x00000008 0x80000000 0x00000000 0x80000000>;
 		u-boot,dm-spl;
 	};
 
diff --git a/arch/arm/dts/k3-am62a7-sk.dts b/arch/arm/dts/k3-am62a7-sk.dts
index 576dbce80a..b08a083d72 100644
--- a/arch/arm/dts/k3-am62a7-sk.dts
+++ b/arch/arm/dts/k3-am62a7-sk.dts
@@ -26,8 +26,9 @@
 
 	memory@80000000 {
 		device_type = "memory";
-		/* 2G RAM */
-		reg = <0x00000000 0x80000000 0x00000000 0x80000000>;
+		/* 4G RAM */
+		reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
+		      <0x00000008 0x80000000 0x00000000 0x80000000>;
 	};
 
 	reserved-memory {
-- 
2.17.1

Re: [PATCH] arm: dts: Enable full 4GB LPDDR4

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

On Mon, Feb 06, 2023 at 05:04:51PM +0530, Devarsh Thakkar wrote:

> AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part
> but only 2GB was enabled early.
> 
> Enable full 4GB memory by updating the latter 2GB memory region
> which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
> Table 2-1. AM62A Common SoC Memory of AM62Ax TRM [1].
> 
> [1] : https://www.ti.com/lit/zip/spruj16
> Logs: https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
>  arch/arm/dts/k3-am62a7-r5-sk.dts | 4 +++-
>  arch/arm/dts/k3-am62a7-sk.dts    | 5 +++--
>  2 files changed, 6 insertions(+), 3 deletions(-)

The subject should include am62x in it, and what is the status of the
changes to k3-am62a7-sk.dts upstream?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH] arm: dts: Enable full 4GB LPDDR4

[Bryan Brattlof]

Hi Devarsh!

On February  6, 2023 thus sayeth Devarsh Thakkar:
> AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part
> but only 2GB was enabled early.
> 
> Enable full 4GB memory by updating the latter 2GB memory region
> which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
> Table 2-1. AM62A Common SoC Memory of AM62Ax TRM [1].
> 
> [1] : https://www.ti.com/lit/zip/spruj16
> Logs: https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---

Thanks for getting this fixed! Unfortunately, to keep our device trees 
in sync with the linux kernel, I think it's best we get this accepted in 
linux before we pull this into uboot

Thanks Again
~Bryan

Re: [PATCH] arm: dts: Enable full 4GB LPDDR4

[Devarsh Thakkar]

Hi Tom, Bryan,

Thanks for the review.
On 06/02/23 20:22, Tom Rini wrote:
> On Mon, Feb 06, 2023 at 05:04:51PM +0530, Devarsh Thakkar wrote:
> 
>> AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part
>> but only 2GB was enabled early.
>>
>> Enable full 4GB memory by updating the latter 2GB memory region
>> which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
>> Table 2-1. AM62A Common SoC Memory of AM62Ax TRM [1].
>>
>> [1] : https://www.ti.com/lit/zip/spruj16
>> Logs: https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8
>>
>> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
>> ---
>>  arch/arm/dts/k3-am62a7-r5-sk.dts | 4 +++-
>>  arch/arm/dts/k3-am62a7-sk.dts    | 5 +++--
>>  2 files changed, 6 insertions(+), 3 deletions(-)
> 
> The subject should include am62x in it, 
It's am62ax actually, will add that in subject in V2.
and what is the status of the
> changes to k3-am62a7-sk.dts upstream?
Below is the corresponding kernel patch:
https://lore.kernel.org/all/20230206115240.6026-1-devarsht@ti.com/

Regards
Devarsh
> 

Re: [PATCH] am62a7: dts: Enable full 4GB LPDDR4

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Mon, Feb 06, 2023 at 05:04:51PM +0530, Devarsh Thakkar wrote:

> AM62A7-SK board has 4GB LPDDR4 Micron MT53E2G32D4DE-046 AUT:B part
> but only 2GB was enabled early.
> 
> Enable full 4GB memory by updating the latter 2GB memory region
> which gets mapped to 0x0880000000 i.e. DDR16SS0_SDRAM as referred in
> Table 2-1. AM62A Common SoC Memory of AM62Ax TRM [1].
> 
> [1] : https://www.ti.com/lit/zip/spruj16
> Logs: https://gist.github.com/devarsht/e85b6af89c01ddadb3a62f3e5f196af8
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]