From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34AA1C678D5 for ; Tue, 7 Mar 2023 19:38:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3346885C00; Tue, 7 Mar 2023 20:38:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QgxCxlVJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2E10F85C2E; Tue, 7 Mar 2023 20:38:09 +0100 (CET) Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C9B1C85AB0 for ; Tue, 7 Mar 2023 20:38:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=anarsoul@gmail.com Received: by mail-pl1-x634.google.com with SMTP id a9so15271123plh.11 for ; Tue, 07 Mar 2023 11:38:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678217884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KyctTghYvQcPqgL1fg8EZgQVeautLTqBP63C2AqEoY0=; b=QgxCxlVJXZHEgPxbBzdQA4PZYuwxxf9OSZCd6mhhjb2efQfbX/ERJ+u8Iew6S80/LU bB4D9Pj/j4FayxqGkswBOP3r8LpvTvkuk+k14XVBSCbsR7iIbnUxCmOUxWwjxG93Gi1S q37r+Ie8OfAFwMXhy4rZsewW+D1oTdfQrqL4Wdm5jDTpmfDI74myGiedUeKvQhFnPXra Nhmq6wacs1safdLVbaVcBJ7f9KEW4O+be9hQvMyfoRPKXsgSqEmThDmUIGdfAsm4UDRj mSkxvgWv6IF9DsW0EkTvDctQXF97NmKFS6/Z5eBt3PM/H3t6jrMPgTpAH3HwMk3W/xb8 XRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678217884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KyctTghYvQcPqgL1fg8EZgQVeautLTqBP63C2AqEoY0=; b=5okIoXbCx6WDvvKt3srlJUkRa9yo7K+twSYEcCJtEcokvZgyBbOofRZn1tWCwHovyB pBMQm4ehQ6Xwd4H6LB5jsH/MirvCWn2AK23KgY9t77TfG1EJneEBlCrsngJ4Y6bltG5n MHUw+ClUWvh0viwJIEC+YqAEUpCBl0sScyTeo/YekWHE/LQu+Ilocg7oUzzlNzBEiyIb eWrds4W6casaNU8RpQbyegfTlAoO5KFIrEmWj9rmEGnvxGqR8RPQ9Piuq2Tt7/6eeTHz Oj+Ki1AG6yACCzsUK31z3u3Gq6syPt1kquxVQ8OO8mw0SYig5JHPipRJjsvxGC36ZBCU Q8kw== X-Gm-Message-State: AO0yUKVHeTcmDOZ1+EXC0glGWObtgjbJSjiMNAyD8rgP3QBrJ85Oo6W+ KsnmcIdNq8ozDnq3QIUAmnM= X-Google-Smtp-Source: AK7set/F52Bwnb1bxDA5XlR5jGlB/CFYSuiEmonP8gc4omcf2P2AZ6kCZ5OMTeHigaozH/Zd+tPc/g== X-Received: by 2002:a17:903:32ca:b0:19a:723a:8405 with SMTP id i10-20020a17090332ca00b0019a723a8405mr17162294plr.6.1678217883040; Tue, 07 Mar 2023 11:38:03 -0800 (PST) Received: from anarsoul-xps15.lan ([2604:3d08:7780:e52::398]) by smtp.gmail.com with ESMTPSA id jz16-20020a170903431000b0019258bcf3ffsm8792402plb.56.2023.03.07.11.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 11:38:02 -0800 (PST) From: Vasily Khoruzhick To: Simon Glass , Philipp Tomsich , Kever Yang , Akash Gajjar , Manoj Sai , Jagan Teki , John Keeping , Ren Jianing , u-boot@lists.denx.de Cc: Vasily Khoruzhick Subject: [PATCH 1/2] phy: rockchip-inno-usb2: add support for phy-supply Date: Tue, 7 Mar 2023 11:37:47 -0800 Message-Id: <20230307193748.25712-1-anarsoul@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean PHY driver needs to enable PHY supply, otherwise port will remain unpowered. Signed-off-by: Vasily Khoruzhick --- drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 59 ++++++++++++++++++- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 55e1dbcfef..1ef40b448e 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -19,6 +19,7 @@ #include #include #include +#include DECLARE_GLOBAL_DATA_PTR; @@ -62,6 +63,10 @@ struct rockchip_usb2phy { void *reg_base; struct clk phyclk; const struct rockchip_usb2phy_cfg *phy_cfg; +#if CONFIG_IS_ENABLED(DM_REGULATOR) + struct udevice *host_supply; + struct udevice *otg_supply; +#endif }; static inline int property_enable(void *reg_base, @@ -86,12 +91,40 @@ struct rockchip_usb2phy_port_cfg *us2phy_get_port(struct phy *phy) return &phy_cfg->port_cfgs[phy->id]; } +#if CONFIG_IS_ENABLED(DM_REGULATOR) +static int rockchip_usb2phy_regulator_set_enable(struct phy *phy, bool enable) +{ + struct udevice *parent = dev_get_parent(phy->dev); + struct rockchip_usb2phy *priv = dev_get_priv(parent); + struct udevice *supply; + int ret = 0; + if (phy->id == USB2PHY_PORT_HOST) + supply = priv->host_supply; + else + supply = priv->otg_supply; + + if (supply) + ret = regulator_set_enable(supply, enable); + + return ret; +} +#else +static int rockchip_usb2phy_regulator_set_enable(struct phy *phy, bool enable) +{ + return 0; +} +#endif + static int rockchip_usb2phy_power_on(struct phy *phy) { struct udevice *parent = dev_get_parent(phy->dev); struct rockchip_usb2phy *priv = dev_get_priv(parent); const struct rockchip_usb2phy_port_cfg *port_cfg = us2phy_get_port(phy); + int ret = rockchip_usb2phy_regulator_set_enable(phy, true); + if (ret) + return ret; + property_enable(priv->reg_base, &port_cfg->phy_sus, false); /* waiting for the utmi_clk to become stable */ @@ -108,6 +141,10 @@ static int rockchip_usb2phy_power_off(struct phy *phy) property_enable(priv->reg_base, &port_cfg->phy_sus, true); + int ret = rockchip_usb2phy_regulator_set_enable(phy, false); + if (ret) + return ret; + return 0; } @@ -149,11 +186,29 @@ static int rockchip_usb2phy_of_xlate(struct phy *phy, struct ofnode_phandle_args *args) { const char *name = phy->dev->name; + struct udevice *parent = dev_get_parent(phy->dev); + struct rockchip_usb2phy *priv = dev_get_priv(parent); +#if CONFIG_IS_ENABLED(DM_REGULATOR) + struct udevice *supply; + int ret = device_get_supply_regulator(phy->dev, "phy-supply", &supply); + if (ret && ret != -ENOENT) { + pr_err("Failed to get PHY regulator\n"); + return ret; + } +#endif - if (!strcasecmp(name, "host-port")) + if (!strcasecmp(name, "host-port")) { phy->id = USB2PHY_PORT_HOST; - else if (!strcasecmp(name, "otg-port")) +#if CONFIG_IS_ENABLED(DM_REGULATOR) + priv->host_supply = supply; +#endif + } + else if (!strcasecmp(name, "otg-port")) { phy->id = USB2PHY_PORT_OTG; +#if CONFIG_IS_ENABLED(DM_REGULATOR) + priv->otg_supply = supply; +#endif + } else dev_err(phy->dev, "improper %s device\n", name); -- 2.39.2