public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: u-boot@lists.denx.de, Anand Gore <anand.gore@broadcom.com>,
	William Zhang <william.zhang@broadcom.com>,
	Kursad Oney <kursad.oney@broadcom.com>,
	Joel Peshkin <joel.peshkin@broadcom.com>,
	Philippe Reynes <philippe.reynes@softathome.com>
Subject: Re: [PATCH] mtd: rawnand: nand_base: Handle algorithm selection
Date: Wed, 8 Mar 2023 11:55:26 -0500	[thread overview]
Message-ID: <20230308165526.GH968799@bill-the-cat> (raw)
In-Reply-To: <CACRpkdadPvbyLQhWPu_N3oZect4x1MU+4F=sCPeN6bUFzsgt=A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

On Wed, Mar 08, 2023 at 12:05:37AM +0100, Linus Walleij wrote:
> On Sun, Jan 22, 2023 at 12:43 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> > For BRCMNAND with 1-bit BCH ECC (BCH-1) such as used on the
> > D-Link DIR-885L and DIR-890L routers, we need to explicitly
> > select the ECC like this in the device tree:
> >
> >   nand-ecc-algo = "bch";
> >   nand-ecc-strength = <1>;
> >   nand-ecc-step-size = <512>;
> >
> > This is handled by the Linux kernel but U-Boot core does
> > not respect this. Fix it up by parsing the algorithm and
> > preserve the behaviour using this property to select
> > software BCH as far as possible.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> It's been 1 1/2 month, could we apply this patch?

Can we get an ack/review from someone that chimed in earlier in the
thread with comments please?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2023-03-08 16:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-21 23:43 [PATCH] mtd: rawnand: nand_base: Handle algorithm selection Linus Walleij
2023-01-26  1:14 ` William Zhang
2023-01-26  8:04   ` Rafał Miłecki
2023-01-26  8:59   ` Linus Walleij
2023-01-26 17:40     ` William Zhang
2023-03-07 23:05 ` Linus Walleij
2023-03-08 16:55   ` Tom Rini [this message]
2023-03-08 17:10     ` Michael Nazzareno Trimarchi
2023-03-08 17:48 ` Michael Nazzareno Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230308165526.GH968799@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=anand.gore@broadcom.com \
    --cc=joel.peshkin@broadcom.com \
    --cc=kursad.oney@broadcom.com \
    --cc=linus.walleij@linaro.org \
    --cc=philippe.reynes@softathome.com \
    --cc=u-boot@lists.denx.de \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox