From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0565C64EC4 for ; Wed, 8 Mar 2023 16:55:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9518385D50; Wed, 8 Mar 2023 17:55:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kos8kGuA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9768585DA7; Wed, 8 Mar 2023 17:55:32 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08AA485C8A for ; Wed, 8 Mar 2023 17:55:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id ev13so11472695qvb.10 for ; Wed, 08 Mar 2023 08:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1678294529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QNP5jJyYjd0xYKAz5JgMafkDUsUMR0ahP2GTCyRLtKA=; b=kos8kGuAV7c6ic9mJSzHc9n63sNdUpK2LPtgJWjs3lMTb+FE/L9JEToQjL2yNPjPiT HuxExJPpE+pLFoh2VqtHJFSZjhCKdunhagxoOpBBG4t2vSwfAlj7DoTju0GzTjcTxm6U 435GaHYAlhN/IxHpWKjZ+o3oGQR/HoNzIqGuU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678294529; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QNP5jJyYjd0xYKAz5JgMafkDUsUMR0ahP2GTCyRLtKA=; b=fN8N+6RvbvayBCEwtsDw6Ms6GvO7YOc+tMwS//gkqGJ8a6slchpbSzwqXJEizjRvzB Fok5tK9UeGy20sGqWQpEo6k1DV+hm7JgGeNfZgJ8omQjuGwO4GRXXstIVHs5P0CEtmxx xVO51EShsZTCh1EWVyQwei8xkn5foomaRw9FcvbpSoT8wNWBc8aHQvwlEySFy+fWbXGH yYUicEtlbpp3+/6Fn2xgQepyEeMRNbNJ14yRBEcmh5XlVOtdNXF5bsPe93AXS1ebOjsj bd83d77kxjComLr2GUP9R6n0MiMmZjjjBPUVfqQbzE96n0Rztq5mvXVIua6qG5mGkXNk jpdg== X-Gm-Message-State: AO0yUKXm9Joatq32gGSkcMG+oFwgUBhxXg/RCHR8+MOj6H3uuGjWP99W z14wosxTDYYl5JLUxtThACtRxA== X-Google-Smtp-Source: AK7set+TIGq22RqkM/u63xJUFxCynmIRn3uIP3LIgzYEWCWHou13g1VirIuy1qzQLBe9Dkk3wDD8Vg== X-Received: by 2002:ad4:4eaf:0:b0:572:636d:6281 with SMTP id ed15-20020ad44eaf000000b00572636d6281mr32764478qvb.33.1678294528739; Wed, 08 Mar 2023 08:55:28 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id bn29-20020a05620a2add00b0073bb0ef3a8esm11655256qkb.21.2023.03.08.08.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 08:55:28 -0800 (PST) Date: Wed, 8 Mar 2023 11:55:26 -0500 From: Tom Rini To: Linus Walleij Cc: u-boot@lists.denx.de, Anand Gore , William Zhang , Kursad Oney , Joel Peshkin , Philippe Reynes Subject: Re: [PATCH] mtd: rawnand: nand_base: Handle algorithm selection Message-ID: <20230308165526.GH968799@bill-the-cat> References: <20230121234338.2242486-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Xlzem8RnroSa0roj" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Xlzem8RnroSa0roj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 08, 2023 at 12:05:37AM +0100, Linus Walleij wrote: > On Sun, Jan 22, 2023 at 12:43=E2=80=AFAM Linus Walleij wrote: >=20 > > For BRCMNAND with 1-bit BCH ECC (BCH-1) such as used on the > > D-Link DIR-885L and DIR-890L routers, we need to explicitly > > select the ECC like this in the device tree: > > > > nand-ecc-algo =3D "bch"; > > nand-ecc-strength =3D <1>; > > nand-ecc-step-size =3D <512>; > > > > This is handled by the Linux kernel but U-Boot core does > > not respect this. Fix it up by parsing the algorithm and > > preserve the behaviour using this property to select > > software BCH as far as possible. > > > > Signed-off-by: Linus Walleij >=20 > It's been 1 1/2 month, could we apply this patch? Can we get an ack/review from someone that chimed in earlier in the thread with comments please? --=20 Tom --Xlzem8RnroSa0roj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQIvf4ACgkQFHw5/5Y0 tyzw7wwAi4B9F4L6EvigClaLD1OU3Wr7CKE2HUCzuNH2zMQHwN065bJ6inN9Lq0x D83GWV0ISxuGLgCHjJzB58hg/UrrcUdENoxawCSXuaajitSrpE9UdvuU3BVgCSS5 9GUXst4F/qfTS+7Tp/HhH7zNq301169gyEbUsLf4o0mtazQp+yezLZLOkqtNI4Sr x9CYACL2bovDYLEosCjvv5jlZLjFVDBT4CqqhLoB4wrhY4zNvgONkkIvYFSNlj6E ob+vyfGNTnJHgZuYcLl05W9rmpHCiUs2ZfsxD0J5CdAle1GknepGELnOYnR1IH8/ H4yzb2NiAiTKXQg3G9+CSM70z+Cbcg4QSlTgqxbkV5VQ/BPri2SCDnO8LvSd5if0 IrWo4awolk5SqwNA88HvmRA9AZF4ES4Oq4ijhbdeuGbMv+zZgtTXYcfiUu0Mcuyv 7g3EkOFj38ZLkQeghDGjq2U+9nB6bpxYqlFUFoEpv9Lux21Na1n+ZXb6+8rFDw/q ecd09NZu =gr7G -----END PGP SIGNATURE----- --Xlzem8RnroSa0roj--