Re: [PATCH v8 04/10] video console: implement multiple fonts configuration

[Anatolij Gustschin <agust@denx.de>]

On Fri, 10 Mar 2023 11:35:12 +0300
Dzmitry Sankouski dsankouski@gmail.com wrote:

> вт, 7 мар. 2023 г. в 18:22, Anatolij Gustschin <agust@denx.de>:
> (...)
> >
> > there was another build error for boards with CONFIG_VIDEO_LOGO
> > disabled:
> >
> >  https://source.denx.de/u-boot/custodians/u-boot-video/-/jobs/589501#L1430
> >
> > I changed this to
> >
> >  void splash_display_banner(void)
> >  {
> > +       struct video_fontdata __maybe_unused *fontdata = fonts;
> >         struct udevice *dev;
> >         char buf[DISPLAY_OPTIONS_BANNER_LENGTH];
> >         int col, row, ret;
> > @@ -138,9 +140,9 @@ void splash_display_banner(void)
> >         if (ret)
> >                 return;
> >
> > -#ifdef CONFIG_VIDEO_LOGO
> > -       col = BMP_LOGO_WIDTH / VIDEO_FONT_WIDTH + 1;
> > -       row = BMP_LOGO_HEIGHT / VIDEO_FONT_HEIGHT + 1;
> > +#if IS_ENABLED(CONFIG_VIDEO_LOGO)
> > +       col = BMP_LOGO_WIDTH / fontdata->width + 1;
> > +       row = BMP_LOGO_HEIGHT / fontdata->height + 1;
> >  #else
> >         col = 0;
> >         row = 0;
> >
> > --  
> should I send v9 with this patch?

No, I fixed patch 4/10 when applying. Thanks!

--
Anatolij