From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C581C6FD19 for ; Fri, 10 Mar 2023 09:24:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BB99859CD; Fri, 10 Mar 2023 10:24:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1678440289; bh=d6Fvi8xZqJyWtmjj0DjXQcLYOaH8Tdukjsa1CC8+85s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NOfP0AdRYp7bGrm8mWC3iqCWKj4Uvs0OFCtvQjoSL+xREzxWwJ3/jSJ8rtaJGX4Gl 1PW6+nMFJ7bIKtoG/1F17SpNq7kcNHpmlQ40My3vWX09mdJXujnsDBDyWaiY3gQk/m v2vXeTXXFk4m02GW1+3fHluWSOFlsr6HQ6RXg+i6ADuJ6kBACYwlVTBTS4G4V9rZmE veXBsGc0hq7g65UiUCG8oalgRTZGdrynNAGLToD8O8dv4B3qgSs2WDbFCZoYO4ljSf oysnCyDk6bsKfl/oh4+SqRw18gKZ1zHtvUjhhB/beNTrUt2OyS5VwSIfm+HOYJazbn APYZxogPxXDHA== Received: from crub (p508b636f.dip0.t-ipconnect.de [80.139.99.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id D4533859BA; Fri, 10 Mar 2023 10:24:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1678440287; bh=d6Fvi8xZqJyWtmjj0DjXQcLYOaH8Tdukjsa1CC8+85s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=R9BSqSP/g9rh6vgmS3PfjBRM3vxyMWaqdJwCWcPC506JCzULAh9H8pRBzyqxz8A/s /DqhBtdzU3Xooafuuk6n1Kiq015Pmpm0C6pjha3ghygTO49K6rEMvhzlMepDPjZi8d KIBUeFOlXZ79/0KZ/DSG16am1GoE+RlAZr1r+PPZEbvm1fdhIOUC/S6KwBADY2N7uB FQT2wBiJxVulzf+87GQnnKkkcYABvjMGit8SdmqNFTdlGedq52aPAMBOFqRZAz+5O9 a6tD3PnPLxuV25ckaFV74QJJgQmcBiHx/6/62SVtR6zEzsPW3YzQ6ixg/hpCphOjKp suxFltsaSYfxw== Date: Fri, 10 Mar 2023 10:24:46 +0100 From: Anatolij Gustschin To: Dzmitry Sankouski Cc: U-Boot Mailing List , Simon Glass , Julien Masson Subject: Re: [PATCH v8 04/10] video console: implement multiple fonts configuration Message-ID: <20230310102446.2a5dbcfc@crub> In-Reply-To: References: <20230307102121.1925581-1-dsankouski@gmail.com> <20230307102121.1925581-5-dsankouski@gmail.com> <20230307162225.4ff65990@crub> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, 10 Mar 2023 11:35:12 +0300 Dzmitry Sankouski dsankouski@gmail.com wrote: > =D0=B2=D1=82, 7 =D0=BC=D0=B0=D1=80. 2023=E2=80=AF=D0=B3. =D0=B2 18:22, An= atolij Gustschin : > (...) > > > > there was another build error for boards with CONFIG_VIDEO_LOGO > > disabled: > > > > https://source.denx.de/u-boot/custodians/u-boot-video/-/jobs/589501#L1= 430 > > > > I changed this to > > > > void splash_display_banner(void) > > { > > + struct video_fontdata __maybe_unused *fontdata =3D fonts; > > struct udevice *dev; > > char buf[DISPLAY_OPTIONS_BANNER_LENGTH]; > > int col, row, ret; > > @@ -138,9 +140,9 @@ void splash_display_banner(void) > > if (ret) > > return; > > > > -#ifdef CONFIG_VIDEO_LOGO > > - col =3D BMP_LOGO_WIDTH / VIDEO_FONT_WIDTH + 1; > > - row =3D BMP_LOGO_HEIGHT / VIDEO_FONT_HEIGHT + 1; > > +#if IS_ENABLED(CONFIG_VIDEO_LOGO) > > + col =3D BMP_LOGO_WIDTH / fontdata->width + 1; > > + row =3D BMP_LOGO_HEIGHT / fontdata->height + 1; > > #else > > col =3D 0; > > row =3D 0; > > > > -- =20 > should I send v9 with this patch? No, I fixed patch 4/10 when applying. Thanks! -- Anatolij