From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FCF8C6FD1F for ; Thu, 16 Mar 2023 18:17:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 876FD85DB0; Thu, 16 Mar 2023 19:17:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="azce473g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ADA7285E4A; Thu, 16 Mar 2023 19:17:34 +0100 (CET) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A6D2E85DB0 for ; Thu, 16 Mar 2023 19:17:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id l13so2785863qtv.3 for ; Thu, 16 Mar 2023 11:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1678990650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/UVIQHS8uL3v2zeDEHQfqPZQR+sfhL3/Z43eQJFf2y0=; b=azce473gSD9h68X9gtRbDtUpKwCD5kso8Yfgv/+S/BlPSpdykWuYUAg57aIrdMl7mN /jv/X/Gn8V2m2JhAQPR+Bl/uLGEbIi2SXZpmTB6FIyJFPXWlm4qWzWPa1z3vfIMhHMhj kl/3uOG/kg9Zz+/qEHzrdPvhWtkpQy/DD2Ge4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678990650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/UVIQHS8uL3v2zeDEHQfqPZQR+sfhL3/Z43eQJFf2y0=; b=Njx/HYy7JKjFof0O6awfuTsdpq0qVfv8AAFM2U7alQXAQcNAonSU1Aaw5KstXl9R3M x2nj6UQctktVpoRljeIE+31v4/eN8WBv9szqOSBWHXgsX8h8r+EXOYARK8Dzgr1wfYx9 Wd+xKSrQP8QKCDhG1h6IybRyVKLSvYJGvljfTYzoAUjqwJbuWllYWGo+JsMtBVKkiNTx UurxtJdGMO2V4cYv7kAFeItXcjuwMcHi4LZBhmmVw+13s0OZcFV+1bR8DVCsH3bZ0hQW msWA3A1Rn8j8F7hcc/q33tOiXErMCwPslIKqvU5xnrOBCYGlnCC5BRWc2ZvU5cEXGE60 z4sA== X-Gm-Message-State: AO0yUKUdrLEnYX2FgpGgBq1w+BMuMe79Viah0GnjP7oZN2v2aqT/y75c 54SEpLEth8bds5qGiGMn5jjY5Q== X-Google-Smtp-Source: AK7set+5qCiT92ht26UmTUDaARGU/Au0wcdLoggZLuZYWaBrFkBMHpX2KJ32agpNKOZ/4V28/YN18g== X-Received: by 2002:a05:622a:1115:b0:3bf:a15e:a898 with SMTP id e21-20020a05622a111500b003bfa15ea898mr7855510qty.18.1678990650456; Thu, 16 Mar 2023 11:17:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1b74-53e3-8162-4fca.res6.spectrum.com. [2603:6081:7b00:6400:1b74:53e3:8162:4fca]) by smtp.gmail.com with ESMTPSA id dp10-20020a05620a2b4a00b00745af48838bsm74293qkb.5.2023.03.16.11.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 11:17:29 -0700 (PDT) Date: Thu, 16 Mar 2023 14:17:27 -0400 From: Tom Rini To: Peter Robinson Cc: Simon Glass , Jonas Karlman , Vagrant Cascadian , U-Boot Mailing List , huang lin , Jeffy Chen , Kever Yang , Akash Gajjar , Jagan Teki Subject: Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64 Message-ID: <20230316181727.GP54321@bill-the-cat> References: <20230221193920.3546499-2-sjg@chromium.org> <875ybur3zm.fsf@contorta> <877cw9y354.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="n2MFy2gvYN9QHwGx" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --n2MFy2gvYN9QHwGx Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 16, 2023 at 11:01:01AM +0000, Peter Robinson wrote: > On Wed, Feb 22, 2023 at 7:17=E2=80=AFPM Tom Rini wro= te: > > > > On Wed, Feb 22, 2023 at 12:03:58PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 22 Feb 2023 at 12:01, Tom Rini wrote: > > > > > > > > On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > > > > > Hi, > > > > > > > > > > On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wro= te: > > > > > > > > > > > > On 2023-02-22 19:24, Tom Rini wrote: > > > > > > > On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian w= rote: > > > > > > >> On 2023-02-21, Vagrant Cascadian wrote: > > > > > > >>> On 2023-02-21, Simon Glass wrote: > > > > > > >>>> This board has moved to standard boot but the old 'distro_= bootcmd' > > > > > > >>>> command is still active. Disable DISTRO_DEFAULTS to fix th= is. > > > > > > >>> > > > > > > >>> Works for booting rockpro64-rk3399, thanks! > > > > > > >> > > > > > > >> I can also confirm that applying a very similar patch for > > > > > > >> pinebook-pro-rk3399 works booting with bootstd. > > > > > > >> > > > > > > >> Seems worth adding if there is a v2 of the patch series. > > > > > > >> > > > > > > >> Alternately, rather than doing this on a board-by-board basi= s, is there > > > > > > >> some way to disable CONFIG_DISTRO_DEFAULTS when a board is u= sing > > > > > > >> BOOTSTD? > > > > > > > > > > > > > > I think that's possibly a bit dangerous? DISTRO_DEFAULTS and > > > > > > > BOOTSTD_DEFAULTS need to be reconciled to a single new symbol= , and the > > > > > > > DISTRO_DEFAULTS method of select not imply for most things is= also I > > > > > > > suspect the right path. > > > > > > > > > > > > > > > > > > > Another option would be to set BOOTSTD_BOOTCOMMAND=3Dy, this is= the main > > > > > > issue with rk3399 at the moment, distro_bootcmd got removed fro= m env, > > > > > > yet bootcmd is still "run distro_bootcmd" due to DISTRO_DEFAULT= S=3Dy. > > > > > > > > > > > > > > > > > > config BOOTCOMMAND > > > > > > default "bootflow scan -lb" if BOOTSTD_BOOTCOMMAND && C= MD_BOOTFLOW_FULL > > > > > > default "bootflow scan" if BOOTSTD_BOOTCOMMAND && !CMD_= BOOTFLOW_FULL > > > > > > default "run distro_bootcmd" if !BOOTSTD_BOOTCOMMAND &&= DISTRO_DEFAULTS > > > > > > > > > > > > config BOOTSTD_BOOTCOMMAND > > > > > > default y if !DISTRO_DEFAULTS > > > > > > > > > > That seems reasonable to me, along with a 'depends on BOOTSTD' > > > > > > > > > > At present DISTRO_DEFAULTS is both enabled in defconfig files (ab= out > > > > > 350) and Kconfig (another 300). For rockchip it is the latter. > > > > > > > > > > It doesn't really make sense to use DISTRO_DEFAULTS when using > > > > > BOOTSTD_DEFAULTS. One is 'run distro_bootcmd' and the other is > > > > > 'bootflow scan', possibly with -lb flags. But we really don't want > > > > > people flipping back and forward. > > > > > > > > It doesn't make linguistic sense to have "distro defaults" and "boo= tstd > > > > defaults" enabled. It makes compute sense to have these two symbols > > > > combined as they're nearly identical and have a similar conceptual = need > > > > (make sure we have things like bootz/booti/ext4/etc support). > > > > > > Oh, so you are talking about DISTRO_DEFAULTS, not the actual command? > > > In that case I can do a patch to make them both use a common symbol to > > > bring in most stuff, although bootstd does not need hush and a few > > > other things that are needed by distro_bootcmd. > > > > > > Let me know if that makes sense. > > > > Yeah, the Kconfig symbols DISTRO_DEFAULTS and BOOTSTD_DEFAULTS need to > > be reconciled and combined. This is separate from setting bootcmd to > > "run distro_bootcmd", which should be separate, and yes, not be the > > chosen symbol when we have bootstd enabled. >=20 > What came out of this decision, the first other rk3399 device I tried, > the rock960, is also broken booting. We really can't have devices > randomly broken all the time and I don't have the time or the devices > to go through and test everything. We should really be getting better > at these mass changes, it doesn't lead to a great user experience! Part of the problem is that Rockchip had a few issues at the end of the last cycle and then the start of this one. Another issue is that I don't have a Rockchip platform in my CI loop, but I'm hoping to fix that in the next week or so. Is top of tree working on your platforms or no? They should be, at this point. --=20 Tom --n2MFy2gvYN9QHwGx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQTXTcACgkQFHw5/5Y0 tyxZ5QwAkp3NYbLh44IGkrFbH/q6iIF/+Z3blSOytMQZttS5URHcsKAMuneRITou l7v8nzv5zsmvkzXTEb7anaSOobV/KfSQJCkDoefrp6pR/8O8kXzD6KeB3n3n49Fv jbALSfYYQXn2yqPo4kzHHiPqGCxIkajUBP54wyGPc8XWKlfFHfO47c3xf2nCQeW2 GB5Zh+98Y5KZ5CAafO6dflJq+wSEREi67Ht7+5rNIATo2XTSyO8iUc6+jwUzcjS6 FGEjCCEkFRzXHDEjKdshjf1XZOHmGXk/FeL8z5qX+U2bAb9vmMlrCoV/I0O5m4Bl OB0NB5SOzsbUSKe5FOiaEqtads3Dgt+7uPCbHr1aDZLOfzNSak5foTLPlPDRLL4z 0b6TA6JdBaqQo3Xp2g/35gByCnVOxQd7/sHySrn0pGxDxxuyPO/a6UrOctr4wc5E u4lMgmwR5iy6LQoWNu4qxYp0ApCXJv8/CSwtzkokc04jkxT7mdN4mlfzrDOmEf7t cwZZDEVi =l53Y -----END PGP SIGNATURE----- --n2MFy2gvYN9QHwGx--