Re: [PATCH] fs: fat: do not mangle short filenames

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wrote:
> Am 20.03.2023 um 18:01 schrieb Tom Rini:
> > On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeier wrote:
> > 
> > > From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> > > 
> > > Do not mangle lower or mixed case filenames which fit into the upper
> > > case 8.3 short filename. This ensures FAT standard compatible short
> > > filenames (SFN) to support systems without long filename (LFN) support
> > > like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for LFN
> > > boot.bin).
> > > 
> > > Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
> > > 
> > > ---
> > > 
> > >   fs/fat/fat_write.c | 11 +++++++----
> > >   1 file changed, 7 insertions(+), 4 deletions(-)
> > Can we update test/py/tests/test_fs/ somewhere to have a test for this
> > case? Thanks.
> 
> What is the recommended approach to test internal behavior? The short name
> isn't avialable at the terminal because u-boot support VFAT.

Well, you triggered this problem with a filesystem that had contents
that were "just so" and then didn't work as expected, yes?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]