From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2FDF9C7619A for ; Wed, 22 Mar 2023 13:20:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 324D985BBB; Wed, 22 Mar 2023 14:20:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="gfthLuPi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 46AAA85B43; Wed, 22 Mar 2023 14:20:13 +0100 (CET) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 25E1985CCE for ; Wed, 22 Mar 2023 14:20:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id c18so22485581qte.5 for ; Wed, 22 Mar 2023 06:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1679491209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NZ3eIaOhAxZmSXEQDRU/mg5fjFuwGfbXSlxe6o1Kj0A=; b=gfthLuPiaSnnUTG2YhVtgZR2Cv8c3yrOFLnWrqmq4mucaVYFreXnjwSrQBlrtyBzuQ 2JrL1Deb5tvloqRZa3u9t82ZdplbzVSU3R0X7hdIBU/Jy4NQRNFdEDZLqfTKjESRtX2+ nnt2RsBoZsSexdcIDSrHFg2yGwG3FRhlixUVc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679491209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NZ3eIaOhAxZmSXEQDRU/mg5fjFuwGfbXSlxe6o1Kj0A=; b=SaGDHVOphLTH6TKI7BtTXP2LhswA4yqyMa5z7PoMSBM/eOyPm8ZWBqu3a84h4dTN+5 fLIIk1adLMvYxNrK6jM1Bh80WeYkntjR75+2dtamgr6iPgUYaG0vEnUirKddZhD3Mhr/ jSr1A5OmFE97pa+lsl+KxWsZ/9cLxUvGWT3GPEVXAT4qKV5RJRR+iBtYyR0cYuAmBb88 kyWxSK2PQqJhWNZHtpVrCwWTufNOu85GXTmS7u0xhBHJaXU/JMo3Hyqad2JwdH/MjtJ9 bpUe3iY+SsjMPckprDN29j8rAHD465hvDD76H1/tyjYhMZbv3rVhlLy4Ha/LCYHy6di8 B0lw== X-Gm-Message-State: AO0yUKX77RpZqGHBEcOkt6NGAp1HsGRe1wXMYpa0LjahWBGDgS6jvoCj 9tZLTRYHOMPIDnNbEQM3+1I+cw== X-Google-Smtp-Source: AK7set9FG5kH0FsKo8ASX3rqtjskPwkvGkJ7FMLuhjqywGvoejvaX6K88aWV0gXKjyCg8XPLyEGz1g== X-Received: by 2002:a05:622a:1491:b0:3bf:db29:b793 with SMTP id t17-20020a05622a149100b003bfdb29b793mr5865621qtx.20.1679491208830; Wed, 22 Mar 2023 06:20:08 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-8fb4-da0c-fb38-955c.res6.spectrum.com. [2603:6081:7b00:6400:8fb4:da0c:fb38:955c]) by smtp.gmail.com with ESMTPSA id r80-20020a374453000000b007465ee178a3sm9980710qka.96.2023.03.22.06.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 06:20:07 -0700 (PDT) Date: Wed, 22 Mar 2023 09:20:06 -0400 From: Tom Rini To: Stefan Herbrechtsmeier Cc: u-boot@lists.denx.de, Stefan Herbrechtsmeier , Simon Glass Subject: Re: [PATCH] fs: fat: do not mangle short filenames Message-ID: <20230322132006.GB8135@bill-the-cat> References: <20230317120413.11066-1-stefan.herbrechtsmeier-oss@weidmueller.com> <20230320170105.GA8135@bill-the-cat> <20230321153535.GS8135@bill-the-cat> <0ddfb023-08a4-8469-f467-c871cfd596bb@weidmueller.com> <20230321155404.GX8135@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yRrAjTOjv+//zzW2" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --yRrAjTOjv+//zzW2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 22, 2023 at 09:51:32AM +0100, Stefan Herbrechtsmeier wrote: > Am 21.03.2023 um 16:54 schrieb Tom Rini: > > On Tue, Mar 21, 2023 at 04:53:22PM +0100, Stefan Herbrechtsmeier wrote: > > > Am 21.03.2023 um 16:35 schrieb Tom Rini: > > > > On Tue, Mar 21, 2023 at 08:43:07AM +0100, Stefan Herbrechtsmeier wr= ote: > > > > > Am 20.03.2023 um 18:01 schrieb Tom Rini: > > > > > > On Fri, Mar 17, 2023 at 01:04:13PM +0100, Stefan Herbrechtsmeie= r wrote: > > > > > >=20 > > > > > > > From: Stefan Herbrechtsmeier > > > > > > >=20 > > > > > > > Do not mangle lower or mixed case filenames which fit into th= e upper > > > > > > > case 8.3 short filename. This ensures FAT standard compatible= short > > > > > > > filenames (SFN) to support systems without long filename (LFN= ) support > > > > > > > like boot roms (ex. SFN BOOT.BIN instead of BOOT~1.BIN for LFN > > > > > > > boot.bin). > > > > > > >=20 > > > > > > > Signed-off-by: Stefan Herbrechtsmeier > > > > > > >=20 > > > > > > > --- > > > > > > >=20 > > > > > > > fs/fat/fat_write.c | 11 +++++++---- > > > > > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > Can we update test/py/tests/test_fs/ somewhere to have a test f= or this > > > > > > case? Thanks. > > > > > What is the recommended approach to test internal behavior? The s= hort name > > > > > isn't avialable at the terminal because u-boot support VFAT. > > > > Well, you triggered this problem with a filesystem that had contents > > > > that were "just so" and then didn't work as expected, yes? > > >=20 > > > No, I write a file to a file system and the boot rom do not find the = file > > > because the name was wrong (BOOT~1.BIN instead of BOOT.BIN). > > >=20 > > > The mdir command shows the short and long file name. I will add a > > > test_fat.py with a test. > > Ah, ok, and great, thanks! >=20 >=20 > I have send a separate patch `test: fs: Check fat short file name` or sho= uld > I send a new series with both patches? A follow-up is fine. --=20 Tom --yRrAjTOjv+//zzW2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQbAH8ACgkQFHw5/5Y0 tyzIAgv/coHpb+DvpHQrSOnjBsArEogmuVCLBAyGhqCzHDPAKhV4zF/x//c3No0s eAJbLXwp0offOd8y+yqhNqIEU2rSGdyiMInDjmp79UntliOa2r7yDfbT2pSD0uYT 25oq8Hi+Yy+751veRUeCrW7KznHvxJRWEsURsBdqtPzvAPezWpwzxhcVy2Ivqs83 sr85OPhr6jiKJHE4n2IyOdolwB7pDlq2VmWoqOk21VdWf34YbcDQN9ux1+zfnmlF wbHtXraHdRyy0Jt0eXhSIleLLWKFeBK9CRn7E5DerKw95cGT1zZuiD8KZHGCsBa4 y8PI07RDV6frj62qpeOw+FhBiWnb+FPLuKhyvgdler+xSLceyI0nJ+7ekC4UruU/ qznPacKfPODJqZ/shYx3oR1UmLZKPmanY4PjOK6SuXV1zLWoZB3ydMmmjN39iY/F r+JC0UkjDk4djPMfbH7scfyK2h9Y3feZNicf7AIY/mByxXjo4RP0m5LOloPYzmBi go+pWmKF =GLqJ -----END PGP SIGNATURE----- --yRrAjTOjv+//zzW2--