* [PATCH] ram: rk3399: add missing high row detection
@ 2023-03-23 10:35 Jonathan Liu
2023-04-14 9:31 ` Kever Yang
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Liu @ 2023-03-23 10:35 UTC (permalink / raw)
To: u-boot; +Cc: Kever Yang, YouMin Chen, Jagan Teki, Jonathan Liu
For 2 GB LPDDR4 single-rank RAM with 16 rows, the Rockchip ddr init bin
prints:
"Bus Width=32 Col=10 Bank=8 Row=16 CS=1 Die Bus-Width=16 Size=2048MB"
U-Boot TPL prints:
"BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16 Size=2048MB"
Add missing high row detection so that U-Boot TPL prints Row=16, same as
the Rockchip ddr init bin:
"BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB"
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
drivers/ram/rockchip/sdram_rk3399.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
index b1fea04e84..b597448203 100644
--- a/drivers/ram/rockchip/sdram_rk3399.c
+++ b/drivers/ram/rockchip/sdram_rk3399.c
@@ -2749,6 +2749,8 @@ static u64 dram_detect_cap(struct dram_info *dram,
/* detect cs1 row */
sdram_detect_cs1_row(cap_info, params->base.dramtype);
+ sdram_detect_high_row(cap_info);
+
/* detect die bw */
sdram_detect_dbw(cap_info, params->base.dramtype);
--
2.40.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ram: rk3399: add missing high row detection
2023-03-23 10:35 [PATCH] ram: rk3399: add missing high row detection Jonathan Liu
@ 2023-04-14 9:31 ` Kever Yang
0 siblings, 0 replies; 2+ messages in thread
From: Kever Yang @ 2023-04-14 9:31 UTC (permalink / raw)
To: Jonathan Liu, u-boot; +Cc: YouMin Chen, Jagan Teki
On 2023/3/23 18:35, Jonathan Liu wrote:
> For 2 GB LPDDR4 single-rank RAM with 16 rows, the Rockchip ddr init bin
> prints:
> "Bus Width=32 Col=10 Bank=8 Row=16 CS=1 Die Bus-Width=16 Size=2048MB"
>
> U-Boot TPL prints:
> "BW=32 Col=10 Bk=8 CS0 Row=16/15 CS=1 Die BW=16 Size=2048MB"
>
> Add missing high row detection so that U-Boot TPL prints Row=16, same as
> the Rockchip ddr init bin:
> "BW=32 Col=10 Bk=8 CS0 Row=16 CS=1 Die BW=16 Size=2048MB"
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> drivers/ram/rockchip/sdram_rk3399.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ram/rockchip/sdram_rk3399.c b/drivers/ram/rockchip/sdram_rk3399.c
> index b1fea04e84..b597448203 100644
> --- a/drivers/ram/rockchip/sdram_rk3399.c
> +++ b/drivers/ram/rockchip/sdram_rk3399.c
> @@ -2749,6 +2749,8 @@ static u64 dram_detect_cap(struct dram_info *dram,
> /* detect cs1 row */
> sdram_detect_cs1_row(cap_info, params->base.dramtype);
>
> + sdram_detect_high_row(cap_info);
> +
> /* detect die bw */
> sdram_detect_dbw(cap_info, params->base.dramtype);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-14 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-23 10:35 [PATCH] ram: rk3399: add missing high row detection Jonathan Liu
2023-04-14 9:31 ` Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox