From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <u-boot-bounces@lists.denx.de>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from phobos.denx.de (phobos.denx.de [85.214.62.61])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id CA8F2C6FD1C
	for <u-boot@archiver.kernel.org>; Fri, 24 Mar 2023 12:53:27 +0000 (UTC)
Received: from h2850616.stratoserver.net (localhost [IPv6:::1])
	by phobos.denx.de (Postfix) with ESMTP id 80B5D857DC;
	Fri, 24 Mar 2023 13:53:25 +0100 (CET)
Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de
Received: by phobos.denx.de (Postfix, from userid 109)
 id 37AC085A12; Fri, 24 Mar 2023 13:53:24 +0100 (CET)
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by phobos.denx.de (Postfix) with ESMTPS id EF3F485720
 for <u-boot@lists.denx.de>; Fri, 24 Mar 2023 13:53:21 +0100 (CET)
Authentication-Results: phobos.denx.de;
 dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=duwe@lst.de
Received: by verein.lst.de (Postfix, from userid 107)
 id 45D9568BFE; Fri, 24 Mar 2023 13:53:20 +0100 (CET)
Received: from blackhole.lan (p5b2ece7e.dip0.t-ipconnect.de [91.46.206.126])
 by verein.lst.de (Postfix) with ESMTPSA id 9BF6A6732A;
 Fri, 24 Mar 2023 13:53:11 +0100 (CET)
Date: Fri, 24 Mar 2023 13:53:06 +0100
From: Torsten Duwe <duwe@lst.de>
To: Yanhong Wang <yanhong.wang@starfivetech.com>
Cc: <u-boot@lists.denx.de>, Rick Chen <rick@andestech.com>, Leo
 <ycliang@andestech.com>, Joe Hershberger <joe.hershberger@ni.com>, "Ramon
 Fried" <rfried.dev@gmail.com>
Subject: Re: [PATCH v1 0/5] Add Ethernet driver for StarFive JH7110 SoC
Message-ID: <20230324135306.7a773e7c@blackhole.lan>
In-Reply-To: <20230317010536.17860-1-yanhong.wang@starfivetech.com>
References: <20230317010536.17860-1-yanhong.wang@starfivetech.com>
Organization: LST e.V.
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: u-boot@lists.denx.de
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: U-Boot discussion <u-boot.lists.denx.de>
List-Unsubscribe: <https://lists.denx.de/options/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>
List-Archive: <https://lists.denx.de/pipermail/u-boot/>
List-Post: <mailto:u-boot@lists.denx.de>
List-Help: <mailto:u-boot-request@lists.denx.de?subject=help>
List-Subscribe: <https://lists.denx.de/listinfo/u-boot>,
 <mailto:u-boot-request@lists.denx.de?subject=subscribe>
Errors-To: u-boot-bounces@lists.denx.de
Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de
X-Virus-Status: Clean

On Fri, 17 Mar 2023 09:05:31 +0800
Yanhong Wang <yanhong.wang@starfivetech.com> wrote:

> This series adds ethernet support for the StarFive JH7110 RISC-V SoC.
> The series includes PHY and MAC drivers. The PHY model is
> YT8531 (from Motorcomm Inc), and the MAC version is dwmac-5.20
> (from Synopsys DesignWare). 
> 
> The implementation of the phy driver is ported from linux, but it
> has been adjusted for the u-boot framework.
> 
> The PHY and MAC driver has been tested on the StarFive VisionFive 2 1.2A
> and 1.3B boards and works normally.

At least a smoke test here succeeded as well, I'm seeing replies to DHCP.
However:

| Model: StarFive VisionFive 2 v1.3B
[...]
| Net:   
| Warning: ethernet@16040000 (eth1) using random MAC address - e2:b9:39:bd:92:24
| 
| Warning: ethernet@16030000 (eth0) using random MAC address - 22:da:dc:e6:2c:17
| eth0: ethernet@16030000, eth1: ethernet@16040000
[...]

What's missing to read the correct MACs from the EEPROM?

	Torsten