From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
huang lin <hl@rock-chips.com>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Vagrant Cascadian <vagrant@debian.org>,
Jonas Karlman <jonas@kwiboo.se>,
Philipp Tomsich <philipp.tomsich@vrull.eu>
Subject: Re: [PATCH v4 4/4] rockchip: Use the same boot_targets for all boards
Date: Wed, 29 Mar 2023 10:19:13 -0400 [thread overview]
Message-ID: <20230329141913.GD6083@bill-the-cat> (raw)
In-Reply-To: <20230329201631.v4.4.I3dd639e8c7824c9b0301884a1180cf3b9107766e@changeid>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On Wed, Mar 29, 2023 at 08:16:39PM +1300, Simon Glass wrote:
> It doesn't really matter if we mention things which are not present. For
> example, if 'nvme' is included but the board does not support it, we get
> a message like:
>
> Unknown uclass 'nvme' in label
>
> This seems tolerable. If it creates confusion we could perhaps find a way
> to avoid the message, e.g. by maintaining a list of uclasses which may
> be missing from the build and supressing warnings about them.
>
> It is simpler to use the same target list for all boards, so drop the
> different one for rk3399.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Perhaps "bootflow scan -v" should print that, but normally we don't? And
a "bootflow scan .." that finds nothing should suggest trying passing -v
to see some possible errors.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-03-29 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 7:16 [PATCH v4 1/4] bootstd: Enable BOOTSTD_DEFAULTS by default Simon Glass
2023-03-29 7:16 ` [PATCH v4 2/4] rockchip: Move to standard boot Simon Glass
2023-03-29 7:16 ` [PATCH v4 3/4] bootstd: Relax the argument requirements for bootflow scan Simon Glass
2023-03-29 14:17 ` Tom Rini
2023-03-29 7:16 ` [PATCH v4 4/4] rockchip: Use the same boot_targets for all boards Simon Glass
2023-03-29 14:19 ` Tom Rini [this message]
2023-03-29 7:41 ` [PATCH v4 1/4] bootstd: Enable BOOTSTD_DEFAULTS by default Michal Simek
2023-03-29 7:55 ` Nicolas Ferre
2023-03-30 9:17 ` Simon Glass
2023-03-30 14:09 ` Tom Rini
2023-03-29 14:15 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230329141913.GD6083@bill-the-cat \
--to=trini@konsulko.com \
--cc=hl@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=kever.yang@rock-chips.com \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vagrant@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox