[PATCH] pci: apple: Initialize only enabled ports

[PATCH] pci: apple: Initialize only enabled ports

[Janne Grunau]

The Linux devicetrees for Apple silicon devices are after review
feedback switching from deleting unused PCIe ports to disabling them.

Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
Signed-off-by: Janne Grunau <j@jannau.net>
---
 drivers/pci/pcie_apple.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/pcie_apple.c b/drivers/pci/pcie_apple.c
index 9b08e1e5da87..b934fdbc35c2 100644
--- a/drivers/pci/pcie_apple.c
+++ b/drivers/pci/pcie_apple.c
@@ -315,6 +315,8 @@ static int apple_pcie_probe(struct udevice *dev)
 	for (of_port = ofnode_first_subnode(dev_ofnode(dev));
 	     ofnode_valid(of_port);
 	     of_port = ofnode_next_subnode(of_port)) {
+		if (!ofnode_is_enabled(of_port))
+			continue;
 		ret = apple_pcie_setup_port(pcie, of_port);
 		if (ret) {
 			dev_err(pcie->dev, "Port %d setup fail: %d\n", i, ret);

---
base-commit: 6c1cdf158c4f3ccc8c5f9552f049a3386899dcd2
change-id: 20230313-apple_disabled_pcie_ports-469b7feebe32

Best regards,
-- 
Janne Grunau <j@jannau.net>

Re: [PATCH] pci: apple: Initialize only enabled ports

[Mark Kettenis]

> From: Janne Grunau <j@jannau.net>
> Date: Mon, 13 Mar 2023 14:46:11 +0100
> 
> The Linux devicetrees for Apple silicon devices are after review
> feedback switching from deleting unused PCIe ports to disabling them.
> 
> Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
> Signed-off-by: Janne Grunau <j@jannau.net>

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> ---
>  drivers/pci/pcie_apple.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/pcie_apple.c b/drivers/pci/pcie_apple.c
> index 9b08e1e5da87..b934fdbc35c2 100644
> --- a/drivers/pci/pcie_apple.c
> +++ b/drivers/pci/pcie_apple.c
> @@ -315,6 +315,8 @@ static int apple_pcie_probe(struct udevice *dev)
>  	for (of_port = ofnode_first_subnode(dev_ofnode(dev));
>  	     ofnode_valid(of_port);
>  	     of_port = ofnode_next_subnode(of_port)) {
> +		if (!ofnode_is_enabled(of_port))
> +			continue;
>  		ret = apple_pcie_setup_port(pcie, of_port);
>  		if (ret) {
>  			dev_err(pcie->dev, "Port %d setup fail: %d\n", i, ret);
> 
> ---
> base-commit: 6c1cdf158c4f3ccc8c5f9552f049a3386899dcd2
> change-id: 20230313-apple_disabled_pcie_ports-469b7feebe32
> 
> Best regards,
> -- 
> Janne Grunau <j@jannau.net>
> 
> 

Re: [PATCH] pci: apple: Initialize only enabled ports

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On Mon, Mar 13, 2023 at 02:46:11PM +0100, Janne Grunau wrote:

> The Linux devicetrees for Apple silicon devices are after review
> feedback switching from deleting unused PCIe ports to disabling them.
> 
> Link: https://lore.kernel.org/asahi/1ea2107a-bb86-8c22-0bbc-82c453ab08ce@linaro.org/
> Signed-off-by: Janne Grunau <j@jannau.net>
> Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]