From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEDE9C6FD1D for ; Thu, 30 Mar 2023 10:27:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BBE885E3D; Thu, 30 Mar 2023 12:27:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 6A34386043; Thu, 30 Mar 2023 12:27:20 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 4A58585E33 for ; Thu, 30 Mar 2023 12:27:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=abdellatif.elkhlifi@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D499F1682; Thu, 30 Mar 2023 03:28:00 -0700 (PDT) Received: from e130802.arm.com (unknown [10.57.21.18]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D4CED3F7BD; Thu, 30 Mar 2023 03:27:15 -0700 (PDT) Date: Thu, 30 Mar 2023 11:27:07 +0100 From: Abdellatif El Khlifi To: Simon Glass Cc: u-boot@lists.denx.de, nd@arm.com Subject: Re: [PATCH v10 03/10] lib: uuid: introduce testcase for uuid_str_to_le_bin Message-ID: <20230330102707.GA82371@e130802.arm.com> References: <20230328161157.219375-1-abdellatif.elkhlifi@arm.com> <20230328161157.219375-4-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, Mar 30, 2023 at 09:02:18AM +1300, Simon Glass wrote: > On Wed, 29 Mar 2023 at 05:12, Abdellatif El Khlifi > wrote: > > > > provide a test case > > > > Signed-off-by: Abdellatif El Khlifi > > Cc: Simon Glass > > --- > > MAINTAINERS | 5 +++++ > > test/lib/Makefile | 1 + > > test/lib/uuid.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 50 insertions(+) > > create mode 100644 test/lib/uuid.c > > Still this is missing a change log. Please can you check your process. This commit has been introduced in v9 patchset. No change made in the v10. In v11 I'll add a changelog reflecting the use of ut_asserteq_mem(). > Do you use patman? No, I'm planning to learn about it. > > Can you use ut_asserteq_mem()? If not, please add a comment as to why > that doesn't work, so it is clear. Thanks. It works and will be included in v11. Could you please provide a feedback for the other commits so I can address everything in one go in patchset v11 ? Cheers Abdellatif > > Regards, > SImon