From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A2EDC761A6 for ; Thu, 30 Mar 2023 15:25:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 17A8D86113; Thu, 30 Mar 2023 17:24:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680189899; bh=qasYDYAeDsVoGA96EPV7Lvh9yftfBrqMmgZZMLEFt9c=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=WmpymGV6Xblp9PMhM45Iypt5sPA/ZfHGymX2NEV51ekNkXFgQwoyqgcBAe9h9Cfrc +QBDt1sDZg++omG4D+Z3vTt+A+U2NULXk5HoZ99362kwNDVjqZhc9HClq7yaAspYLs +olFZrpJNuIj8+0qRR/BS/LBmx2HhvjdLPOBmmRpZdX4/Fbwad6RReBMC8mJz5FzF9 2rraswcgJAGuR6NwMn8LteNOZvlAveKnK6z2LNZdI8+iSBCwmJtCE5bOWh3ONH7GIM t2YUGPvBKY3CwzaSwkSJGWrK/tdubD7dF07ZUVcMc5c27AQcYGBY0Ot+OS2LD0Wkg7 j+Epao93hgVIg== Received: by phobos.denx.de (Postfix, from userid 109) id 08894860B3; Thu, 30 Mar 2023 17:23:33 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0EDC9860A6 for ; Thu, 30 Mar 2023 17:23:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4PnRyC5kvbz1r1fc; Thu, 30 Mar 2023 17:23:15 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4PnRyC5Tzgz1qqlb; Thu, 30 Mar 2023 17:23:15 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id p4jTIH_dbWWg; Thu, 30 Mar 2023 17:23:15 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Thu, 30 Mar 2023 17:23:15 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1752474 X-Patchwork-Delegate: sbabic@denx.de To: Marek Vasut ,u-boot@lists.denx.de Subject: [PATCH v4 06/14] net: dwc_eth_qos: Set DMA_MODE SWR bit to reset the MAC In-reply-to: <20230306145354.7439-6-marex@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20230330152333.08894860B3@phobos.denx.de> Date: Thu, 30 Mar 2023 17:23:20 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean > The driver currently only waits for DMA_MODE SWR bit to clear itself. > This is insufficient e.g. on i.MX8M Plus, where the MAC must be reset > before IOMUX GPR[1] content is latched into the MAC and used. Without > the proper reset, the i.MX8M Plus MAC variant does not take the value > in IOMUX GPR[1] into account, which makes it impossible e.g. to switch > interface mode from RGMII to any other. > Since proper reset is desired in general to put the block into defined > state, always assert the DMA_MODE SWR bit before waiting for the bit > to clear itself. > Reviewed-by: Ramon Fried > Signed-off-by: Marek Vasut Applied to u-boot-imx, next, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================