[PATCH 0/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[PATCH 0/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[Ying-Chun Liu (PaulLiu)]

We have a few places here that the function declarations do not
match their prototypes, correct them.

This bug was found by Tom.
https://lists.denx.de/pipermail/u-boot/2023-March/511786.html
And we fixes this bug by modifying ddr.h instead.

Ying-Chun Liu (PaulLiu) (1):
  compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

 board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.39.2

[PATCH 1/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[Ying-Chun Liu (PaulLiu)]

We have a few places here that the function declarations do not
match their prototypes, correct them.

Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>
---
 board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h b/board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h
index f7d4fdc101..508b4a565c 100644
--- a/board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h
+++ b/board/compulab/imx8mm-cl-iot-gate/ddr/ddr.h
@@ -25,7 +25,7 @@ struct lpddr4_tcm_desc {
 
 u32 cl_eeprom_get_ddrinfo(void);
 u32 cl_eeprom_set_ddrinfo(u32 ddrinfo);
-u32 cl_eeprom_get_subind(void);
-u32 cl_eeprom_set_subind(u32 subind);
+u8 cl_eeprom_get_subind(void);
+u8 cl_eeprom_set_subind(u8 subind);
 u32 cl_eeprom_get_osize(void);
 #endif
-- 
2.39.2

Re: [PATCH 1/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Tue, Mar 14, 2023 at 02:26:20AM +0800, Ying-Chun Liu (PaulLiu) wrote:

> We have a few places here that the function declarations do not
> match their prototypes, correct them.
> 
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>

Thanks for fixing this.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [PATCH 1/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[Fabio Estevam]

On Mon, Mar 13, 2023 at 3:26 PM Ying-Chun Liu (PaulLiu)
<paul.liu@linaro.org> wrote:
>
> We have a few places here that the function declarations do not
> match their prototypes, correct them.
>
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>

Reported-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

[PATCH 1/1] compulab: imx8mm-cl-iot-gate: Fix some function declarations in ddr.h

[sbabic]

> We have a few places here that the function declarations do not
> match their prototypes, correct them.
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paulliu@debian.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: NXP i.MX U-Boot Team <uboot-imx@nxp.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reported-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Applied to u-boot-imx, next, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================