From: Nishanth Menon <nm@ti.com>
To: Vaishnav Achath <vaishnav.a@ti.com>
Cc: <u-boot@lists.denx.de>, <trini@konsulko.com>, <vigneshr@ti.com>,
<gadiyar@ti.com>, <u-kumar1@ti.com>
Subject: Re: [PATCH 1/2] arm: dts: k3-j721e-mcu-wakeup: Disable hyperbus controller node
Date: Thu, 30 Mar 2023 13:50:53 -0500 [thread overview]
Message-ID: <20230330185053.3ouehfhxkbf7drer@geometric> (raw)
In-Reply-To: <20230330174005.24950-2-vaishnav.a@ti.com>
On 23:10-20230330, Vaishnav Achath wrote:
> J721E SoC has a hyperbus controller and OSPI controller muxed and only
> one of the controllers can be active at a time. While enabling the
> support for hyperbus, both the OSPI and hyperbus nodes were enabled
> by default and hyperbus was disabled in board dts. This causes issues
> in other J721E based platforms which does not explicitly disable the
> hbmc node in board dts, thus disable hyperbus node by default.
>
> Fixes: 297daac43afb ("arm: dts: k3-j721e-mcu-wakeup: Add HyperBus Controller node")
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
>
> Since this node is not present in corresponding upstream kernel DTS
> now, a manual fix is needed.
>
> arch/arm/dts/k3-j721e-mcu-wakeup.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> index 22166c7942..b7a0dd2326 100644
> --- a/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm/dts/k3-j721e-mcu-wakeup.dtsi
> @@ -183,6 +183,7 @@
> };
>
> hbmc: hyperbus@47034000 {
> + status = "disabled";
> compatible = "ti,j721e-hbmc", "ti,am654-hbmc";
> reg = <0x0 0x47034000 0x0 0x100>,
> <0x5 0x00000000 0x1 0x0000000>;
> --
> 2.17.1
>
We should just delete the entire node. this does'nt exist in upstream[1]
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-03-30 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 17:40 [PATCH 0/2] arm: dts: J721E Hyperbus Fixes Vaishnav Achath
2023-03-30 17:40 ` [PATCH 1/2] arm: dts: k3-j721e-mcu-wakeup: Disable hyperbus controller node Vaishnav Achath
2023-03-30 18:50 ` Nishanth Menon [this message]
2023-03-30 17:40 ` [PATCH 2/2] board: ti: j721e: Disable hyperflash fixup for J721E SK Vaishnav Achath
2023-03-30 17:43 ` [PATCH 0/2] arm: dts: J721E Hyperbus Fixes Gadiyar, Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230330185053.3ouehfhxkbf7drer@geometric \
--to=nm@ti.com \
--cc=gadiyar@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vaishnav.a@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox